From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mx.groups.io with SMTP id smtpd.web09.15534.1641942000644196547 for ; Tue, 11 Jan 2022 15:00:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20210112.gappssmtp.com header.s=20210112 header.b=S6kvy0hM; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.167.43, mailfrom: mw@semihalf.com) Received: by mail-lf1-f43.google.com with SMTP id h2so1835542lfv.9 for ; Tue, 11 Jan 2022 15:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DAwyh5awXRYkFXOkevRUsK+ORjjLYtGSeuRNcoWnmt0=; b=S6kvy0hMjooiiDQsxkjeEsBhxZ4udmy4ywn8ju1ZbSQcoSJir07JtFo6+QMUECP30g LPyKmji1ugnr+++z05EFEI2+Yl/a6AKZNPCYLzxIfLkAkJCGry2TOXuL4yhqHs7wx5xS NFfA0LaNeFZHP7CRlSKPunqxAeaG2e1pMuMR/4w4R35BvdChAZ8lTT2VWYrRkaKb0dai nT8B5uc5l5u3ygfamus9igNXEZ2umcbzYWuIHrr1kfRI2euGkaSB0grBOjc3uqlh0/z1 nIDBboASMQzHgHTEApibBU6t5vtCofYbuJLd9Wx9mrtniXYh7L8ge2YAzkQIA3HqN7K7 yApQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DAwyh5awXRYkFXOkevRUsK+ORjjLYtGSeuRNcoWnmt0=; b=CSSqb28RR5Mx+oHf9vkOUwrW5JO0kbN/WPqM8ES6m7GTLyNowNdxCkL8IZW351l1aL fexPqIRDZoa8sfaaCqpvtY/q11D/xFzLvNkFAlwVrfXDsNEyxcxAlACABbR56DUxXz1r KCXjO0oQGIKoa8qhyFkk0EZFkIzxBkdEZuXiFxlAKjeXuZxEU/IhO90e9vUfLaWxdg1M s0tXSD4w9MEqNFjDec78v7P8yq20fWtpzUBsqP5hPtGlTMGIW8Vd1tczP87gKGn6ItBf q50OZQwhxeVnexSRzNkOJfyP0zcrOiOLfRjdGIdTKl0RrZhb8i+KtAhSC3uyRV1BMM+l zoGw== X-Gm-Message-State: AOAM533cWzBobvswXI35+u3Go8yokmpUcaEdAA4/xvaEK3SdhOcd3z2U Rq9ie9LVHKcOx+unSTZU2IVgiEyy0+eQitNhHZfijw== X-Google-Smtp-Source: ABdhPJzDrOTJEf0M1jIC25RNCy+o3/f97HGSKeDAo3+rqP2Xv4UUTOIgwvUUHQuZ8ySIh892J5x2wKLM5oTgq5gV63E= X-Received: by 2002:a19:5e16:: with SMTP id s22mr4760311lfb.209.1641941998674; Tue, 11 Jan 2022 14:59:58 -0800 (PST) MIME-Version: 1.0 References: <20220111214626.1597-1-Sunny.Wang@arm.com> In-Reply-To: <20220111214626.1597-1-Sunny.Wang@arm.com> From: "Marcin Wojtas" Date: Tue, 11 Jan 2022 23:59:49 +0100 Message-ID: Subject: Re: [edk2-platform PATCH v1] Silicon/Marvell/Armada7k8k: Fix wrong SMBIOS version issue To: Sunny Wang Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable wt., 11 sty 2022 o 22:46 Sunny Wang napisa=C5=82(a): > > The SMBIOS data is based on v3.3.0, but its version is set to v3.2.0. > Since PcdSmbiosVersion in MdeModulePkg.dec is v3.3.0, so just remove > the platform overridden value in .dsc file to fix this issue. > > This also fixed the FWTS failure below: > dmicheck: Type 17 expects length of 0x54, has incorrect length of 0x5c > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Marcin Wojtas > Cc: Samer El-Haj-Mahmoud > > Signed-off-by: Sunny Wang > --- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marv= ell/Armada7k8k/Armada7k8k.dsc.inc > index 3b76acd99c..5e15378207 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -1,5 +1,5 @@ > # > -#Copyright (c) 2011-2012, ARM Limited. All rights reserved. > +#Copyright (c) 2011-2022, ARM Limited. All rights reserved. > #Copyright (C) 2016 Marvell International Ltd. > # > #SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -387,7 +387,6 @@ > # SMBIOS/DMI > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0 > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2 > - gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0302 > gMarvellTokenSpaceGuid.PcdFirmwareVersion|"EDK2 SH 1.1" > Reviewed-by: Marcin Wojtas Thanks! Marcin