From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D7250220D4BEC for ; Thu, 16 Nov 2017 06:34:49 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id y15so203943ita.4 for ; Thu, 16 Nov 2017 06:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dRRg13nlD61JthsN/mMy5INjHY2wBypOazwCA8debJo=; b=tyycMbjE061rfsHY5Mtl5abyL80aWff1D0I1ID/9lbKOHkvlDWUdd7rFseOhsY+fTK 23fc9B8C5emFtHrG1XNgvLNvdKK5kysDFscOb0Y7BeI+ovVbWO/RFi5pe7S95e0wK1PW ipcXv9Sco0BfBaAvKOXbRS5r32/4TouZEWDvMQn7PSyy2LsoZ5GMcUEID5gcrQ73KciH 4idtGSLBtuO04VCaL9HiXpCtTz9oHUYrzBsdyHJs5/42gLInlAWkWsTZuR1uLCSRRVfe LdqT2g5XScTxqLhTq2LFr/+VC9ndPLOb97iHgVmQyCPqVMR9drHvU7ycMJ3+uZmQ4Ff0 +nWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dRRg13nlD61JthsN/mMy5INjHY2wBypOazwCA8debJo=; b=CzxsRfUulBtxvxe9OSN5umg5ku0HYgqNsNm28bJr0Hbi9lkM0CzmBbkwPcXEGDe/fk Xd/yINMTGgtEl113w3k4Mlvx37oDRP4ALYyh7tfGvv0GVzjLJRYX9CExs7ToU3FKY3jV vi+//rFAzoKSOpDhr/qT7PptO0ks3oEzsAtMoM73LwNjPa1nqZKIO/8lp3DIMMhJmycX 4QVTNaxdx0aiCZMVGWUq8P3/jmkeeOE110EHGfvau4gi7qKEobWbuOWxAD8o+9c/LghI MZv8wgBKn4+MOaUWTl5cAFFSmjoVNqKLaks36lURnAxGlBvc8wgZrtXLQf5jci7YDWUm wDDg== X-Gm-Message-State: AJaThX7HP0s+azjXYAOHhFLQO4iNOFKL/oBZZX8aL7+WSmLQRcX8xV3y fNTX4GKuHNXFRACGX9OuINJG8LIy4pekf6aOyZmuAw== X-Google-Smtp-Source: AGs4zMaxRLkUs+Jd+5aP4FEtwbsPWnBSA5QFVlL4s2dQmyVPJimSyH7ogQks+SlBnzavh+Re0E32z4M2G3GyRe5kpow= X-Received: by 10.36.238.73 with SMTP id b70mr2286302iti.127.1510843138467; Thu, 16 Nov 2017 06:38:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Thu, 16 Nov 2017 06:38:57 -0800 (PST) In-Reply-To: References: <20171101150125.13679-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E176A26@SHSMSX104.ccr.corp.intel.com> From: Marcin Wojtas Date: Thu, 16 Nov 2017 15:38:57 +0100 Message-ID: To: Ard Biesheuvel Cc: "Gao, Liming" , "edk2-devel@lists.01.org" , "daniel.thompson@linaro.org" , "leif.lindholm@linaro.org" Subject: Re: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 14:34:50 -0000 Content-Type: text/plain; charset="UTF-8" Hi Ard, With both PIE disabling patches for AARCH64, when compiling ACPI tables with gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu- I get following errors: [...] aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie' Do I understand correctly, that I should either revert those patches or upgrade to the newer toolchain? Best regards, Marcin 2017-11-01 16:18 GMT+01:00 Ard Biesheuvel : > On 1 November 2017 at 15:13, Gao, Liming wrote: >> Reviewed-by: Liming Gao >> > > Thanks - pushed as 3380a591232de2ab3007ab051010a67c3d000d1c > >>> -----Original Message----- >>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>> Sent: Wednesday, November 1, 2017 11:01 PM >>> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming ; Zhu, Yonghong >>> >>> Cc: daniel.thompson@linaro.org; Ard Biesheuvel >>> Subject: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources >>> >>> Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE >>> linking") works around an issue that was caught due to the fact that >>> PIE linking produces broken .acpi files. However, v2 of that fix >>> inadvertently only applied the workaround to the normal linker command >>> line, and not to the ASLD one, so the issue still persists. >>> >>> So add the missing -no-pie options for ASLD on ARM and AARCH64. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >>> --- >>> BaseTools/Conf/tools_def.template | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template >>> index 98df0ffc9294..aebd7d558633 100755 >>> --- a/BaseTools/Conf/tools_def.template >>> +++ b/BaseTools/Conf/tools_def.template >>> @@ -4498,8 +4498,8 @@ DEFINE GCC5_ARM_DLINK_FLAGS = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie >>> DEFINE GCC5_ARM_DLINK2_FLAGS = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error >>> DEFINE GCC5_AARCH64_DLINK_FLAGS = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie >>> DEFINE GCC5_AARCH64_DLINK2_FLAGS = DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error >>> -DEFINE GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC49_ARM_ASLDLINK_FLAGS) >>> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) >>> +DEFINE GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie >>> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie >>> >>> #################################################################################### >>> # >>> -- >>> 2.11.0 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel