Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

[rebecca]

I've been working with the MACCHIATObin board, and noticed settings for
HTTP and TLS in Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc in
the repo
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform.git .
I'd like to enable them if possible to help with debugging a problem
with a boot loader. I added TlsLib to the build and things appeared to
work, but enrolling a server certificate, and entering an HTTP boot URL
fails ("HTTP is disabled"), presumably because I didn't build in the
underlying support.


I'm not sure if this is the right place to ask about it since it's in
the MarvellEmbeddedProcessors project and not TianoCore, but - I was
wondering where the place would be to add support libraries needed to
enable HTTP and TLS support? Would it be in
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc, or in
NetworkPkg/Network.dsc.inc in the main edk2 repo?


-- 
Rebecca Cran

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

[Leif Lindholm]

Hi Rebecca,

On Mon, May 27, 2019 at 05:34:08PM -0600, rebecca@bluestop.org wrote:
> I've been working with the MACCHIATObin board, and noticed settings for
> HTTP and TLS in Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc in
> the repo
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform.git .
> I'd like to enable them if possible to help with debugging a problem
> with a boot loader. I added TlsLib to the build and things appeared to
> work, but enrolling a server certificate, and entering an HTTP boot URL
> fails ("HTTP is disabled"), presumably because I didn't build in the
> underlying support.

This was actually enabled in the upstream edk2-platforms repository as
part of the "use fragment config files for network config" set:
205d5621a35eb6251481526039d24b17374efdf0

Since the PCIe updates just went in, that should now be a valid
replacement for the MarvellEmbededProcessors repo.

And will let you include HTTP with -D NETWORK_HTTP_BOOT_ENABLE=TRUE.

/
    Leif

> 
> I'm not sure if this is the right place to ask about it since it's in
> the MarvellEmbeddedProcessors project and not TianoCore, but - I was
> wondering where the place would be to add support libraries needed to
> enable HTTP and TLS support? Would it be in
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc, or in
> NetworkPkg/Network.dsc.inc in the main edk2 repo?
> 
> 
> -- 
> Rebecca Cran
> 
> 
> 
> 

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

[Marcin Wojtas]

Hi Rebecca,

wt., 28 maj 2019 o 10:39 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> Hi Rebecca,
>
> On Mon, May 27, 2019 at 05:34:08PM -0600, rebecca@bluestop.org wrote:
> > I've been working with the MACCHIATObin board, and noticed settings for
> > HTTP and TLS in Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc in
> > the repo
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform.git .
> > I'd like to enable them if possible to help with debugging a problem
> > with a boot loader. I added TlsLib to the build and things appeared to
> > work, but enrolling a server certificate, and entering an HTTP boot URL
> > fails ("HTTP is disabled"), presumably because I didn't build in the
> > underlying support.
>
> This was actually enabled in the upstream edk2-platforms repository as
> part of the "use fragment config files for network config" set:
> 205d5621a35eb6251481526039d24b17374efdf0
>
> Since the PCIe updates just went in, that should now be a valid
> replacement for the MarvellEmbededProcessors repo.

Please use the Tianocore repo only. With the latest changes, there is
no point to use old MarvellEmbededProcessors branch, I do not maintain
it. I also plan to update MacchiatoBin wiki with the reference to the
mainline repositories.

Best regards,
Marcin

>
> And will let you include HTTP with -D NETWORK_HTTP_BOOT_ENABLE=TRUE.
>
> /
>     Leif
>
> >
> > I'm not sure if this is the right place to ask about it since it's in
> > the MarvellEmbeddedProcessors project and not TianoCore, but - I was
> > wondering where the place would be to add support libraries needed to
> > enable HTTP and TLS support? Would it be in
> > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc, or in
> > NetworkPkg/Network.dsc.inc in the main edk2 repo?
> >
> >
> > --
> > Rebecca Cran
> >
> >
> > 
> >

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

[rebecca]

On 2019-05-28 03:47, Marcin Wojtas wrote:
> Please use the Tianocore repo only. With the latest changes, there is
> no point to use old MarvellEmbededProcessors branch, I do not maintain
> it. I also plan to update MacchiatoBin wiki with the reference to the
> mainline repositories.



Thank you! That makes things a whole lot easier.


-- 

Rebecca Cran

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

[rebecca]

On 2019-05-28 03:47, Marcin Wojtas wrote:
> Please use the Tianocore repo only. With the latest changes, there is
> no point to use old MarvellEmbededProcessors branch, I do not maintain
> it. I also plan to update MacchiatoBin wiki with the reference to the
> mainline repositories.


I can configure HTTP boot entries now if I build with
-DNETWORK_HTTP_BOOT_ENABLE=TRUE -DNETWORK_ALLOW_HTTP_CONNECTIONS .

However, I get an error if I try and enable HTTPS by building with
-DNETWORK_TLS_ENABLE :


build.py...
/home/bcran/workspace/edk2-platforms/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc(...):
error 4000: Instance of library class [TlsLib] is not found
        in [/home/bcran/workspace/edk2/NetworkPkg/TlsDxe/TlsDxe.inf]
[AARCH64]
        consumed by module
[/home/bcran/workspace/edk2/NetworkPkg/TlsDxe/TlsDxe.inf]


-- 
Rebecca Cran

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

[Liming Gao]

TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf is required to be added into [LibraryClasses] of edk2-platforms\Silicon\Marvell\Armada7k8k\Armada7k8k.dsc.inc

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>rebecca@bluestop.org
>Sent: Wednesday, May 29, 2019 10:19 AM
>To: Marcin Wojtas <mw@semihalf.com>
>Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm
><leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin
>(from the MarvellEmbeddedProcessors edk2-open-platforms repo)
>
>On 2019-05-28 03:47, Marcin Wojtas wrote:
>> Please use the Tianocore repo only. With the latest changes, there is
>> no point to use old MarvellEmbededProcessors branch, I do not maintain
>> it. I also plan to update MacchiatoBin wiki with the reference to the
>> mainline repositories.
>
>
>I can configure HTTP boot entries now if I build with
>-DNETWORK_HTTP_BOOT_ENABLE=TRUE -
>DNETWORK_ALLOW_HTTP_CONNECTIONS .
>
>However, I get an error if I try and enable HTTPS by building with
>-DNETWORK_TLS_ENABLE :
>
>
>build.py...
>/home/bcran/workspace/edk2-
>platforms/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc(...):
>error 4000: Instance of library class [TlsLib] is not found
>        in [/home/bcran/workspace/edk2/NetworkPkg/TlsDxe/TlsDxe.inf]
>[AARCH64]
>        consumed by module
>[/home/bcran/workspace/edk2/NetworkPkg/TlsDxe/TlsDxe.inf]
>
>
>--
>Rebecca Cran
>
>
>

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

[rebecca]

On 2019-05-28 02:39, Leif Lindholm wrote:
>
> This was actually enabled in the upstream edk2-platforms repository as
> part of the "use fragment config files for network config" set:
> 205d5621a35eb6251481526039d24b17374efdf0
>
> Since the PCIe updates just went in, that should now be a valid
> replacement for the MarvellEmbededProcessors repo.
>
> And will let you include HTTP with -D NETWORK_HTTP_BOOT_ENABLE=TRUE.


Thanks. I've also just realized that the devel-OpenPlatformPkg branch
(and probably the others, like devel-MinnowBoardMax-UDK2017) in
edk2-platforms is no longer used. 

Should the Readme.md files be updated to suggest people use master
instead, or perhaps the branches deleted (or closed, if that's something
that can be done in git)? I vaguely remember a discussion here about
switching to using the master branch, but other people coming back to it
might need a bit of a reminder!


-- 
Rebecca Cran