Re: [PATCH v6 21/23] Applications/FirmwareUpdate: Add 'fupdate' comand to shell

[Marcin Wojtas <mw@semihalf.com>]

Hi Jaben,

Thank you for your input.

>
> I agree on EBL, but I have very little experience with EBL so I don’t want to discuss in detail as I am not the right person without more research.  Specifically, my gut reaction is that needing a platform specific boot loader indicates that something has already gone wrong on that platform.
>
> However, this does not seem like a boot loader or an application at all.  this is an internal shell command. The goal here seems to be to create a NULL library to add a new internal command to the UEFI Shell.  This library gets compiled/linked into the shell itself.

Indeed, it's nothing similar to the bootloader whatsoever. This
command simply enables updating firmware in SPI flash directly from
local path or from tftp.

>
> I feel that we have found a "new" use case that I encountered, but worked around in the past because all previous cases involved commands in the same library (there are interactions between Reconnect and Disconnect/Connect).

Right, however Reconnect is easy, as it simply calls gBS callbacks,
whose definition are also in the same location.

>
> I would say that a new API in the ShellCommandLib that links the UEFI Shell Application to the NULL libraries that make up the internal commands would be my first choice for implementation.  I would lean to something like the function that Marcin already called.  Maybe this?
>
> EFIAPI
> RunRegisteredCommand(
>   CHAR16* CommandLine,
>   EFI_STATUS *CommandReturnValue
> )

I'll try this one and let know.

Thanks,
Marcin