From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28F382118FF10 for ; Tue, 13 Nov 2018 22:16:47 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id k206-v6so22238834ite.0 for ; Tue, 13 Nov 2018 22:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fbMYqwQB3LVR5ZcGu52pDRnLw3gb79cT1sNVFWB4JlQ=; b=Z2PWhOttUwuK5538S/tB4GsfCA3pB7XUh3mxCtQgyKFgV/iM00d0xGLI6Pwev16ufK dTEVx/VVuEq94Zf49cyNESeNxilBkFeenJDtwhwIcDDChNPcBLEGG/OdUAUFMhzuy6ao NA6+XiNA1iIIe+oBxaEIrdnOCvLoaxM9IOQvue1UEgz/6yXPLJwFq+rU1/W3OwCbR49j pVnig5697MugQ6hLM+aoLL7S41dGSkUDSebmp134L5h19S0fPsDZfAfpi7J/uADY1Bay J0c4qeqtEFhHbEQKleHh/pSqDwOxva5Y5ZQRFIfBlrDOgbG1LAs4N2cJEYcBlAo1k1Rs TWhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fbMYqwQB3LVR5ZcGu52pDRnLw3gb79cT1sNVFWB4JlQ=; b=pbM7C3U/rXYX8yoP8kDXtVU+wr4AxCqtc9zfJlIZgb7+iIReAC0WTj2bQnlhBpyKxG j5wrtdgJi+TSdrltlEdaO+hMCisRsulmIcilxnTYC3pdv46qacaqiyy88uC/nSd6vPvh teU9tIoc1UgZq53Go+XxbZbXTvjzCJW9Wb0m3cwWlzexOtQ/MFsBp0wMlGj6qTeJ8g3w img/wexoVIsU0nBXKpMLdwep/JfAIyjf5QNJmHkep1VJQx8YwrQkJc/fw0CqBIF7/yBI toZbb6UX8y6QwVX/Y6Dr5HtARPBduXjeMzoHYNzQG4fyvv7hwwcFE0VO8Pt9x/BiKVHg UJ1Q== X-Gm-Message-State: AGRZ1gJjBkikz6EcFbJq2LN0E6Eb123b16Kg0K/5X6E//4vcXUkVVcxB JgcjJcoPwQNJJl3mk0Xi26SROnXvq6v2rXnOGY7cqfIm X-Google-Smtp-Source: AFSGD/WxOSeFaRSuRnz398pWSGhGWiuiSDB7Cif5J9mCnF7+AWcYMzzmm9u7AqpOZoz4SgKMDYQpptyg97mZOH2zGWg= X-Received: by 2002:a05:660c:681:: with SMTP id n1mr839608itk.37.1542176206259; Tue, 13 Nov 2018 22:16:46 -0800 (PST) MIME-Version: 1.0 References: <1540000661-1956-1-git-send-email-mw@semihalf.com> <1540000661-1956-3-git-send-email-mw@semihalf.com> <20181114011222.pqyq2rlkcvn7glmq@bivouac.eciton.net> In-Reply-To: <20181114011222.pqyq2rlkcvn7glmq@bivouac.eciton.net> From: Marcin Wojtas Date: Wed, 14 Nov 2018 07:16:33 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Subject: Re: [platforms: PATCH 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 06:16:47 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, =C5=9Br., 14 lis 2018 o 02:12 Leif Lindholm napi= sa=C5=82(a): > > On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote: > > This patch extends library with GPIO devices per-board > > description. Both embedded SoC controllers and > > I2C IO expanders are supported. Add a helper routine > > for obtaining information about the latter. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marcin Wojtas > > --- > > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 23 ++++++++++++= ++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Sil= icon/Marvell/Include/Library/ArmadaBoardDescLib.h > > index ee8e06e..109164c 100644 > > --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > @@ -25,6 +25,29 @@ typedef struct { > > } MV_BOARD_COMPHY_DESC; > > > > // > > +// GPIO devices per-board description > > +// > > +typedef struct { > > + UINTN ChipId; > > + UINTN I2cAddress; > > + UINTN I2cBus; > > +} MV_I2C_IO_EXPANDER_DESC; > > + > > +typedef struct { > > + MV_SOC_GPIO_DESC *SoC; > > + UINTN GpioDevCount; > > + MV_I2C_IO_EXPANDER_DESC *I2cIoExpanderDesc; > > + UINTN I2cIoExpanderCount; > > +} MV_BOARD_GPIO_DESC; > > + > > +EFI_STATUS > > +EFIAPI > > +ArmadaBoardDescGpioGet ( > > + IN OUT MV_I2C_IO_EXPANDER_DESC **I2cIoExpanderDesc, > > + IN OUT UINTN *I2cIoExpanderCount > > Please expand all DESC/Desc to descriptor/description/whatever as > appropriate. Just to confirm - until now in every case there was an abbreviation used (in SoCDescLib, structures names, etc.). It may look somewhat inconsistently, but of course I can change according to your wish. Please let know your thoughts on that. Thanks, Marcin > With that, Reviewed-by: Leif Lindholm > > > + ); > > + > > +// > > // I2C devices per-board description > > // > > typedef struct { > > -- > > 2.7.4 > >