From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::230; helo=mail-it0-x230.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B94120356896 for ; Thu, 16 Nov 2017 07:03:45 -0800 (PST) Received: by mail-it0-x230.google.com with SMTP id y15so319557ita.4 for ; Thu, 16 Nov 2017 07:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Uxgtzvt1YWnDIzDVG9vQU5LeaNTi6NkMM7g1/md1NLo=; b=xwYWPj09XQSnycdeV0AG2ei1n1/7aX+Uk0Cs0la7u/uUSYIHrW70cAbswO34jyg/jc J91WJEHsVdXmnWFHhpD82vT3Ijsv1HxHHeGVTirPCsx+SK53Mo2D6O4sMJLtPeOpLsBL Rp7OyhicASAM/9FLJubxakJ11qKZR3VhW/gmxNu4wHoQDjYZChKDuH56Quki65jf2JWp LVFnbfxU+a0kYOtVcrMir2rWtonefSoEfgpec+N+Fhl4sCKdWhqLj02gWD2M/p6dxnaU 0wXvx+3Ss3ICQBJZIVFrn2kH+HKMNoJn0sOMLP8y8WJ0U+k1P6zLehi1JWQXxzrWGI19 hGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Uxgtzvt1YWnDIzDVG9vQU5LeaNTi6NkMM7g1/md1NLo=; b=IRDxFWp/unKj8p++Ce0IqYWz7kub0GTbRm9VODPeL4LU96LHZSPLKpy8rLtCd7Vmic 6ViQT7g6vwGBxpLOsv5dzdec1XS4UkEyy2TU0ZUxQWrvWnopxI69SGNCle1pLw/lm9Dv CGVV7tdzoT5t1bdeCf8QTUiCl5geo+bGLQ693JZBSW0+q47LUCyG2QpmntRvzYvc5vmu 1OFZDBB+ZDRZEfEuTAzqFosxGZmRoS51gAsneXpCsJywLr58eTr5I1hyXd6AE5EHF4fR gvMZhchV1n+KyFED2mNFY087nlNJPDGEgrQ/FZtgIVwskDYqO89IszYtbujtDipSCqrf LVfA== X-Gm-Message-State: AJaThX7uSAjbn2U62g7Lejd+4dkS5OStvf6/0qb8lmBHihIR0vKeU96a yy/m3JKDvT7F27D/NSZWCJeag/GqILaXbEgrd+/c8nCG3wU= X-Google-Smtp-Source: AGs4zMZlrLLbiYqKjaDLnYjlAVyMcHk1qASocs2Ha2trPZ7w/JHmfevziaPVfwIj24ZnqzyEsMnwUkJshRNgANOGVC0= X-Received: by 10.36.66.18 with SMTP id i18mr2646746itb.148.1510844874285; Thu, 16 Nov 2017 07:07:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Thu, 16 Nov 2017 07:07:53 -0800 (PST) In-Reply-To: References: <20171101150125.13679-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E176A26@SHSMSX104.ccr.corp.intel.com> From: Marcin Wojtas Date: Thu, 16 Nov 2017 16:07:53 +0100 Message-ID: To: Ard Biesheuvel Cc: "Gao, Liming" , "edk2-devel@lists.01.org" , "daniel.thompson@linaro.org" , "leif.lindholm@linaro.org" Subject: Re: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 15:03:45 -0000 Content-Type: text/plain; charset="UTF-8" Hi Ard, 2017-11-16 15:48 GMT+01:00 Ard Biesheuvel : > On 16 November 2017 at 14:38, Marcin Wojtas wrote: >> Hi Ard, >> >> With both PIE disabling patches for AARCH64, when compiling ACPI tables with >> gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu- >> I get following errors: >> [...] >> aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie' >> Do I understand correctly, that I should either revert those patches >> or upgrade to the newer toolchain? >> > > Ugh. > > I thought GCC 5 and later implemented -no-pie, but apparently not. > > Does this fix your build? I will need to check whether it fixes the > original issue, but hopefully your toolchain doesn't choke on this: > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index aebd7d558633..111fe8da7773 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -4496,10 +4496,10 @@ DEFINE GCC5_AARCH64_CC_FLAGS = > DEF(GCC49_AARCH64_CC_FLAGS) > DEFINE GCC5_AARCH64_CC_XIPFLAGS = DEF(GCC49_AARCH64_CC_XIPFLAGS) > DEFINE GCC5_ARM_DLINK_FLAGS = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie > DEFINE GCC5_ARM_DLINK2_FLAGS = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error > -DEFINE GCC5_AARCH64_DLINK_FLAGS = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie > +DEFINE GCC5_AARCH64_DLINK_FLAGS = DEF(GCC49_AARCH64_DLINK_FLAGS) > -Wl,-no-pie > DEFINE GCC5_AARCH64_DLINK2_FLAGS = > DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error > DEFINE GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie > -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = > DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie > +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = > DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -Wl,-no-pie > > #################################################################################### > # > Unfortunately no change, still: aarch64-linux-gnu-gcc: error: unrecognized command line option '-no-pie' In order to make sure, I double checked twice cleaninig everything and rebuilding from scratch. Marcin