From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0E2EC210C1B9E for ; Wed, 25 Jul 2018 02:47:05 -0700 (PDT) Received: by mail-io0-x243.google.com with SMTP id w11-v6so5824954iob.2 for ; Wed, 25 Jul 2018 02:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FJm44iF+xHM3fyQChiMwa36bQao7vtCCLFf3RiEsF1Q=; b=gD3hKRlqP6lUJ74/b6KVddvW8bmCyQN8y0Nt+7zREPJ9/zHpbk3iWiUvGFQ2GXG0J3 Cz45qxeeEyz9IVx3nGsOjbwWF68cUZgGQfxkY7DYR/K1dps7nq8ffsztD+tAtoijodl2 b/+PfVvtptGfBWGT97cS2r19Ipqbzhvpra0DpE1Yya3uP5tT7spPQ47keZTUPF65VRu0 Z5GhNUD16sDdTRkO73JGoNMy+lwPqfRYKEFD6/g99nVNGEKOaK0lJBSXlElbOHCOQU3m JM/+qF5hPVskQI3JoJoPuC3oQIOtPS/VnN/vv3bKRy+rHaF7WTMfaA2GL9m+W6zS1589 cr/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FJm44iF+xHM3fyQChiMwa36bQao7vtCCLFf3RiEsF1Q=; b=Y7cHD3W7HPfDNn0Z5kB2gfQ0QbWZtf+iSeha0sS3iTcAEDcAmSsaHzlf486TdOC8y4 PD24yeXo1pt+YSOneBJ4Txb3P5TXSW2KE7fDNWtgaY4AHyXflBW39hkvb0cxqEr9BUu9 F0al+z811C1Czi7Iege2zlmXB9JWHAnkzFQyMq5QN1eQI80va8f0qB9vYtzRBFSO7RPU jX5C+7TGozjBIB7xlQs4R0P1HLVcGrsW9IXs34JegDcBzbM9fu2L0PMLmXxJxoHnxDPF 4tubvv5VU5MVseINy1LRnjDNbBDp2bKAPVoxFSVj1EiT+SBhAEVcxkj6/hE+4QhXjVWj P+Vw== X-Gm-Message-State: AOUpUlERb5KYrdMrwnWaO5IaiBsrjTcys/o784nkQtnSnCyK2f0W4dzS N/f78C6lrrEID1cyPx7H7m7FIFgYZ9OrSp17EzT9Og== X-Google-Smtp-Source: AAOMgpcsz0/Afve+1c8B69pcHVr1/ARrZa5qhnquc1tJtAI5KBkn+oyEnQ1+bMis4hJ0TF0uxhRl/8OudIKzd++Hnh4= X-Received: by 2002:a5e:c60c:: with SMTP id f12-v6mr17106359iok.108.1532512025208; Wed, 25 Jul 2018 02:47:05 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:8e47:0:0:0:0:0 with HTTP; Wed, 25 Jul 2018 02:47:04 -0700 (PDT) In-Reply-To: References: <1531469533-31787-1-git-send-email-mw@semihalf.com> From: Marcin Wojtas Date: Wed, 25 Jul 2018 11:47:04 +0200 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Hanna Hawa , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms: PATCH v2 0/6] Armada7k8k ICU support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 09:47:06 -0000 Content-Type: text/plain; charset="UTF-8" 2018-07-25 11:33 GMT+02:00 Ard Biesheuvel : > On 13 July 2018 at 10:12, Marcin Wojtas wrote: >> Hi, >> >> The second version of the ICU patchset brings all corrections >> according to all review remarks. They were mostly style / naming >> - detailed list can be found in the changelog below. >> >> The patches are available in the github: >> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/icu-upstream-r20180713 >> >> I'm looking forward to review and any comments/remarks. >> >> Best regards, >> Marcin >> >> Changelog >> v1 -> v2 >> * 1,6 >> - Add Ard's RB >> >> * 2 >> - Change ICU_IRQ_TYPE to IcuIrqTypeLevel / IcuIrqTypeEdge >> >> * 3 >> - Use EFI_PHYSICAL_ADDRESS >> >> * 4 >> - Put a space after { and before } >> - Change enum values to IcuGroupXxx format >> >> * 5 >> - Use ICU_GROUP_REGISTER_BASE_OFFSET instead of a raw value in macros >> - Add missing parentheses and use sizeof (UINT32) in ICU_INT_CFG macro >> - Use mEfiExitBootServicesEvent - not initialized and STATIC >> - s/IcuConfigDefault/IcuInitialConfig/ >> - Break to long lines >> >> Marcin Wojtas (6): >> Marvell/Armada70x0Db: Set correct CP110 count >> Marvell/Library: Introduce ArmadaIcuLib class >> Marvell/Library: Armada7k8kSoCDescLib: Enable getting CP base address >> Marvell/Library: Armada7k8kSoCDescLib: Introduce ICU information >> Marvell/Library: Implement common ArmadaIcuLib >> Marvell/Armada7k8k: Enable ICU configuration >> > > Reviewed-by: Ard Biesheuvel > > Pushed as 80f6be6eb12b..bd325517ba42 (with 5/6 updated to the v3 version) > Thanks! >> Silicon/Marvell/Marvell.dec | 1 + >> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + >> Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 7 +- >> Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.inf | 1 + >> Silicon/Marvell/Library/IcuLib/IcuLib.inf | 38 +++ >> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 12 + >> Silicon/Marvell/Include/Library/ArmadaIcuLib.h | 45 +++ >> Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 39 +++ >> Silicon/Marvell/Library/IcuLib/IcuLib.h | 47 +++ >> Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.c | 2 + >> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 50 +++ >> Silicon/Marvell/Library/IcuLib/IcuLib.c | 317 ++++++++++++++++++++ >> 12 files changed, 558 insertions(+), 2 deletions(-) >> create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.inf >> create mode 100644 Silicon/Marvell/Include/Library/ArmadaIcuLib.h >> create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.h >> create mode 100644 Silicon/Marvell/Library/IcuLib/IcuLib.c >> >> -- >> 2.7.4 >>