From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::236; helo=mail-io0-x236.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4FA91208F7903 for ; Tue, 10 Oct 2017 08:00:11 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id m81so14786151ioi.13 for ; Tue, 10 Oct 2017 08:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YkX06XIz+tXwwAhZAVYzJ2NGSYwENqt7LDoMg/S81Oc=; b=lzYIRQcWwWyP5gV1flt81xPzoeYG1Q+ni9uIxS6JxC1COe48/LiRysiZiervri1dtK b55kIE6x2xPAaal220Z1iMh14QiZyrJmhvFlSfuc4GgW2OQtDBSthvL3UOjPZ21CXCvC ClnqIIPbJ/kf2+THAO+UbNHh7LCAhJPpBatKNks3l2P438fS9f1cba1q1TUz8+R/aG8S qxcGFxa2V/SKdgzl3NOK/NyBNpKlOG4upkMj7tfP1bNXFLG/4jPVctgJa8unLbo7rc7Q Da+mlarPwEaYveJgu2/knDf9g5kGGyvjPAvoMvDtb4SJvCWsMqD9YJTxCcvPu0LvQ5Db PVig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YkX06XIz+tXwwAhZAVYzJ2NGSYwENqt7LDoMg/S81Oc=; b=LMQzwg3Gsaahr+nc4rYzpAGT5Pu/ta9JXacie1dqGkyUfHVerfELnZp6TRwXl617Os RGnhK3g/Q/FC97fPqu7kHZFazTkJBWfnpQDFc5EztVOdSKMdtQDB/XNrG167XOoiT7OY ApyoFUBFP55ijW2SLcggK6scIZkeFOetDEtU1pdSYOJpmGMVEXDnxgAfOj3FOSivQ5KT rtZpRP6M2z8s9hEFRSStdpf6BcG4qRRG48JlZF/jujhy/5wjdY4T5iQ7+urB3Y9N+nl7 WijTvvhBgszxnKJBOJDxVjcKKo6s9WG+5CKQu6qwwxhyKF1Thzc9N0OsloRdXGyxxOst B3wA== X-Gm-Message-State: AMCzsaV4VueUwW2WgyQCAVtVfIG28a0Gcw2nyRBS6KwmcQMnDhxNelVT aaUV5h/ojTj9BZGsNqR7ICQPBptbH07ewOrNfZ3tDDnC X-Google-Smtp-Source: AOwi7QCoY38mylojbnpoecAWtsk9ql0AVKFIOMVvLCCvAFFwbDSEOXvaoUT+pyc+2tOQqFRPcXRW96Q0wfhRfFFN8jk= X-Received: by 10.107.27.141 with SMTP id b135mr17462756iob.262.1507647819027; Tue, 10 Oct 2017 08:03:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Tue, 10 Oct 2017 08:03:38 -0700 (PDT) In-Reply-To: <20171010145839.nxoiifoqrw6s4fnt@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-12-git-send-email-mw@semihalf.com> <20171010145839.nxoiifoqrw6s4fnt@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 10 Oct 2017 17:03:38 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 11/13] Marvell/Armada: Remove outdated SEC alignment override X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 15:00:11 -0000 Content-Type: text/plain; charset="UTF-8" 2017-10-10 16:58 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 07:01:00PM +0200, Marcin Wojtas wrote: >> From: Ard Biesheuvel >> >> The FDFs no longer require explicit alignment for sections containing >> aligned objects, so change it to 'Auto' and FIXED (which allows some >> padding to be removed), and remove some other cruft while at it. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> Signed-off-by: Marcin Wojtas >> --- >> Platform/Marvell/Armada/Armada70x0.fdf | 11 ++--------- >> 1 file changed, 2 insertions(+), 9 deletions(-) >> >> diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf >> index 2c3efe0..15ae52b 100644 >> --- a/Platform/Marvell/Armada/Armada70x0.fdf >> +++ b/Platform/Marvell/Armada/Armada70x0.fdf >> @@ -235,16 +235,9 @@ READ_LOCK_STATUS = TRUE >> # >> ############################################################################ >> >> -[Rule.ARM.SEC] >> - FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED { >> - TE TE Align = 32 $(INF_OUTPUT)/$(MODULE_NAME).efi >> - } >> - >> -# The AArch64 Vector Table requires a 2K alignment that is not supported by the FDF specification. >> -# It is the reason 4K is used instead of 2K for the module alignment. >> [Rule.AARCH64.SEC] >> - FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED { >> - TE TE Align = 4K $(INF_OUTPUT)/$(MODULE_NAME).efi >> + FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED FIXED { >> + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > > This does appear to arbitrarily increase indentation of the last entry > on the line by 2, shifting it out of alignment with later entries in > the file? > I'll correct indentation in v2. Thanks, Marcin > / > Leif > >> } >> >> [Rule.Common.PEI_CORE] >> -- >> 1.8.3.1 >>