* [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
@ 2021-05-23 9:15 Marcin Wojtas
2021-05-24 2:09 ` [edk2-devel] " Sunny Wang
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
0 siblings, 2 replies; 10+ messages in thread
From: Marcin Wojtas @ 2021-05-23 9:15 UTC (permalink / raw)
To: devel
Cc: liming.gao, michael.d.kinney, leif, ardb+tianocore,
Samer.El-Haj-Mahmoud, sunny.Wang, gjb, upstream, Marcin Wojtas
The Microsoft Debug Port Table 2 (DBG2) specification revision
May 31, 2017 adds support for 16550-compatible Serial Port
Subtype with parameters defined in Generic Address Structure (GAS) [1]
Reflect that in the EDK2 headers.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
index 3faa30b76a..9ccfc1b1ee 100644
--- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
+++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
@@ -47,6 +47,7 @@ typedef struct {
#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART 0x000e
#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC 0x000f
#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART 0x0010
+#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS 0x0012
#define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001
#define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD 0x0000
#define EFI_ACPI_DBG2_PORT_TYPE_USB 0x8002
diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index 2066c7895e..7796796afe 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -100,6 +100,11 @@ typedef struct {
///
#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10
+///
+/// 16550-compatible with parameters defined in Generic Address Structure
+///
+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550_WITH_GAS 0x12
+
//
// Interrupt Type
//
--
2.29.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-23 9:15 [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 Marcin Wojtas
@ 2021-05-24 2:09 ` Sunny Wang
2021-05-24 2:21 ` Marcin Wojtas
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
1 sibling, 1 reply; 10+ messages in thread
From: Sunny Wang @ 2021-05-24 2:09 UTC (permalink / raw)
To: devel@edk2.groups.io, mw@semihalf.com
Cc: liming.gao@intel.com, michael.d.kinney@intel.com,
leif@nuviainc.com, ardb+tianocore@kernel.org,
Samer El-Haj-Mahmoud, gjb@semihalf.com, upstream@semihalf.com,
Sunny Wang
Looks good, Marcin.
However, it looks like something wrong with the line-ending. Could you check if your line-ending setting is CR/LF? Did you use /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could you use it? I expect this tool can catch the line-ending problem.
Best Regards,
Sunny Wang
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin Wojtas via groups.io
Sent: Sunday, May 23, 2021 5:15 PM
To: devel@edk2.groups.io
Cc: liming.gao@intel.com; michael.d.kinney@intel.com; leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>; gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas <mw@semihalf.com>
Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
Reflect that in the EDK2 headers.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
index 3faa30b76a..9ccfc1b1ee 100644
--- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
+++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
@@ -47,6 +47,7 @@ typedef struct {
#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART 0x0010+#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB 0x8002diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index 2066c7895e..7796796afe 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
+++ h
@@ -100,6 +100,11 @@ typedef struct {
/// #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10 +///+/// 16550-compatible with parameters defined in Generic Address Structure+///+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550_WITH_GAS 0x12+ // // Interrupt Type //--
2.29.0
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75464): https://edk2.groups.io/g/devel/message/75464
Mute This Topic: https://groups.io/mt/83024903/5985097
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -=-=-=-=-=-=
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-24 2:09 ` [edk2-devel] " Sunny Wang
@ 2021-05-24 2:21 ` Marcin Wojtas
2021-05-24 3:20 ` Sunny Wang
0 siblings, 1 reply; 10+ messages in thread
From: Marcin Wojtas @ 2021-05-24 2:21 UTC (permalink / raw)
To: Sunny Wang
Cc: devel@edk2.groups.io, michael.d.kinney@intel.com,
leif@nuviainc.com, ardb+tianocore@kernel.org,
Samer El-Haj-Mahmoud, gjb@semihalf.com, upstream@semihalf.com
Hi Sunny,
pon., 24 maj 2021 o 04:09 Sunny Wang <Sunny.Wang@arm.com> napisał(a):
>
> Looks good, Marcin.
> However, it looks like something wrong with the line-ending. Could you check if your line-ending setting is CR/LF? Did you use /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could you use it? I expect this tool can catch the line-ending problem.
The line endings are fine in my repo, I generated and sent the patch as usual.
And of course prior to sending I ran PatchCheck.py - it complains only
about too long URL line in the commit message, but the line-endings
are ok.
$ python3 /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py -1
Checking git commit: HEAD
MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
WARNING - Line 9 of commit message is too long (91 >= 76).
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
The commit message format passed all checks.
The code passed all checks.
Do you check the line endings in a different way?
Best regards,
Marcin
>
> Best Regards,
> Sunny Wang
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin Wojtas via groups.io
> Sent: Sunday, May 23, 2021 5:15 PM
> To: devel@edk2.groups.io
> Cc: liming.gao@intel.com; michael.d.kinney@intel.com; leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>; gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas <mw@semihalf.com>
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
>
> The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1]
>
> Reflect that in the EDK2 headers.
>
> [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..9ccfc1b1ee 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -47,6 +47,7 @@ typedef struct {
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART 0x0010+#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB 0x8002diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..7796796afe 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -100,6 +100,11 @@ typedef struct {
> /// #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10 +///+/// 16550-compatible with parameters defined in Generic Address Structure+///+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550_WITH_GAS 0x12+ // // Interrupt Type //--
> 2.29.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#75464): https://edk2.groups.io/g/devel/message/75464
> Mute This Topic: https://groups.io/mt/83024903/5985097
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -=-=-=-=-=-=
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-24 2:21 ` Marcin Wojtas
@ 2021-05-24 3:20 ` Sunny Wang
2021-05-24 8:42 ` 回复: " gaoliming
0 siblings, 1 reply; 10+ messages in thread
From: Sunny Wang @ 2021-05-24 3:20 UTC (permalink / raw)
To: Marcin Wojtas
Cc: devel@edk2.groups.io, michael.d.kinney@intel.com,
leif@nuviainc.com, ardb+tianocore@kernel.org,
Samer El-Haj-Mahmoud, gjb@semihalf.com, upstream@semihalf.com,
gaoliming@byosoft.com.cn, Sunny Wang
Add Liming's new email.
Hi Marcin,
There seems no LF (0A).
1. From the patch I got below in this email, several lines got merged into one line.
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART 0x0010+#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB
2. In https://edk2.groups.io/g/devel/topic/patch_1_1_mdepkg_add_new/83024903?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83024903, I saw "=0D" appending to each line. I'm not sure if this is relevant.
Moreover, I don't see #1 and #2 in another similar code change https://edk2.groups.io/g/devel/message/75283?p=,,,20,0,0,0::relevance,,MdePkg%3A+Update+DBG2+and+SPCR+header+with+NVIDIA+16550+Subtype,20,2,0,82919032.
Of course, if this won't cause any issue with pushing the patch, I'm totally fine with this.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>
Best Regards,
Sunny Wang
-----Original Message-----
From: Marcin Wojtas <mw@semihalf.com>
Sent: Monday, May 24, 2021 10:21 AM
To: Sunny Wang <Sunny.Wang@arm.com>
Cc: devel@edk2.groups.io; michael.d.kinney@intel.com; leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com; upstream@semihalf.com
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
Hi Sunny,
pon., 24 maj 2021 o 04:09 Sunny Wang <Sunny.Wang@arm.com> napisał(a):
>
> Looks good, Marcin.
> However, it looks like something wrong with the line-ending. Could you check if your line-ending setting is CR/LF? Did you use /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could you use it? I expect this tool can catch the line-ending problem.
The line endings are fine in my repo, I generated and sent the patch as usual.
And of course prior to sending I ran PatchCheck.py - it complains only about too long URL line in the commit message, but the line-endings are ok.
$ python3 /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py -1 Checking git commit: HEAD
MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 WARNING - Line 9 of commit message is too long (91 >= 76).
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
The commit message format passed all checks.
The code passed all checks.
Do you check the line endings in a different way?
Best regards,
Marcin
>
> Best Regards,
> Sunny Wang
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin
> Wojtas via groups.io
> Sent: Sunday, May 23, 2021 5:15 PM
> To: devel@edk2.groups.io
> Cc: liming.gao@intel.com; michael.d.kinney@intel.com;
> leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>;
> gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> <mw@semihalf.com>
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> The Microsoft Debug Port Table 2 (DBG2) specification revision May 31,
> 2017 adds support for 16550-compatible Serial Port Subtype with
> parameters defined in Generic Address Structure (GAS) [1]
>
> Reflect that in the EDK2 headers.
>
> [1]
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi
> -debug-port-table
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h |
> 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..9ccfc1b1ee 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -47,6 +47,7 @@ typedef struct {
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART 0x0010+#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB 0x8002diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..7796796afe 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -100,6 +100,11 @@ typedef struct {
> /// #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10 +///+/// 16550-compatible with parameters defined in Generic Address Structure+///+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550_WITH_GAS 0x12+ // // Interrupt Type //--
> 2.29.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#75464):
> https://edk2.groups.io/g/devel/message/75464
> Mute This Topic: https://groups.io/mt/83024903/5985097
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com]
> -=-=-=-=-=-=
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-24 3:20 ` Sunny Wang
@ 2021-05-24 8:42 ` gaoliming
2021-05-24 8:50 ` Marcin Wojtas
0 siblings, 1 reply; 10+ messages in thread
From: gaoliming @ 2021-05-24 8:42 UTC (permalink / raw)
To: devel, Sunny.Wang, 'Marcin Wojtas'
Cc: michael.d.kinney, leif, ardb+tianocore,
'Samer El-Haj-Mahmoud', gjb, upstream
You can run BaseTools\Scripts\PatchCheck.py -1 to check the patch format.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunny Wang
> 发送时间: 2021年5月24日 11:21
> 收件人: Marcin Wojtas <mw@semihalf.com>
> 抄送: devel@edk2.groups.io; michael.d.kinney@intel.com;
> leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com;
> upstream@semihalf.com; gaoliming@byosoft.com.cn; Sunny Wang
> <Sunny.Wang@arm.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> Add Liming's new email.
>
> Hi Marcin,
>
> There seems no LF (0A).
> 1. From the patch I got below in this email, several lines got merged into one
> line.
> > #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> 0x0010+#define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394
> 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB
>
> 2. In
> https://edk2.groups.io/g/devel/topic/patch_1_1_mdepkg_add_new/830249
> 03?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83024903, I saw "=0D"
> appending to each line. I'm not sure if this is relevant.
>
> Moreover, I don't see #1 and #2 in another similar code change
> https://edk2.groups.io/g/devel/message/75283?p=,,,20,0,0,0::relevance,,Md
> ePkg%3A+Update+DBG2+and+SPCR+header+with+NVIDIA+16550+Subtype,2
> 0,2,0,82919032.
>
> Of course, if this won't cause any issue with pushing the patch, I'm totally fine
> with this.
>
> Reviewed-by: Sunny Wang <sunny.wang@arm.com>
>
>
> Best Regards,
> Sunny Wang
>
> -----Original Message-----
> From: Marcin Wojtas <mw@semihalf.com>
> Sent: Monday, May 24, 2021 10:21 AM
> To: Sunny Wang <Sunny.Wang@arm.com>
> Cc: devel@edk2.groups.io; michael.d.kinney@intel.com; leif@nuviainc.com;
> ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com;
> upstream@semihalf.com
> Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> Hi Sunny,
>
>
> pon., 24 maj 2021 o 04:09 Sunny Wang <Sunny.Wang@arm.com> napisał(a):
> >
> > Looks good, Marcin.
> > However, it looks like something wrong with the line-ending. Could you
> check if your line-ending setting is CR/LF? Did you use
> /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could
> you use it? I expect this tool can catch the line-ending problem.
>
> The line endings are fine in my repo, I generated and sent the patch as usual.
>
> And of course prior to sending I ran PatchCheck.py - it complains only about
> too long URL line in the commit message, but the line-endings are ok.
>
> $ python3
> /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py -1
> Checking git commit: HEAD
> MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 WARNING
> - Line 9 of commit message is too long (91 >= 76).
> [1]
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-d
> ebug-port-table
> The commit message format passed all checks.
> The code passed all checks.
>
> Do you check the line endings in a different way?
>
> Best regards,
> Marcin
>
> >
> > Best Regards,
> > Sunny Wang
> >
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin
> > Wojtas via groups.io
> > Sent: Sunday, May 23, 2021 5:15 PM
> > To: devel@edk2.groups.io
> > Cc: liming.gao@intel.com; michael.d.kinney@intel.com;
> > leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang
> <Sunny.Wang@arm.com>;
> > gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> > <mw@semihalf.com>
> > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > Serial Port Subtypes to DBG2
> >
> > The Microsoft Debug Port Table 2 (DBG2) specification revision May 31,
> > 2017 adds support for 16550-compatible Serial Port Subtype with
> > parameters defined in Generic Address Structure (GAS) [1]
> >
> > Reflect that in the EDK2 headers.
> >
> > [1]
> > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi
> > -debug-port-table
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> > MdePkg/Include/IndustryStandard/DebugPort2Table.h
> | 1 +
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h |
> > 5 +++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > index 3faa30b76a..9ccfc1b1ee 100644
> > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > @@ -47,6 +47,7 @@ typedef struct {
> > #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> 0x0010+#define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394
> 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB
> 0x8002diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index 2066c7895e..7796796afe 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > +++ h
> > @@ -100,6 +100,11 @@ typedef struct {
> > /// #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> BCM2835_UART 0x10 +///+/// 16550-compatible with
> parameters defined in Generic Address Structure+///+#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> 16550_WITH_GAS 0x12+ // // Interrupt Type //--
> > 2.29.0
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#75464):
> > https://edk2.groups.io/g/devel/message/75464
> > Mute This Topic: https://groups.io/mt/83024903/5985097
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [Sunny.Wang@arm.com]
> > -=-=-=-=-=-=
> >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-24 8:42 ` 回复: " gaoliming
@ 2021-05-24 8:50 ` Marcin Wojtas
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
0 siblings, 1 reply; 10+ messages in thread
From: Marcin Wojtas @ 2021-05-24 8:50 UTC (permalink / raw)
To: edk2-devel-groups-io, gaoliming
Cc: Sunny Wang, Kinney, Michael D, Leif Lindholm, Ard Biesheuvel,
Samer El-Haj-Mahmoud, Grzegorz Bernacki, upstream
Hi Liming,
pon., 24 maj 2021 o 10:42 gaoliming <gaoliming@byosoft.com.cn> napisał(a):
>
> You can run BaseTools\Scripts\PatchCheck.py -1 to check the patch format.
>
Sure, I ran it prior to submission.
Best regards,
Marcin
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunny Wang
> > 发送时间: 2021年5月24日 11:21
> > 收件人: Marcin Wojtas <mw@semihalf.com>
> > 抄送: devel@edk2.groups.io; michael.d.kinney@intel.com;
> > leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com;
> > upstream@semihalf.com; gaoliming@byosoft.com.cn; Sunny Wang
> > <Sunny.Wang@arm.com>
> > 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > Serial Port Subtypes to DBG2
> >
> > Add Liming's new email.
> >
> > Hi Marcin,
> >
> > There seems no LF (0A).
> > 1. From the patch I got below in this email, several lines got merged into one
> > line.
> > > #define
> > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> > 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> > 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> > 0x0010+#define
> > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> > 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394
> > 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> > 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB
> >
> > 2. In
> > https://edk2.groups.io/g/devel/topic/patch_1_1_mdepkg_add_new/830249
> > 03?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83024903, I saw "=0D"
> > appending to each line. I'm not sure if this is relevant.
> >
> > Moreover, I don't see #1 and #2 in another similar code change
> > https://edk2.groups.io/g/devel/message/75283?p=,,,20,0,0,0::relevance,,Md
> > ePkg%3A+Update+DBG2+and+SPCR+header+with+NVIDIA+16550+Subtype,2
> > 0,2,0,82919032.
> >
> > Of course, if this won't cause any issue with pushing the patch, I'm totally fine
> > with this.
> >
> > Reviewed-by: Sunny Wang <sunny.wang@arm.com>
> >
> >
> > Best Regards,
> > Sunny Wang
> >
> > -----Original Message-----
> > From: Marcin Wojtas <mw@semihalf.com>
> > Sent: Monday, May 24, 2021 10:21 AM
> > To: Sunny Wang <Sunny.Wang@arm.com>
> > Cc: devel@edk2.groups.io; michael.d.kinney@intel.com; leif@nuviainc.com;
> > ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com;
> > upstream@semihalf.com
> > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > Serial Port Subtypes to DBG2
> >
> > Hi Sunny,
> >
> >
> > pon., 24 maj 2021 o 04:09 Sunny Wang <Sunny.Wang@arm.com> napisał(a):
> > >
> > > Looks good, Marcin.
> > > However, it looks like something wrong with the line-ending. Could you
> > check if your line-ending setting is CR/LF? Did you use
> > /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could
> > you use it? I expect this tool can catch the line-ending problem.
> >
> > The line endings are fine in my repo, I generated and sent the patch as usual.
> >
> > And of course prior to sending I ran PatchCheck.py - it complains only about
> > too long URL line in the commit message, but the line-endings are ok.
> >
> > $ python3
> > /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py -1
> > Checking git commit: HEAD
> > MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 WARNING
> > - Line 9 of commit message is too long (91 >= 76).
> > [1]
> > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-d
> > ebug-port-table
> > The commit message format passed all checks.
> > The code passed all checks.
> >
> > Do you check the line endings in a different way?
> >
> > Best regards,
> > Marcin
> >
> > >
> > > Best Regards,
> > > Sunny Wang
> > >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin
> > > Wojtas via groups.io
> > > Sent: Sunday, May 23, 2021 5:15 PM
> > > To: devel@edk2.groups.io
> > > Cc: liming.gao@intel.com; michael.d.kinney@intel.com;
> > > leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> > > <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang
> > <Sunny.Wang@arm.com>;
> > > gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> > > <mw@semihalf.com>
> > > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > > Serial Port Subtypes to DBG2
> > >
> > > The Microsoft Debug Port Table 2 (DBG2) specification revision May 31,
> > > 2017 adds support for 16550-compatible Serial Port Subtype with
> > > parameters defined in Generic Address Structure (GAS) [1]
> > >
> > > Reflect that in the EDK2 headers.
> > >
> > > [1]
> > > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi
> > > -debug-port-table
> > >
> > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > ---
> > > MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > | 1 +
> > > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h |
> > > 5 +++++
> > > 2 files changed, 6 insertions(+)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > index 3faa30b76a..9ccfc1b1ee 100644
> > > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > @@ -47,6 +47,7 @@ typedef struct {
> > > #define
> > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> > 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> > 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> > 0x0010+#define
> > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> > 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394
> > 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> > 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB
> > 0x8002diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > index 2066c7895e..7796796afe 100644
> > > ---
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > +++ h
> > > @@ -100,6 +100,11 @@ typedef struct {
> > > /// #define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > BCM2835_UART 0x10 +///+/// 16550-compatible with
> > parameters defined in Generic Address Structure+///+#define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > 16550_WITH_GAS 0x12+ // // Interrupt Type //--
> > > 2.29.0
> > >
> > >
> > >
> > > -=-=-=-=-=-=
> > > Groups.io Links: You receive all messages sent to this group.
> > > View/Reply Online (#75464):
> > > https://edk2.groups.io/g/devel/message/75464
> > > Mute This Topic: https://groups.io/mt/83024903/5985097
> > > Group Owner: devel+owner@edk2.groups.io
> > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [Sunny.Wang@arm.com]
> > > -=-=-=-=-=-=
> > >
> > >
> > > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended recipient,
> > please notify the sender immediately and do not disclose the contents to any
> > other person, use it for any purpose, or store or copy the information in any
> > medium. Thank you.
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended recipient,
> > please notify the sender immediately and do not disclose the contents to any
> > other person, use it for any purpose, or store or copy the information in any
> > medium. Thank you.
> >
> >
> >
> >
>
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-24 8:50 ` Marcin Wojtas
@ 2021-05-24 10:57 ` Samer El-Haj-Mahmoud
0 siblings, 0 replies; 10+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-05-24 10:57 UTC (permalink / raw)
To: Marcin Wojtas, edk2-devel-groups-io, gaoliming@byosoft.com.cn
Cc: Sunny Wang, Kinney, Michael D, Leif Lindholm, Ard Biesheuvel,
Grzegorz Bernacki, upstream@semihalf.com, Samer El-Haj-Mahmoud
Sunny,
I think the issue is outlook removing the extra line breaks. To disable this do the following (per https://docs.microsoft.com/en-us/outlook/troubleshoot/message-body/line-breaks-are-removed-in-posts-made-in-plain-text)
Open Outlook.
On the File tab, select Options.
In the Options dialog, select Mail.
In the Message format section, clear the Remove extra line breaks in plain text messages check box.
Select OK.
> -----Original Message-----
> From: Marcin Wojtas <mw@semihalf.com>
> Sent: Monday, May 24, 2021 4:51 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>;
> gaoliming@byosoft.com.cn
> Cc: Sunny Wang <Sunny.Wang@arm.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; Grzegorz Bernacki
> <gjb@semihalf.com>; upstream@semihalf.com
> Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> Hi Liming,
>
> pon., 24 maj 2021 o 10:42 gaoliming <gaoliming@byosoft.com.cn> napisał(a):
> >
> > You can run BaseTools\Scripts\PatchCheck.py -1 to check the patch format.
> >
>
> Sure, I ran it prior to submission.
>
> Best regards,
> Marcin
>
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunny
> Wang
> > > 发送时间: 2021年5月24日 11:21
> > > 收件人: Marcin Wojtas <mw@semihalf.com>
> > > 抄送: devel@edk2.groups.io; michael.d.kinney@intel.com;
> > > leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> > > <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com;
> > > upstream@semihalf.com; gaoliming@byosoft.com.cn; Sunny Wang
> > > <Sunny.Wang@arm.com>
> > > 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > > Serial Port Subtypes to DBG2
> > >
> > > Add Liming's new email.
> > >
> > > Hi Marcin,
> > >
> > > There seems no LF (0A).
> > > 1. From the patch I got below in this email, several lines got merged into
> one
> > > line.
> > > > #define
> > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> > > 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> > > 0x000f #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> > > 0x0010+#define
> > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> > > 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394
> > > 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> > > 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB
> > >
> > > 2. In
> > >
> https://edk2.groups.io/g/devel/topic/patch_1_1_mdepkg_add_new/830249
> > > 03?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83024903, I saw "=0D"
> > > appending to each line. I'm not sure if this is relevant.
> > >
> > > Moreover, I don't see #1 and #2 in another similar code change
> > >
> https://edk2.groups.io/g/devel/message/75283?p=,,,20,0,0,0::relevance,,M
> d
> > >
> ePkg%3A+Update+DBG2+and+SPCR+header+with+NVIDIA+16550+Subtype,
> 2
> > > 0,2,0,82919032.
> > >
> > > Of course, if this won't cause any issue with pushing the patch, I'm totally
> fine
> > > with this.
> > >
> > > Reviewed-by: Sunny Wang <sunny.wang@arm.com>
> > >
> > >
> > > Best Regards,
> > > Sunny Wang
> > >
> > > -----Original Message-----
> > > From: Marcin Wojtas <mw@semihalf.com>
> > > Sent: Monday, May 24, 2021 10:21 AM
> > > To: Sunny Wang <Sunny.Wang@arm.com>
> > > Cc: devel@edk2.groups.io; michael.d.kinney@intel.com;
> leif@nuviainc.com;
> > > ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> > > <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com;
> > > upstream@semihalf.com
> > > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-
> compatible
> > > Serial Port Subtypes to DBG2
> > >
> > > Hi Sunny,
> > >
> > >
> > > pon., 24 maj 2021 o 04:09 Sunny Wang <Sunny.Wang@arm.com>
> napisał(a):
> > > >
> > > > Looks good, Marcin.
> > > > However, it looks like something wrong with the line-ending. Could you
> > > check if your line-ending setting is CR/LF? Did you use
> > > /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not,
> could
> > > you use it? I expect this tool can catch the line-ending problem.
> > >
> > > The line endings are fine in my repo, I generated and sent the patch as
> usual.
> > >
> > > And of course prior to sending I ran PatchCheck.py - it complains only
> about
> > > too long URL line in the commit message, but the line-endings are ok.
> > >
> > > $ python3
> > > /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py
> -1
> > > Checking git commit: HEAD
> > > MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
> WARNING
> > > - Line 9 of commit message is too long (91 >= 76).
> > > [1]
> > > https://docs.microsoft.com/en-us/windows-
> hardware/drivers/bringup/acpi-d
> > > ebug-port-table
> > > The commit message format passed all checks.
> > > The code passed all checks.
> > >
> > > Do you check the line endings in a different way?
> > >
> > > Best regards,
> > > Marcin
> > >
> > > >
> > > > Best Regards,
> > > > Sunny Wang
> > > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Marcin
> > > > Wojtas via groups.io
> > > > Sent: Sunday, May 23, 2021 5:15 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: liming.gao@intel.com; michael.d.kinney@intel.com;
> > > > leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-
> Mahmoud
> > > > <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang
> > > <Sunny.Wang@arm.com>;
> > > > gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> > > > <mw@semihalf.com>
> > > > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > > > Serial Port Subtypes to DBG2
> > > >
> > > > The Microsoft Debug Port Table 2 (DBG2) specification revision May 31,
> > > > 2017 adds support for 16550-compatible Serial Port Subtype with
> > > > parameters defined in Generic Address Structure (GAS) [1]
> > > >
> > > > Reflect that in the EDK2 headers.
> > > >
> > > > [1]
> > > > https://docs.microsoft.com/en-us/windows-
> hardware/drivers/bringup/acpi
> > > > -debug-port-table
> > > >
> > > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > > ---
> > > > MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > | 1 +
> > > >
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h |
> > > > 5 +++++
> > > > 2 files changed, 6 insertions(+)
> > > >
> > > > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > > b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > > index 3faa30b76a..9ccfc1b1ee 100644
> > > > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > > @@ -47,6 +47,7 @@ typedef struct {
> > > > #define
> > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> > > 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> > > 0x000f #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> > > 0x0010+#define
> > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> > > 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394
> > > 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> > > 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB
> > > 0x8002diff --git
> > >
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > >
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > > index 2066c7895e..7796796afe 100644
> > > > ---
> > > >
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > > +++
> > >
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > > +++ h
> > > > @@ -100,6 +100,11 @@ typedef struct {
> > > > /// #define
> > >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > > BCM2835_UART 0x10 +///+/// 16550-compatible with
> > > parameters defined in Generic Address Structure+///+#define
> > >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > > 16550_WITH_GAS 0x12+ // // Interrupt Type //--
> > > > 2.29.0
> > > >
> > > >
> > > >
> > > > -=-=-=-=-=-=
> > > > Groups.io Links: You receive all messages sent to this group.
> > > > View/Reply Online (#75464):
> > > > https://edk2.groups.io/g/devel/message/75464
> > > > Mute This Topic: https://groups.io/mt/83024903/5985097
> > > > Group Owner: devel+owner@edk2.groups.io
> > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > > [Sunny.Wang@arm.com]
> > > > -=-=-=-=-=-=
> > > >
> > > >
> > > > IMPORTANT NOTICE: The contents of this email and any attachments
> are
> > > confidential and may also be privileged. If you are not the intended
> recipient,
> > > please notify the sender immediately and do not disclose the contents to
> any
> > > other person, use it for any purpose, or store or copy the information in
> any
> > > medium. Thank you.
> > > IMPORTANT NOTICE: The contents of this email and any attachments are
> > > confidential and may also be privileged. If you are not the intended
> recipient,
> > > please notify the sender immediately and do not disclose the contents to
> any
> > > other person, use it for any purpose, or store or copy the information in
> any
> > > medium. Thank you.
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-23 9:15 [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 Marcin Wojtas
2021-05-24 2:09 ` [edk2-devel] " Sunny Wang
@ 2021-05-24 10:57 ` Samer El-Haj-Mahmoud
2021-06-01 1:27 ` 回复: " gaoliming
[not found] ` <168451009D6DDB30.28811@groups.io>
1 sibling, 2 replies; 10+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-05-24 10:57 UTC (permalink / raw)
To: devel@edk2.groups.io, mw@semihalf.com
Cc: liming.gao@intel.com, michael.d.kinney@intel.com,
leif@nuviainc.com, ardb+tianocore@kernel.org, Sunny Wang,
gjb@semihalf.com, upstream@semihalf.com, Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin
> Wojtas via groups.io
> Sent: Sunday, May 23, 2021 5:15 AM
> To: devel@edk2.groups.io
> Cc: liming.gao@intel.com; michael.d.kinney@intel.com; leif@nuviainc.com;
> ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>;
> gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> <mw@semihalf.com>
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> The Microsoft Debug Port Table 2 (DBG2) specification revision
> May 31, 2017 adds support for 16550-compatible Serial Port
> Subtype with parameters defined in Generic Address Structure (GAS) [1]
>
> Reflect that in the EDK2 headers.
>
> [1] https://docs.microsoft.com/en-us/windows-
> hardware/drivers/bringup/acpi-debug-port-table
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 5
> +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..9ccfc1b1ee 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -47,6 +47,7 @@ typedef struct {
> #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
>
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
>
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> 0x0010
>
> +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> 0x0012
>
> #define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001
>
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> 0x0000
>
> #define EFI_ACPI_DBG2_PORT_TYPE_USB 0x8002
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..7796796afe 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -100,6 +100,11 @@ typedef struct {
> ///
>
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> BCM2835_UART 0x10
>
>
>
> +///
>
> +/// 16550-compatible with parameters defined in Generic Address Structure
>
> +///
>
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> 16550_WITH_GAS 0x12
>
> +
>
> //
>
> // Interrupt Type
>
> //
>
> --
> 2.29.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#75464): https://edk2.groups.io/g/devel/message/75464
> Mute This Topic: https://groups.io/mt/83024903/1945644
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> mahmoud@arm.com]
> -=-=-=-=-=-=
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
@ 2021-06-01 1:27 ` gaoliming
[not found] ` <168451009D6DDB30.28811@groups.io>
1 sibling, 0 replies; 10+ messages in thread
From: gaoliming @ 2021-06-01 1:27 UTC (permalink / raw)
To: devel, samer.el-haj-mahmoud, mw
Cc: liming.gao, michael.d.kinney, leif, ardb+tianocore,
'Sunny Wang', gjb, upstream
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Samer
> El-Haj-Mahmoud
> 发送时间: 2021年5月24日 18:58
> 收件人: devel@edk2.groups.io; mw@semihalf.com
> 抄送: liming.gao@intel.com; michael.d.kinney@intel.com; leif@nuviainc.com;
> ardb+tianocore@kernel.org; Sunny Wang <Sunny.Wang@arm.com>;
> gjb@semihalf.com; upstream@semihalf.com; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin
> > Wojtas via groups.io
> > Sent: Sunday, May 23, 2021 5:15 AM
> > To: devel@edk2.groups.io
> > Cc: liming.gao@intel.com; michael.d.kinney@intel.com; leif@nuviainc.com;
> > ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>;
> > gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> > <mw@semihalf.com>
> > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > Serial Port Subtypes to DBG2
> >
> > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > May 31, 2017 adds support for 16550-compatible Serial Port
> > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> >
> > Reflect that in the EDK2 headers.
> >
> > [1] https://docs.microsoft.com/en-us/windows-
> > hardware/drivers/bringup/acpi-debug-port-table
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> > MdePkg/Include/IndustryStandard/DebugPort2Table.h
> | 1 +
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h |
> 5
> > +++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > index 3faa30b76a..9ccfc1b1ee 100644
> > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > @@ -47,6 +47,7 @@ typedef struct {
> > #define
> > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> > 0x000e
> >
> > #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> > 0x000f
> >
> > #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> > 0x0010
> >
> > +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> > 0x0012
> >
> > #define EFI_ACPI_DBG2_PORT_TYPE_1394
> 0x8001
> >
> > #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> > 0x0000
> >
> > #define EFI_ACPI_DBG2_PORT_TYPE_USB
> 0x8002
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index 2066c7895e..7796796afe 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > @@ -100,6 +100,11 @@ typedef struct {
> > ///
> >
> > #define
> >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > BCM2835_UART 0x10
> >
> >
> >
> > +///
> >
> > +/// 16550-compatible with parameters defined in Generic Address
> Structure
> >
> > +///
> >
> > +#define
> >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > 16550_WITH_GAS 0x12
> >
> > +
> >
> > //
> >
> > // Interrupt Type
> >
> > //
> >
> > --
> > 2.29.0
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#75464):
> https://edk2.groups.io/g/devel/message/75464
> > Mute This Topic: https://groups.io/mt/83024903/1945644
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> > mahmoud@arm.com]
> > -=-=-=-=-=-=
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
recipient,
> please notify the sender immediately and do not disclose the contents to
any
> other person, use it for any purpose, or store or copy the information in
any
> medium. Thank you.
>
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2
[not found] ` <168451009D6DDB30.28811@groups.io>
@ 2021-06-02 5:55 ` gaoliming
0 siblings, 0 replies; 10+ messages in thread
From: gaoliming @ 2021-06-02 5:55 UTC (permalink / raw)
To: devel, gaoliming, samer.el-haj-mahmoud, mw
Cc: liming.gao, michael.d.kinney, leif, ardb+tianocore,
'Sunny Wang', gjb, upstream
Merge at 197e27c90aeb603eed98a2554746dd966f04fc28
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年6月1日 9:27
> 收件人: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com;
> mw@semihalf.com
> 抄送: liming.gao@intel.com; michael.d.kinney@intel.com; leif@nuviainc.com;
> ardb+tianocore@kernel.org; 'Sunny Wang' <Sunny.Wang@arm.com>;
> gjb@semihalf.com; upstream@semihalf.com
> 主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Samer
> > El-Haj-Mahmoud
> > 发送时间: 2021年5月24日 18:58
> > 收件人: devel@edk2.groups.io; mw@semihalf.com
> > 抄送: liming.gao@intel.com; michael.d.kinney@intel.com;
> leif@nuviainc.com;
> > ardb+tianocore@kernel.org; Sunny Wang <Sunny.Wang@arm.com>;
> > gjb@semihalf.com; upstream@semihalf.com; Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud@arm.com>
> > 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > Serial Port Subtypes to DBG2
> >
> > Reviewed-by: Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Marcin
> > > Wojtas via groups.io
> > > Sent: Sunday, May 23, 2021 5:15 AM
> > > To: devel@edk2.groups.io
> > > Cc: liming.gao@intel.com; michael.d.kinney@intel.com;
> leif@nuviainc.com;
> > > ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > > Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>;
> > > gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> > > <mw@semihalf.com>
> > > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> > > Serial Port Subtypes to DBG2
> > >
> > > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > > May 31, 2017 adds support for 16550-compatible Serial Port
> > > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> > >
> > > Reflect that in the EDK2 headers.
> > >
> > > [1] https://docs.microsoft.com/en-us/windows-
> > > hardware/drivers/bringup/acpi-debug-port-table
> > >
> > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > ---
> > > MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > | 1 +
> > > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> |
> > 5
> > > +++++
> > > 2 files changed, 6 insertions(+)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > index 3faa30b76a..9ccfc1b1ee 100644
> > > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> > > @@ -47,6 +47,7 @@ typedef struct {
> > > #define
> > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> > > 0x000e
> > >
> > > #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> > > 0x000f
> > >
> > > #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART
> > > 0x0010
> > >
> > > +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS
> > > 0x0012
> > >
> > > #define EFI_ACPI_DBG2_PORT_TYPE_1394
> > 0x8001
> > >
> > > #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD
> > > 0x0000
> > >
> > > #define EFI_ACPI_DBG2_PORT_TYPE_USB
> > 0x8002
> > >
> > > diff --git
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > index 2066c7895e..7796796afe 100644
> > > ---
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > +++
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > @@ -100,6 +100,11 @@ typedef struct {
> > > ///
> > >
> > > #define
> > >
> >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > > BCM2835_UART 0x10
> > >
> > >
> > >
> > > +///
> > >
> > > +/// 16550-compatible with parameters defined in Generic Address
> > Structure
> > >
> > > +///
> > >
> > > +#define
> > >
> >
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_
> > > 16550_WITH_GAS 0x12
> > >
> > > +
> > >
> > > //
> > >
> > > // Interrupt Type
> > >
> > > //
> > >
> > > --
> > > 2.29.0
> > >
> > >
> > >
> > > -=-=-=-=-=-=
> > > Groups.io Links: You receive all messages sent to this group.
> > > View/Reply Online (#75464):
> > https://edk2.groups.io/g/devel/message/75464
> > > Mute This Topic: https://groups.io/mt/83024903/1945644
> > > Group Owner: devel+owner@edk2.groups.io
> > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> > > mahmoud@arm.com]
> > > -=-=-=-=-=-=
> > >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended
> recipient,
> > please notify the sender immediately and do not disclose the contents to
> any
> > other person, use it for any purpose, or store or copy the information
in
> any
> > medium. Thank you.
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-06-02 5:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-23 9:15 [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 Marcin Wojtas
2021-05-24 2:09 ` [edk2-devel] " Sunny Wang
2021-05-24 2:21 ` Marcin Wojtas
2021-05-24 3:20 ` Sunny Wang
2021-05-24 8:42 ` 回复: " gaoliming
2021-05-24 8:50 ` Marcin Wojtas
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
2021-05-24 10:57 ` Samer El-Haj-Mahmoud
2021-06-01 1:27 ` 回复: " gaoliming
[not found] ` <168451009D6DDB30.28811@groups.io>
2021-06-02 5:55 ` gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox