From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by mx.groups.io with SMTP id smtpd.web10.20560.1621846255799229407 for ; Mon, 24 May 2021 01:50:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=gjz6lgVj; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.179, mailfrom: mw@semihalf.com) Received: by mail-qt1-f179.google.com with SMTP id 1so20142415qtb.0 for ; Mon, 24 May 2021 01:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=osFFUjZZKjiVo/NnmJ+1GOSRoaJkce32a/5SzXJvqZ4=; b=gjz6lgVj0n5FnlMgXLBpd+s9dLKqMOonP2xl7eIty8fwlobMIiZ+hEnUp6BEKmunlW D944VrPi+3mQjX363AhTid49MHSUoz1XSkOzDJ6vPuPm9PypxQSUCmA2wXwtyktuqqjE DprnBlO7dH+L4fRgLW5zlldMeha1s/72/gGsv+ZHiEsQH1/9p0fN59hH7PbNu6usMYVV NmG98+6BG2cUju85cGX4JVF06xRyitI2vwyqMPnXE/dYx7N9V9hcdtkzu/OkPs9cpfXp LwJWmHiYzlFjA0MpmDUr9NEx8r+Uyzo6fnT0QRfo13OisZ2hUj3EjkeeeM4Nh+r7W+Sx J+3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=osFFUjZZKjiVo/NnmJ+1GOSRoaJkce32a/5SzXJvqZ4=; b=iTo9o4Fb4Q+5NcYc3yZE3/VprOARF/WqzOLbDIaheiZHSQ4ms5+fsSGXNShlg0aue5 ci4uERY1fzXKHqINnr8UNlLKeY5rjCbV7MyzhU+Kts71PjAQru3czopJdc10jzvhOZ8t KdDqU+bxipaTtH59dyqUFBuVdwO3KVbu+rfK2Wc6XEx/mOiLRrs3NIk62gltdQ4udN/y 65Sk6XNRt40whmCjEyPzKC84B0ITSN9M02b2R1ywKyBme7utxjwB9IAqICXunRWYGBSe lJTTS4UusAEbUfwKg9NeMswn9rAyOXEoeLVGeZLL9IIayOBC/9SCdvH8GrfEKxU6MXh4 8NTA== X-Gm-Message-State: AOAM533S3XVoW8bvvJpQuMC9Rfby2Dta5+q6WW0tjvFREyIoVNxIJExI SJ5tRnBk1HYxqQ9swvAqo0rzyn+5VViMfNGEG/8DQzsu2whV2Q== X-Google-Smtp-Source: ABdhPJxuFqnxZtkJ8xqZ1VAZA/quycTH/2G+Ey5g2EAHT/3GsC8h0FC4JwdtHHfYIYeQl8DpTCnqzknWn8RlirWMjXM= X-Received: by 2002:ac8:4812:: with SMTP id g18mr25847272qtq.16.1621846254865; Mon, 24 May 2021 01:50:54 -0700 (PDT) MIME-Version: 1.0 References: <20210523091512.2348586-1-mw@semihalf.com> <000701d75078$c2e69d30$48b3d790$@byosoft.com.cn> In-Reply-To: <000701d75078$c2e69d30$48b3d790$@byosoft.com.cn> From: "Marcin Wojtas" Date: Mon, 24 May 2021 10:50:43 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 To: edk2-devel-groups-io , gaoliming@byosoft.com.cn Cc: Sunny Wang , "Kinney, Michael D" , Leif Lindholm , Ard Biesheuvel , Samer El-Haj-Mahmoud , Grzegorz Bernacki , upstream@semihalf.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Liming, pon., 24 maj 2021 o 10:42 gaoliming napisa=C5= =82(a): > > You can run BaseTools\Scripts\PatchCheck.py -1 to check the patch format= . > Sure, I ran it prior to submission. Best regards, Marcin > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Sunny Wang > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B45=E6=9C=8824=E6=97= =A5 11:21 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Marcin Wojtas > > =E6=8A=84=E9=80=81: devel@edk2.groups.io; michael.d.kinney@intel.com; > > leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > > ; gjb@semihalf.com; > > upstream@semihalf.com; gaoliming@byosoft.com.cn; Sunny Wang > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550= -compatible > > Serial Port Subtypes to DBG2 > > > > Add Liming's new email. > > > > Hi Marcin, > > > > There seems no LF (0A). > > 1. From the patch I got below in this email, several lines got merged = into one > > line. > > > #define > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART > > 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC > > 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART > > 0x0010+#define > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS > > 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394 > > 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD > > 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB > > > > 2. In > > https://edk2.groups.io/g/devel/topic/patch_1_1_mdepkg_add_new/830249 > > 03?p=3D,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83024903, I saw "= = =3D0D" > > appending to each line. I'm not sure if this is relevant. > > > > Moreover, I don't see #1 and #2 in another similar code change > > https://edk2.groups.io/g/devel/message/75283?p=3D,,,20,0,0,0::relevanc= e,,Md > > ePkg%3A+Update+DBG2+and+SPCR+header+with+NVIDIA+16550+Subtype,2 > > 0,2,0,82919032. > > > > Of course, if this won't cause any issue with pushing the patch, I'm t= otally fine > > with this. > > > > Reviewed-by: Sunny Wang > > > > > > Best Regards, > > Sunny Wang > > > > -----Original Message----- > > From: Marcin Wojtas > > Sent: Monday, May 24, 2021 10:21 AM > > To: Sunny Wang > > Cc: devel@edk2.groups.io; michael.d.kinney@intel.com; leif@nuviainc.co= m; > > ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > > ; gjb@semihalf.com; > > upstream@semihalf.com > > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible > > Serial Port Subtypes to DBG2 > > > > Hi Sunny, > > > > > > pon., 24 maj 2021 o 04:09 Sunny Wang napisa=C5=82= (a): > > > > > > Looks good, Marcin. > > > However, it looks like something wrong with the line-ending. Could y= ou > > check if your line-ending setting is CR/LF? Did you use > > /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not= , could > > you use it? I expect this tool can catch the line-ending problem. > > > > The line endings are fine in my repo, I generated and sent the patch a= s usual. > > > > And of course prior to sending I ran PatchCheck.py - it complains only= about > > too long URL line in the commit message, but the line-endings are ok. > > > > $ python3 > > /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py -1 > > Checking git commit: HEAD > > MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 WARNING > > - Line 9 of commit message is too long (91 >=3D 76). > > [1] > > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi= -d > > ebug-port-table > > The commit message format passed all checks. > > The code passed all checks. > > > > Do you check the line endings in a different way? > > > > Best regards, > > Marcin > > > > > > > > Best Regards, > > > Sunny Wang > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Marci= n > > > Wojtas via groups.io > > > Sent: Sunday, May 23, 2021 5:15 PM > > > To: devel@edk2.groups.io > > > Cc: liming.gao@intel.com; michael.d.kinney@intel.com; > > > leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > > > ; Sunny Wang > > ; > > > gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas > > > > > > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible > > > Serial Port Subtypes to DBG2 > > > > > > The Microsoft Debug Port Table 2 (DBG2) specification revision May 3= 1, > > > 2017 adds support for 16550-compatible Serial Port Subtype with > > > parameters defined in Generic Address Structure (GAS) [1] > > > > > > Reflect that in the EDK2 headers. > > > > > > [1] > > > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/ac= pi > > > -debug-port-table > > > > > > Signed-off-by: Marcin Wojtas > > > --- > > > MdePkg/Include/IndustryStandard/DebugPort2Table.h > > | 1 + > > > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h= | > > > 5 +++++ > > > 2 files changed, 6 insertions(+) > > > > > > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h > > > b/MdePkg/Include/IndustryStandard/DebugPort2Table.h > > > index 3faa30b76a..9ccfc1b1ee 100644 > > > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h > > > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h > > > @@ -47,6 +47,7 @@ typedef struct { > > > #define > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART > > 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC > > 0x000f #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART > > 0x0010+#define > > EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS > > 0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394 > > 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD > > 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB > > 0x8002diff --git > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > > > index 2066c7895e..7796796afe 100644 > > > --- > > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.= h > > > +++ > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable. > > > +++ h > > > @@ -100,6 +100,11 @@ typedef struct { > > > /// #define > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > > BCM2835_UART 0x10 +///+/// 16550-compatible with > > parameters defined in Generic Address Structure+///+#define > > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ > > 16550_WITH_GAS 0x12+ // // Interrupt Type //-- > > > 2.29.0 > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > Groups.io Links: You receive all messages sent to this group. > > > View/Reply Online (#75464): > > > https://edk2.groups.io/g/devel/message/75464 > > > Mute This Topic: https://groups.io/mt/83024903/5985097 > > > Group Owner: devel+owner@edk2.groups.io > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [Sunny.Wang@arm.com] > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended r= ecipient, > > please notify the sender immediately and do not disclose the contents = to any > > other person, use it for any purpose, or store or copy the information= in any > > medium. Thank you. > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended r= ecipient, > > please notify the sender immediately and do not disclose the contents = to any > > other person, use it for any purpose, or store or copy the information= in any > > medium. Thank you. > > > > > > > > > > > > > >=20 > >