From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51])
 by mx.groups.io with SMTP id smtpd.web11.4924.1617112680014142734
 for <devel@edk2.groups.io>;
 Tue, 30 Mar 2021 06:58:00 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=BXL4BJ6W;
 spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.219.51, mailfrom: mw@semihalf.com)
Received: by mail-qv1-f51.google.com with SMTP id q9so8147744qvm.6
        for <devel@edk2.groups.io>; Tue, 30 Mar 2021 06:57:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=semihalf-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=W5RGTppsLGsSs6PZadUuF2eCJYa5bmBb/u4S0s6fDIo=;
        b=BXL4BJ6W5JtJi5DQDudDybCHo3PIZ34eAm8Eq+QKc/w8ILtWDurzuJePNovBUkT2CG
         5eW7+0fxWwjtDGNjWjXAe6qt8aQEQI6zLYEzTonCDxEz8THMYPzdR9zMwS5a4QJ65q/c
         Jdtq7IhqqBBH9JHNlvEhjaiShZJPzE5OFlr95AnRufVwzbppLKFsWmxtHPQ2m5Vo0m6/
         v+ED1XTBJd5SGcA0Gbul4fLy0H1CyoctZkb2x2XK1T7FpdM2wnDWsPCBY9MpqYX8v7MX
         G5sYr/s1Gtk5OGl7YOTXmvnpdBKyvLDB60lOjd1MY1f/Z1I8r1YMPeBu9PWwKOJuYbo3
         vcDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=W5RGTppsLGsSs6PZadUuF2eCJYa5bmBb/u4S0s6fDIo=;
        b=fs4zr4tbry6h/heOLhoc7bBA27n5YKhGx4dwOC4bEX0XldwlhkRm0tv0tfmKeRLhkV
         Do4gP17g6vsEABqR+mKgHSNtEGn3OWjk+Mp20RByidvWpBFEj/QeZXtjhT01N1y/gEEO
         jXmtzUDu9QTpn3ML6ymkW0t74uLaO4KnqhZwJGlMwJwkw6htRNtnibjvAyeWfQIyUe+n
         aI90aEx7zDheQmZYq4d0UACCvhL8+KQ2tBt1V8xMtIjCZntTw7arUfJ8h48YlyKn5cfq
         IcQkXRQbW5HbNdYYXpEwUKfm5QQM21D3k7xMxMcOl2+77jtigUkDGjJUmEXRvsEnHTQc
         ZNOw==
X-Gm-Message-State: AOAM531JKdZ50/EUnsW/aLlOHc2ZM0Q/hIbb4JrRec/MykDQMNleJvjM
	3FqpiBz6wTMIPb0qHeB/vFlQBRriqY5HZJ9WtLhFVg==
X-Google-Smtp-Source: ABdhPJz29vxPQ2UvOGrmpFsYEgwEbkmelZkOr2GhVjXMz5NlhrvrfLf39kb09hNdikKISYeJcyfiJ7bVCC9Kb5DEvSE=
X-Received: by 2002:ad4:5ec9:: with SMTP id jm9mr30391925qvb.24.1617112679085;
 Tue, 30 Mar 2021 06:57:59 -0700 (PDT)
MIME-Version: 1.0
References: <20210328131125.26788-1-dandan.bi@intel.com> <20210328131125.26788-29-dandan.bi@intel.com>
In-Reply-To: <20210328131125.26788-29-dandan.bi@intel.com>
From: "Marcin Wojtas" <mw@semihalf.com>
Date: Tue, 30 Mar 2021 15:57:47 +0200
Message-ID: <CAPv3WKcZCvPGG9z4fNc1V=uMvV-tXBJFQze5FRGq4KWnZ4JuMg@mail.gmail.com>
Subject: Re: [edk2-platforms] [patch V4 28/37] Platform/SolidRun: Consume MdeLibs.dsc.inc for RegisterFilterLib
To: Dandan Bi <dandan.bi@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

niedz., 28 mar 2021 o 15:12 Dandan Bi <dandan.bi@intel.com> napisa=C5=82(a)=
:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Thanks,
Marcin

> ---
> V4:
> NA
>
> V3:
> Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common
> [LibraryClasses] section since we can specify different [LibraryClasses]
> section for libary instances in MdeLibs.dsc.inc.
>
> V2:
> Update Platform dsc to consume the MdeLibs.dsc.inc rather than
> consuming RegisterFilterLibNull instance directly.
> ---
>  Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc b/Plat=
form/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> index fec0cc2b51..9196300572 100644
> --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> @@ -27,10 +27,11 @@ [Defines]
>    DEFINE NETWORK_TLS_ENABLE             =3D FALSE
>    DEFINE NETWORK_HTTP_BOOT_ENABLE       =3D FALSE
>    DEFINE NETWORK_ISCSI_ENABLE           =3D FALSE
>
>  !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +!include MdePkg/MdeLibs.dsc.inc
>
>  [Components.common]
>    Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0McBin.inf
>
>  [Components.AARCH64]
> --
> 2.18.0.windows.1
>