From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9AC6194182B for ; Fri, 12 Jan 2024 13:25:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9CSXjairvw9BSzcSUus93toqBLDJnMhzirPt5BuhMXU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705065924; v=1; b=WUnO5RA4gLle+fQT3Dfh8XbTQrB5g8m7L5a3RCFCeaTcBq91uwRURzFKr8oIiGKvya2f6nRK WlKXefPOKMrRmXj8vjexIH5IcpgZroxrSTETtENt2WdgJh+PFz4A6YaDHl0Cda7c0gToEd1PkRP ERH5AFrbU7bthlojb6jvDn3w= X-Received: by 127.0.0.2 with SMTP id czlwYY7687511xyODQpIa7w5; Fri, 12 Jan 2024 05:25:24 -0800 X-Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by mx.groups.io with SMTP id smtpd.web11.6845.1705065923480157647 for ; Fri, 12 Jan 2024 05:25:23 -0800 X-Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5955a4a9b23so3382725eaf.1 for ; Fri, 12 Jan 2024 05:25:23 -0800 (PST) X-Gm-Message-State: cyCVn8TI6g4tWbRPgg5qQXw4x7686176AA= X-Google-Smtp-Source: AGHT+IGLgAy6kl8FmFp4ZdYp88Uoi8J/0cdv3nSlP8nSOK22l/gy5+dXEaiqZHJU+5GjztZkP3c0pgkkBRrn2GJgs2c= X-Received: by 2002:a05:6820:16a3:b0:596:269d:5685 with SMTP id bc35-20020a05682016a300b00596269d5685mr872707oob.2.1705065922533; Fri, 12 Jan 2024 05:25:22 -0800 (PST) MIME-Version: 1.0 References: <20231221005427.13932-1-ndhillon@marvell.com> In-Reply-To: <20231221005427.13932-1-ndhillon@marvell.com> From: "Marcin Wojtas via groups.io" Date: Fri, 12 Jan 2024 14:25:11 +0100 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 0/8] Silicon/Marvell/OdysseyPkg: To: devel@edk2.groups.io, ndhillon@marvell.com, marcin.s.wojtas@gmail.com Cc: quic_llindhol@quicinc.com, sbalcerak@marvell.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mw@semihalf.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WUnO5RA4; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io +marcin.s.wojtas@gmail.com Hi Narinder, czw., 21 gru 2023 o 01:54 Narinder Dhillon napisa=C5= =82(a): > > From: Narinder Dhillon > > New Marvell Odyssey SoC > > This patchset contains only the very basic elements needed to boot to > EDK2 UiApp on Marvell Odyssey SoC > - ARM BL31 firmware component copies EDK2 image into memory, so it is > always executing from memory > - There is a SMC library to get system information from BL31 > - There are drivers to get board configuration details from a device > tree > - There is no on-chip RTC, a dummy driver is used > - Emulated variable storage is used for now > > v2: > Split patch into 8 commits > > v1: > Original patch in single commit > > Narinder Dhillon (8): > Silicon/Marvell: New Marvell Odyssey processor > Silicon/Marvell: Odyssey ArmPlatformLib > Silicon/Marvell: Odyssey SmcLib > Silicon/Marvell: Odyssey watchdog driver > Silicon/Marvell: RTC driver > Silicon/Marvell: Device tree driver > Silicon/Marvell: Driver to dump board configuration > Silicon/Marvell: Odyssey project description files > Thanks for splitting the change to multiple commits, I'm done with the first round of review and looking forward to the next iteration. Best regards, Marcin > Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc | 216 ++++++++++ > Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf | 304 +++++++++++++ > .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++++++++++++++++ > .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43 ++ > .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 361 ++++++++++++++++ > .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.h | 102 +++++ > .../Fdt/FdtPlatformDxe/FdtPlatformDxe.inf | 60 +++ > .../Fdt/FdtPlatformDxe/FdtPlatformDxe.uni | 106 +++++ > .../Drivers/Fdt/FdtPlatformDxe/README.txt | 69 +++ > .../Drivers/Fdt/FdtPlatformDxe/ShellDumpFdt.c | 283 ++++++++++++ > .../Marvell/Drivers/Null/RtcNull/RtcNullDxe.c | 280 ++++++++++++ > .../Marvell/Drivers/Null/RtcNull/RtcNullDxe.h | 37 ++ > .../Drivers/Null/RtcNull/RtcNullDxe.inf | 46 ++ > .../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++++++++++++++++++ > .../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++ > .../AArch64/ArmPlatformHelper.S | 86 ++++ > .../Library/ArmPlatformLib/ArmPlatformLib.c | 79 ++++ > .../Library/ArmPlatformLib/ArmPlatformLib.inf | 55 +++ > .../ArmPlatformLib/ArmPlatformLibMem.c | 131 ++++++ > Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 ++ > Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 ++ > .../Include/Library/SmcLib.h | 28 ++ > .../Include/Protocol/FdtClient.h | 180 ++++++++ > .../MarvellSiliconPkg/MarvellSiliconPkg.dec | 19 + > Silicon/Marvell/OdysseyPkg/OdysseyPkg.dsc.inc | 394 +++++++++++++++++ > .../PrePi/AArch64/ModuleEntryPoint.S | 136 ++++++ > .../ArmPlatformPkg/PrePi/PeiMPCore.inf | 110 +++++ > .../Override/ArmPlatformPkg/PrePi/PrePi.c | 238 ++++++++++ > 28 files changed, 4251 insertions(+) > create mode 100644 Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc > create mode 100644 Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtClientDxe/FdtClientDxe= .c > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtClientDxe/FdtClientDxe= .inf > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/FdtPlatfor= m.c > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/FdtPlatfor= m.h > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/FdtPlatfor= mDxe.inf > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/FdtPlatfor= mDxe.uni > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/README.txt > create mode 100644 Silicon/Marvell/Drivers/Fdt/FdtPlatformDxe/ShellDumpF= dt.c > create mode 100644 Silicon/Marvell/Drivers/Null/RtcNull/RtcNullDxe.c > create mode 100644 Silicon/Marvell/Drivers/Null/RtcNull/RtcNullDxe.h > create mode 100644 Silicon/Marvell/Drivers/Null/RtcNull/RtcNullDxe.inf > create mode 100644 Silicon/Marvell/Drivers/Wdt/GtiWatchdogDxe/GtiWatchdo= g.c > create mode 100644 Silicon/Marvell/Drivers/Wdt/GtiWatchdogDxe/GtiWatchdo= gDxe.inf > create mode 100644 Silicon/Marvell/Library/ArmPlatformLib/AArch64/ArmPla= tformHelper.S > create mode 100644 Silicon/Marvell/Library/ArmPlatformLib/ArmPlatformLib= .c > create mode 100644 Silicon/Marvell/Library/ArmPlatformLib/ArmPlatformLib= .inf > create mode 100644 Silicon/Marvell/Library/ArmPlatformLib/ArmPlatformLib= Mem.c > create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.c > create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.inf > create mode 100644 Silicon/Marvell/MarvellSiliconPkg/Include/Library/Smc= Lib.h > create mode 100644 Silicon/Marvell/MarvellSiliconPkg/Include/Protocol/Fd= tClient.h > create mode 100644 Silicon/Marvell/OdysseyPkg/OdysseyPkg.dsc.inc > create mode 100644 Silicon/Marvell/Override/ArmPlatformPkg/PrePi/AArch64= /ModuleEntryPoint.S > create mode 100644 Silicon/Marvell/Override/ArmPlatformPkg/PrePi/PeiMPCo= re.inf > create mode 100644 Silicon/Marvell/Override/ArmPlatformPkg/PrePi/PrePi.c > > > base-commit: 59ef582c1bada1e25d0f1490e2af2d68b067fad2 > -- > 2.34.1 > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113739): https://edk2.groups.io/g/devel/message/113739 Mute This Topic: https://groups.io/mt/103292508/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-