From: Marcin Wojtas <mw@semihalf.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
nadavh@marvell.com, Neta Zur Hershkovits <neta@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Hua Jing <jinghua@marvell.com>,
semihalf-dabros-jan <jsd@semihalf.com>
Subject: Re: [platforms: PATCH v2 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information
Date: Mon, 4 Dec 2017 16:15:29 +0100 [thread overview]
Message-ID: <CAPv3WKcfjuv9-X46yqS+_CY=YqO3po2Y-tbVDSEUWqA4fOAkNw@mail.gmail.com> (raw)
In-Reply-To: <20171204135246.tozopcqfetsiutgx@bivouac.eciton.net>
2017-12-04 14:52 GMT+01:00 Leif Lindholm <leif.lindholm@linaro.org>:
> On Fri, Dec 01, 2017 at 04:35:06PM +0100, Marcin Wojtas wrote:
>> fupdate command's usage information referred to a deprecated
>> '-f' flag in 'examples' section. It was a residue from the
>> initial version of the application, removed during review
>> before merging to upstream branch. Correct the help information.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>
> I boggled slightly at how the file with deleted content is larger than
> the original, so went to have a look, and what I see is:
>
> --- pre.txt 2017-12-04 13:43:32.985446108 +0000
> +++ post.txt 2017-12-04 13:44:30.433120594 +0000
> @@ -50,10 +50,10 @@
> ".SH EXAMPLES\r\n"
> " \r\n"
> "EXAMPLES:\r\n"
> -"Update firmware from file fs2:flash-image.bin\r\n"
> -" fupdate -f fs2:flash-image.bin\r\n"
> +"Update firmware in SPI flash from file fs2:flash-image.bin\r\n"
> +" fupdate fs2:flash-image.bin\r\n"
> ".SH RETURNVALUES\r\n"
> " \r\n"
> "RETURN VALUES:\r\n"
> " SHELL_SUCCESS The action was completed as requested.\r\n"
> -" SHELL_ABORTED Error while processing command\r\n"
> +" SHELL_ABORTED Error while processing command\r\n"
>
>
> Now, I don't mind random format cleanup as much in .uni files as
> elsewhere, since we don't get sane diffs anyway. But that also makes
> detailed and accurate commit messages much more important.
>
> So please, add something about the rewording and the whitespace fixes.
>
Sure, will do.
Thanks,
Marcin
next prev parent reply other threads:[~2017-12-04 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 15:35 [platforms: PATCH v2 0/4] Armada 7k/8k - misc improvements pt.3 Marcin Wojtas
2017-12-01 15:35 ` [platforms: PATCH v2 1/4] Marvell/Armada: Switch to dynamic tftp command Marcin Wojtas
2017-12-04 13:32 ` Leif Lindholm
2017-12-04 15:04 ` Marcin Wojtas
2017-12-01 15:35 ` [platforms: PATCH v2 2/4] Marvell/Armada: Fix watchdog control base Marcin Wojtas
2017-12-01 15:35 ` [platforms: PATCH v2 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information Marcin Wojtas
2017-12-04 13:52 ` Leif Lindholm
2017-12-04 15:15 ` Marcin Wojtas [this message]
2017-12-01 15:35 ` [platforms: PATCH v2 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header Marcin Wojtas
2017-12-04 14:00 ` Leif Lindholm
2017-12-04 15:22 ` Marcin Wojtas
2017-12-04 16:10 ` Leif Lindholm
2017-12-04 16:35 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPv3WKcfjuv9-X46yqS+_CY=YqO3po2Y-tbVDSEUWqA4fOAkNw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox