From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:400c:c09::234; helo=mail-wm0-x234.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 15E1A22152384 for ; Mon, 4 Dec 2017 07:11:01 -0800 (PST) Received: by mail-wm0-x234.google.com with SMTP id f140so14920787wmd.2 for ; Mon, 04 Dec 2017 07:15:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sr6eX2TN8HzaDADY9n5hML0T9mPMKUSNiwOVRXA4mt8=; b=oYqvofiKDr7UWCggdOkcC3ql1TmbSTEP5z14lZ2fVuER2A0vhhpEdDht541LyWHrC8 19C06/ZSBfOzaD3IyCeIurMjCvCCy9KjbvihyTMCqpS5hmDCmqktAKrTCnZXTDt9rtF2 MWl2GPuLTD6c5krHFQnl5gvVd1qwFe7WCJnMYIKJJ1IvLi3KeAkd9UTC2TKteNT/Gx7n vgjvLdLP37rWZXQYOmqxQqpRyHnRgL/ggPyxnugoEBzZ3fdiJjB1uRm225dE++WiRc50 dlISktqQmU4yy+1YPOBgnHTOLgd3gzqjC1p9qA6+YBsrGkM6VFmMdY51Zdktd1rk6vna UnvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sr6eX2TN8HzaDADY9n5hML0T9mPMKUSNiwOVRXA4mt8=; b=d4ZhPsSo3NYWRGtiRg+1xy293+inpRR2gh4IQ+blMxtKYG1sa7o1Q2iOEWhN4jeVFa b3V73Qss3tbh16k9nR6jsWxnel+R5eHcSZZHVsLVkYKhjJU+B7pshF/bTPNdM8OoKWxc xICqpc8N8gjGtYuLj59IGjPN94QlfZjzFf9hX35kyZTpBFYa2zB0tCZHtBD6pRs57x3a QOXuwi6Wk/QGXL3u1SxmvU33f7Wt4JUqOzR4sgBd8IaN9jCKx6SSvmyjZqdb52WmmSW/ cui3E6kNjNVEamsvT8S4sZIyPjCcZHXMTgmX4EAJGJhwQiUEd3F9tLOEYIU59CDQZXNI QjLA== X-Gm-Message-State: AJaThX4GWoXFOMbWJyWWXcD9uGGzs0N/iSwKwMD7dwiPHwnQ/k+BIrv4 ElBL+EpVob1f9wcLBBlmLTGIeCJDwDF4imeREnVi0w== X-Google-Smtp-Source: AGs4zMZ2yvDZdMP/SlWos7d8S2x3IlQdhIno+w/I3Tiff+ss5RKblrf0UStOhTP73IO12TEFJcG3BQu/bqyTLkN3Ovs= X-Received: by 10.28.131.73 with SMTP id f70mr7871348wmd.153.1512400530507; Mon, 04 Dec 2017 07:15:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.163.207 with HTTP; Mon, 4 Dec 2017 07:15:29 -0800 (PST) In-Reply-To: <20171204135246.tozopcqfetsiutgx@bivouac.eciton.net> References: <1512142507-23282-1-git-send-email-mw@semihalf.com> <1512142507-23282-4-git-send-email-mw@semihalf.com> <20171204135246.tozopcqfetsiutgx@bivouac.eciton.net> From: Marcin Wojtas Date: Mon, 4 Dec 2017 16:15:29 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH v2 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 15:11:02 -0000 Content-Type: text/plain; charset="UTF-8" 2017-12-04 14:52 GMT+01:00 Leif Lindholm : > On Fri, Dec 01, 2017 at 04:35:06PM +0100, Marcin Wojtas wrote: >> fupdate command's usage information referred to a deprecated >> '-f' flag in 'examples' section. It was a residue from the >> initial version of the application, removed during review >> before merging to upstream branch. Correct the help information. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas > > I boggled slightly at how the file with deleted content is larger than > the original, so went to have a look, and what I see is: > > --- pre.txt 2017-12-04 13:43:32.985446108 +0000 > +++ post.txt 2017-12-04 13:44:30.433120594 +0000 > @@ -50,10 +50,10 @@ > ".SH EXAMPLES\r\n" > " \r\n" > "EXAMPLES:\r\n" > -"Update firmware from file fs2:flash-image.bin\r\n" > -" fupdate -f fs2:flash-image.bin\r\n" > +"Update firmware in SPI flash from file fs2:flash-image.bin\r\n" > +" fupdate fs2:flash-image.bin\r\n" > ".SH RETURNVALUES\r\n" > " \r\n" > "RETURN VALUES:\r\n" > " SHELL_SUCCESS The action was completed as requested.\r\n" > -" SHELL_ABORTED Error while processing command\r\n" > +" SHELL_ABORTED Error while processing command\r\n" > > > Now, I don't mind random format cleanup as much in .uni files as > elsewhere, since we don't get sane diffs anyway. But that also makes > detailed and accurate commit messages much more important. > > So please, add something about the rewording and the whitespace fixes. > Sure, will do. Thanks, Marcin