From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 942202118A5B3 for ; Fri, 2 Nov 2018 03:09:12 -0700 (PDT) Received: by mail-it1-x144.google.com with SMTP id k206-v6so2459539ite.0 for ; Fri, 02 Nov 2018 03:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OhBajhLt9SJ0cKjl3jiYVdPYHsIR9YSsSBoCseOM87s=; b=dopIzqgmu1AwibcdCWk67euU/gNMXRZnoSaiFtB2P9llD7zADuFZ3IdlXuKctz6PSm qA9YqlKqjvG+e2fZ1/o8pPBlFKJg7NYgnOeDyKwy1MIcLbcYEu61hg5LvGTZ768TY5xr vqrqfPmuSZgfW6SB349CKfV6G5/HdqMf+sIuvbpKp8aWFi3qx7DCIbr1o9VpPdUj1SCO qUVee6MkIwnxkuBTKu9cB+Cfl3fQAwP/BOviXjLVKXrLY6VQcRsWDjl8pjqfGJ1sL195 VvWyYp3U/UxBVIcHYfnIoVzdKFtDEAB3I672R9CFlNr+4n6GiuFqypnhYFhPKvEXijnq /yKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OhBajhLt9SJ0cKjl3jiYVdPYHsIR9YSsSBoCseOM87s=; b=Tt5ASa/HMhwReoOYJFq13hR2jddbZ++BNEF6NtaqWQ/y9nLGEmxtyexuXzKGnG5Ytq ZoZai631P9elo3cGZ/PuEgWuGrdeFdLE3js5c/sJYSiXGyqqs+f6pxklm1kpxzm+wRXO m7WIUd8rBNOUBICTe1XmJUn/TBrUEaz+j60n/4oVA5P27KDFVTCZmhj3OsTsR6HYAT5g y+zB/HfZETrPVbIkmJb//DmMuGWT8iRSb6yHP1SJVEYhg7qdTcbyn+sTNiPodolpcJfK ptUb5LRPGK4HXjGYNDvabSp+jkotTOLwgu1Ief3zoyFqldp0DygdVyWiwGTfJzT7jN/w qIVQ== X-Gm-Message-State: AGRZ1gJV0lWgUCFeuGLBIwmMzXXtfHdVTcd/O5XgU+HSVbCgr8gcrGBM /6cCVjbwLDnb/mBFDse21MtjArt8sHmrs3v59mOmA4Td X-Google-Smtp-Source: AJdET5f3zgT3RVERD2K850KNiVbIA1+TnLCXVscf0ttECD4VXwt7KZjitqxjKBKxo9eTenqSx2Vi8aCQvZDnIz6iRko= X-Received: by 2002:a24:a10:: with SMTP id 16-v6mr131456itw.145.1541153351734; Fri, 02 Nov 2018 03:09:11 -0700 (PDT) MIME-Version: 1.0 References: <1538745911-22484-1-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Fri, 2 Nov 2018 11:09:00 +0100 Message-ID: To: hao.a.wu@intel.com Cc: Ard Biesheuvel , edk2-devel-01 , "Kinney, Michael D" , "Gao, Liming" , Leif Lindholm , nadavh@marvell.com, "jsd@semihalf.com" , Tomasz Michalec Subject: Re: [PATCH v2 0/4] SdMmcOverride extension X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 10:09:12 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hao, czw., 1 lis 2018 o 08:11 Wu, Hao A napisa=C5=82(a): > > Hi Marcin and Ard, > > > -----Original Message----- > > From: Marcin Wojtas [mailto:mw@semihalf.com] > > Sent: Friday, October 05, 2018 9:25 PM > > To: edk2-devel@lists.01.org > > Cc: Tian, Feng; Kinney, Michael D; Gao, Liming; leif.lindholm@linaro.or= g; Wu, > > Hao A; ard.biesheuvel@linaro.org; nadavh@marvell.com; > > mw@semihalf.com; jsd@semihalf.com; tm@semihalf.com > > Subject: [PATCH v2 0/4] SdMmcOverride extension > > > > Hi, > > > > This is the second version of the patchset. Initial one was > > interleaved with the fixes, which after split got already merged. > > The biggest change is - resigning from the new callbacks > > and extending parameter lists of both NotifyPhase and Capability > > routines. > > > > Patches are available in the github: > > https://github.com/MarvellEmbeddedProcessors/edk2-open- > > platform/commits/sdmmc-override-upstream-r20181005 > > > > Please note that extending SdMmcOverride protocol was impacting > > so far the only user of it (Synquacer controller). In paralel > > edk2-platforms patchset, a patch can be found: > > ("Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride") > > which immunizes for above and future extensions of the protocol: > > https://github.com/MarvellEmbeddedProcessors/edk2-open- > > platform/commits/xenon-upstream-r20181005 > > > > I'm looking forward to the comments and remarks. > > Since there are protocol service interface changes, maybe a version chang= e > (macro EDKII_SD_MMC_OVERRIDE_PROTOCOL_VERSION) for the SdMmc Override Pro= tocol > is needed. > > Please share your thoughts on this one. Thanks. IMO such change is justified. I can add it in a separate on top, you can decide later with Ard, if it's good to merge it. Best regards, Marcin > > Best Regards, > Hao Wu > > > > > Best regards, > > Marcin > > > > Changelog: > > v1 -> v2 > > * Rebase onto newest master > > * 1/4 [new patch] - preparation for extending NotifyPhase > > * 2/4 - UhsSignaling as a part of NotifyPhase > > * 3/4 - SwitchClockFreqPost as a part of NotifyPhase > > * 4/4 - Allow updating BaseClkFreq via Capability instead of the > > independent callback. > > > > Marcin Wojtas (2): > > MdeModulePkg/SdMmcPciHcDxe: Add an optional parameter in > > NotifyPhase > > MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency > > > > Tomasz Michalec (2): > > MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride > > protocol > > MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to > > SdMmcOverride > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 + > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 62 +++++- > > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 12 +- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 215 > > ++++++++++++++------ > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 57 +++++- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 18 +- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 108 ++++++++- > > - > > 7 files changed, 383 insertions(+), 95 deletions(-) > > > > -- > > 2.7.4 >