From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=tvvjOV0q; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.180, mailfrom: mw@semihalf.com) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by groups.io with SMTP; Fri, 14 Jun 2019 11:44:23 -0700 Received: by mail-qt1-f180.google.com with SMTP id d23so3678004qto.2 for ; Fri, 14 Jun 2019 11:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XLzu4TZ13aNQcYe6uXx89JtLIjhY9oK7jLAnrXnnMeA=; b=tvvjOV0q8QxXiJZaC9a7G0Flpc9TRe9bCzv15Ak7G4fm6Y2vKH2Dn63/tHhqMhAZr3 e61P/vrq7mjVeZRqnQAooGgZBm2PFW7XQEUZLCHxYbTnYYh2v2e1Y+UJu768e0zrBosu luf2pISEWkd5H1gdPAyBrR59rJbb8aq8Xw7u1ukA1YZx4+FBXXOU7g0jQtqtbBs04Dkp vcwRbYfRtWeKU9G5BS2QGSuML24LZXczFxpoELae97gJ16mUU/64fdzBXx3oW9gFeHGk OwKJNzzqW5R6KMH09Mi7rTGo37ItETW0nxBoAzAo12bi1/VuxynTJ9hVoEYW1Jel9OaL QKNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XLzu4TZ13aNQcYe6uXx89JtLIjhY9oK7jLAnrXnnMeA=; b=KeI2aej/6tpeqKZ1kNbKsBR7s8Xz16sgMwh4bMQQa/3dORibLeX2XFxwxZZSKO92m1 MqzFMxkAdJbFuV2w/ZyUJ2YpnlHpqWWfP/USNYk3S5bQuYF9kwBOdS7Ir7RNaoaCmssf 0tJ3n6IXzhfGlCZI0AdgvNuHut44I4UTvGNgmJ8lPZARGx2/uANMi/XRAr8ugMH55tPr b0atAI0T0Ws5DxcEUL8yRMTG5da8N4gQhp+iBhJsa29tNxrz8bEvD/LXMY5OR8UzfQ8m omhgQFzbcVCTRpcjgMkr9ADe9HNH31mEy5+VtVU4+631kfSpCp89rrVl03D2LaLtu02x NDxQ== X-Gm-Message-State: APjAAAUewUH7U6anz7fb1Y43k/gzjhDGEa4/u3GP/QKh8Ap+Mc3jFGJt InpDpD0peKSZIyzsMYpOZwv5FkIo5h1ibsbcN0mZzw== X-Google-Smtp-Source: APXvYqweFHKEBZnmJMn4yYT5yRCCqJtBF3hu2N77dm6KbRh9O53IAS080zEYnQv1UhVuggwrqiTFVEbZrO9VCy+2EA0= X-Received: by 2002:a0c:afa4:: with SMTP id s33mr9251724qvc.194.1560537862303; Fri, 14 Jun 2019 11:44:22 -0700 (PDT) MIME-Version: 1.0 References: <20190603113346.1288-1-mateusz.albecki@intel.com> <92CF190FF2351747A47C1708F0E09C0875E512A7@IRSMSX102.ger.corp.intel.com> In-Reply-To: From: "Marcin Wojtas" Date: Fri, 14 Jun 2019 20:44:10 +0200 Message-ID: Subject: Re: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol To: "Wu, Hao A" Cc: "devel@edk2.groups.io" , Ard Biesheuvel , "Albecki, Mateusz" Content-Type: multipart/alternative; boundary="000000000000f10795058b4d080e" --000000000000f10795058b4d080e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Hao, Please give me some time to try and review - I hope to find some slot next week. Best regards, Marcin pt., 14 cze 2019 o 03:46 Wu, Hao A napisa=C5=82(a): > Loop in Ard and Marcin. > > > > > > Hello Ard and Marcin, > > > > We are proposing to make an extension to the SDMMC Override protocol to > > more customization for platforms during the SD/eMMC device/controller > > initialization process. > > > > For convenience, the series is available at: > > https://github.com/hwu25/edk2/tree/sdmmc_override_extension_v1 > > > > I only verified the change will not break the build for platforms > > (in edk2-platform repo). Could you help provide feedbacks for this series= ? > > Thanks in advance. > > > > Best Regards, > > Hao Wu > > > > *From:* Albecki, Mateusz > *Sent:* Thursday, June 13, 2019 9:44 PM > *To:* devel@edk2.groups.io > *Cc:* Wu, Hao A > *Subject:* RE: [PATCH 0/2] Add GetOperatingParam notify phase to > SdMmcOverride protocol > > > > Resending to group. > > > > *From:* Wu, Hao A > *Sent:* Monday, June 10, 2019 5:18 AM > *To:* Albecki, Mateusz > *Subject:* RE: [PATCH 0/2] Add GetOperatingParam notify phase to > SdMmcOverride protocol > > > > Hello Mateusz, > > > > Thanks for the patch series and sorry for the delayed response. > > > > One question first, I did not see the patches being sent to the mailing > list > > 'devel@edk2.groups.io'. We have recently switched to this new mailing > list back > > to early April, the old one 'edk2-devel@lists.01.org' is no longer being > used. > > > > In case that you have not registered the new list, you can sign up at: > > https://edk2.groups.io/g/devel > > or email: > > devel+subscribe@edk2.groups.io > > to get registered in the new mailing list. > > > > Or you can send me the patch files and I will help to send them to the > mailing list. > > > > > > Below are some general level feedbacks (Other patch-specific feedbacks > will be replied in other mails): > > =C2=B7 *Could you help to add the below Bugzilla tracker referenc= e in > the commit log message?* > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1882 > > > > =C2=B7 *Could you help to run the script > =E2=80=98BaseTools/Scripts/PatchCheck.py=E2=80=99 and resolve its report = on the commit log > format issues?* > > *Checking git commit: 6e3f64aeb4* > > *The commit message format is not valid:* > > ** Contributed-under! (Note: this must be removed by the code > contributor!)* > > ** Add quotes (") around name with a comma: Albecki, Mateusz* > > ** Email format is invalid: hao.a.wu@intel.com * > > ** Line 15 of commit message is too long.* > > *https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-For= mat > * > > *The code passed all checks.* > > > > *Checking git commit: 91595ae911* > > *The commit message format is not valid:* > > ** Contributed-under! (Note: this must be removed by the code > contributor!)* > > ** Add quotes (") around name with a comma: Albecki, Mateusz* > > ** Email format is invalid: hao.a.wu@intel.com * > > *https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-For= mat > * > > *The code passed all checks.* > > > > =C2=B7 *Could you help to resolve the typo =E2=80=98Prefered=E2= =80=99 to =E2=80=98Preferred=E2=80=99 > in the naming of some variables?* > > > > =C2=B7 *Could you help to use lowercase =E2=80=98static=E2=80=99 = (instead of using the > uppercase one) for the new functions?* > > > > > > Also, I only verified the build of the patch series. Please grant me some > time > > to verify on the HW on my side. Maybe your updated patches arrive first > and I > > will then verify the update ones. > > > > > > Best Regards, > > Hao Wu > > > > > -----Original Message----- > > > From: Albecki, Mateusz > > > Sent: Monday, June 03, 2019 7:34 PM > > > Cc: Albecki, Mateusz; Wu, Hao A > > > Subject: [PATCH 0/2] Add GetOperatingParam notify phase to > > > SdMmcOverride protocol > > > > > > To allow platform greater control over the bus settings for SD card and > > > eMMC card > > > we have added a new notify phase to SdMmcOverrideProtocol called > > > GetOperatingParam. > > > This phase is signaled before SD card/eMMC initialization and allows > platform > > > to tweak > > > the values in new structure called > > > EDKII_SD_MMC_OPERATING_PARAMETERS which allows to configure > > > bus width, clock frequency and driver strength. Other bus parameters ca= n > be > > > configured by > > > overriding host controller capabilities. > > > > > > Tests: > > > - OS boot from eMMC without SdMmcOverride protocol installed > > > - OS boot from eMMC with SdMmcOverride installed and clock frequency > > > lowered to 100MHz in HS200 > > > - OS boot from eMMC with driver strength changed to Type1 > > > - SD card enumeration in UEFI shell on default speed and high speed(non > > > UHS-I) with SdMmcOverride installed and UHS-I disabled in capability > > > > > > > > > Cc: hao.a.wu@intel.com > > > > > > Albecki, Mateusz (2): > > > MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase > > > MdeModulePkg/SdMmcHcDxe: Implement revision 3 of > > > SdMmcOverrideProtocol > > > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 522 > > > +++++++++++++++------ > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 381 > > > ++++++++++++--- > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 52 +- > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 18 +- > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 8 +- > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 8 +- > > > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 58 ++- > > > 7 files changed, 802 insertions(+), 245 deletions(-) > > > > > > -- > > > 2.14.1.windows.1 > > > --000000000000f10795058b4d080e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hao,

Please give me some time to try= and review - I hope to find some slot next week.

= Best regards,
Marcin

pt., 14 cze 2019 o 03:46=C2=A0Wu, Hao A= <hao.a.wu@intel.com> napis= a=C5=82(a):

Loop in Ard and= Marcin.

=C2=A0

=C2=A0

Hello Ard and M= arcin,

=C2=A0

We are proposin= g to make an extension to the SDMMC Override protocol to

more customizat= ion for platforms during the SD/eMMC device/controller=

initialization = process.

=C2=A0

For convenience= , the series is available at:

https://github.com/hwu25/edk2/tree= /sdmmc_override_extension_v1

=C2=A0

I only verified= the change will not break the build for platforms

(in edk2-platfo= rm repo). Could you help provide feedbacks for this series?

Thanks in advan= ce.

=C2=A0

Best Regards,

Hao Wu

=C2=A0

From: Albecki, Mateusz
Sent: Thursday, June 13, 2019 9:44 PM
To: devel@= edk2.groups.io
Cc: Wu, Hao A
Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol

=C2=A0

Res= ending to group.

=C2=A0

From: Wu, Hao A
Sent: Monday, June 10, 2019 5:18 AM
To: Albecki, Mateusz <mateusz.albecki@intel.com>
Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol

=C2=A0

Hello Mateusz,<= u>

=C2=A0

Thanks for the patch s= eries and sorry for the delayed response.

=C2=A0

One question first, I = did not see the patches being sent to the mailing list

'devel@edk2.groups.io'. We = have recently switched to this new mailing list back

to early April, the ol= d one 'edk= 2-devel@lists.01.org' is no longer being used.

=C2=A0

In case that you have = not registered the new list, you can sign up at:

https://edk2.groups.io/g/devel

or email:

devel+subscribe@edk2.groups.i= o

to get registered in t= he new mailing list.

=C2=A0

Or you can send me the= patch files and I will help to send them to the mailing list.

=C2=A0

=C2=A0

Below are some general= level feedbacks (Other patch-specific feedbacks will be replied in other m= ails):

=C2=B7=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Could you help to add the below Bugzilla tracker reference in the= commit log message?

https://bugzi= lla.tianocore.org/show_bug.cgi?id=3D1882

=C2=A0

=C2=B7=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Could you help to run the script =E2=80=98BaseTools/Scripts/PatchCheck.py=E2=80=99 = and resolve its report on the commit log format issues?

Checking git commit: 6e3f64aeb4

The commit message = format is not valid:

* Contributed-under= ! (Note: this must be removed by the code contributor!)

* Add quotes ("= ;) around name with a comma: Albecki, Mateusz

* Email format is i= nvalid: hao.a.wu@intel.com

* Line 15 of commit= message is too long.

https://github.com/tianocore/tianocore.github.io/wiki/Commit-Me= ssage-Format

The code passed all= checks.

=C2=A0

Checking git commit: 91595ae911

The commit message = format is not valid:

* Contributed-under= ! (Note: this must be removed by the code contributor!)

* Add quotes ("= ;) around name with a comma: Albecki, Mateusz

* Email format is i= nvalid: hao.a.wu@intel.com

https://github.com/tianocore/tianocore.github.io/wiki/Commit-Me= ssage-Format

The code passed all= checks.

=C2=A0

=C2=B7=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Could you help to resolve the typo =E2=80=98Prefered=E2=80=99 to =E2=80=98Preferred= =E2=80=99 in the naming of some variables?

=C2=A0

=C2=B7=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Could you help to use lowercase =E2=80=98static=E2=80=99 (instead= of using the uppercase one) for the new functions?

=C2=A0

=C2=A0

Also, I only verified = the build of the patch series. Please grant me some time

to verify on the HW on= my side. Maybe your updated patches arrive first and I

will then verify the u= pdate ones.

=C2=A0

=C2=A0

Best Regards,

Hao Wu

=C2=A0

> -----Original Mes= sage-----

> From: Albecki, Ma= teusz

> Sent: Monday, Jun= e 03, 2019 7:34 PM

> Cc: Albecki, Mate= usz; Wu, Hao A

> Subject: [PATCH 0= /2] Add GetOperatingParam notify phase to

> SdMmcOverride protocol

>

> To allow platform= greater control over the bus settings for SD card and

> eMMC card<= u>

> we have added a n= ew notify phase to SdMmcOverrideProtocol called

> GetOperatingParam= .

> This phase is sig= naled before SD card/eMMC initialization and allows platform<= /p>

> to tweak

> the values in new= structure called

> EDKII_SD_MMC_OPER= ATING_PARAMETERS which allows to configure

> bus width, clock = frequency and driver strength. Other bus parameters can be

> configured by<= /u>

> overriding host c= ontroller capabilities.

>

> Tests:<= /u>

> - OS boot from eM= MC without SdMmcOverride<= /span> protocol installed

> - OS boot from eM= MC with SdMmcOverride installed and clock frequency

> lowered to 100MHz= in HS200

> - OS boot from eM= MC with driver strength changed to Type1

> - SD card enumera= tion in UEFI shell on default speed and high speed(non

> UHS-I) with SdMmcOverride installed= and UHS-I disabled in capability

>

>

> Cc: hao.a.wu@intel.com=

>

> Albecki, Mateusz = (2):

>=C2=A0=C2=A0 MdeMo= dulePkg/SdMmcOverride: Add GetOperatingParam notify phase

>=C2=A0=C2=A0 MdeMo= dulePkg/SdMmcHcDxe= : Implement revision 3 of

> SdMmcOverrideProtocol=

>

>=C2=A0 MdeModulePk= g/Bus/Pci/SdMmcPci= HcDxe/EmmcDevice.c= =C2=A0=C2=A0=C2=A0 | 522

> +++++++++++++++--= ----

>=C2=A0 MdeModulePk= g/Bus/Pci/SdMmcPci= HcDxe/SdDevice.c= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 381

> ++++++++++++---

>=C2=A0 MdeModulePk= g/Bus/Pci/SdMmcPci= HcDxe/SdMmcPciHcDxe.c |=C2=A0 52 +-

>=C2=A0 MdeModulePk= g/Bus/Pci/SdMmcPci= HcDxe/SdMmcPciHcDxe.h |=C2=A0 18 +-

>=C2=A0 MdeModulePk= g/Bus/Pci/SdMmcPci= HcDxe/SdMmcPciHci.c=C2=A0=C2=A0 |=C2=A0=C2=A0 8 +-

>=C2=A0 MdeModulePk= g/Bus/Pci/SdMmcPci= HcDxe/SdMmcPciHci.h=C2=A0=C2=A0 |=C2=A0=C2=A0 8 +-

>=C2=A0 MdeModulePk= g/Include/Protocol/SdMmcO= verride.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 58 ++-=

>=C2=A0 7 files cha= nged, 802 insertions(+), 245 deletions(-)

>

> --<= /p>

> 2.14.1.windows.1<= u>

=C2=A0

--000000000000f10795058b4d080e--