From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0CFCA7803E7 for ; Fri, 8 Dec 2023 16:37:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7YONzit/szgkrV6pMt/wKelZV2KxXvNqidPHbBgJ1cQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702053455; v=1; b=K7iAZiV5Z7+koiuElI12+2my9q1PLTk2bg6SUrkur2oVAX9rKUGVKhwRlhmaIdNQmaqxf6F5 sGy9izDibtEZHAbWW6psAM+W7ENW4CTl67YxxqPVUofQFpnk7jrMXLkDZc3mmbDXVlyvTZqywOY gkHzcE1/q4AJu+2aWQWDCVVo= X-Received: by 127.0.0.2 with SMTP id WHtoYY7687511xDQUxmh1NNC; Fri, 08 Dec 2023 08:37:35 -0800 X-Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by mx.groups.io with SMTP id smtpd.web10.40530.1702053455120177675 for ; Fri, 08 Dec 2023 08:37:35 -0800 X-Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6d9f4eed60eso261810a34.1 for ; Fri, 08 Dec 2023 08:37:34 -0800 (PST) X-Gm-Message-State: If6kja3Ibnx6aSsegUp9I67Yx7686176AA= X-Google-Smtp-Source: AGHT+IFjjrqfkWq7wpst6xfKB79U/r9Ar65laHUqCPNDKNbgrLrJt/Ms5CAdRA2I5qAvKgbSMx2njbTQBRHESlX5TG8= X-Received: by 2002:a05:6870:6787:b0:1fb:75b:12f6 with SMTP id gc7-20020a056870678700b001fb075b12f6mr375762oab.72.1702053454191; Fri, 08 Dec 2023 08:37:34 -0800 (PST) MIME-Version: 1.0 References: <20231130151427.15841-1-ndhillon@marvell.com> In-Reply-To: <20231130151427.15841-1-ndhillon@marvell.com> From: "Marcin Wojtas via groups.io" Date: Fri, 8 Dec 2023 17:37:22 +0100 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/1] Silicon/Marvell/OdysseyPkg: New Marvell Odyssey processor To: devel@edk2.groups.io, ndhillon@marvell.com Cc: quic_llindhol@quicinc.com, sbalcerak@marvell.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mw@semihalf.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=K7iAZiV5; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Narinder, czw., 30 lis 2023 o 16:14 Narinder Dhillon napisa=C5= =82(a): > > From: Narinder Dhillon > > This patch adds support for Marvell Odyssey processor. > > It contains only the very basic elements needed to boot to EDK2 UiApp. > - ARM BL31 firmware component copies EDK2 image into memory, so it is > always executing from memory > - There is a SMC library to get system information from BL31 > - There are drivers to get board configuration details from a device > tree > - There is no on-chip RTC, a dummy driver is used > - Emulated variable storage is used for now > > Signed-off-by: Narinder Dhillon > --- > Platform/Marvell/OdysseyPkg/OdysseyPkg.dsc | 216 ++++++++++ > Platform/Marvell/OdysseyPkg/OdysseyPkg.fdf | 304 +++++++++++++ > .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.c | 382 ++++++++++++++++ > .../Drivers/Fdt/FdtClientDxe/FdtClientDxe.inf | 43 ++ > .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c | 361 ++++++++++++++++ > .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.h | 102 +++++ > .../Fdt/FdtPlatformDxe/FdtPlatformDxe.inf | 60 +++ > .../Fdt/FdtPlatformDxe/FdtPlatformDxe.uni | 106 +++++ > .../Drivers/Fdt/FdtPlatformDxe/README.txt | 69 +++ > .../Drivers/Fdt/FdtPlatformDxe/ShellDumpFdt.c | 283 ++++++++++++ > .../Marvell/Drivers/Null/RtcNull/RtcNullDxe.c | 281 ++++++++++++ > .../Marvell/Drivers/Null/RtcNull/RtcNullDxe.h | 41 ++ > .../Drivers/Null/RtcNull/RtcNullDxe.inf | 46 ++ > .../Drivers/Wdt/GtiWatchdogDxe/GtiWatchdog.c | 408 ++++++++++++++++++ > .../Wdt/GtiWatchdogDxe/GtiWatchdogDxe.inf | 45 ++ > .../AArch64/ArmPlatformHelper.S | 86 ++++ > .../Library/ArmPlatformLib/ArmPlatformLib.c | 79 ++++ > .../Library/ArmPlatformLib/ArmPlatformLib.inf | 55 +++ > .../ArmPlatformLib/ArmPlatformLibMem.c | 131 ++++++ > Silicon/Marvell/Library/SmcLib/SmcLib.c | 189 ++++++++ > Silicon/Marvell/Library/SmcLib/SmcLib.inf | 32 ++ > .../Include/Library/SmcLib.h | 71 +++ > .../Include/Protocol/FdtClient.h | 180 ++++++++ > .../MarvellSiliconPkg/MarvellSiliconPkg.dec | 19 + > Silicon/Marvell/OdysseyPkg/OdysseyPkg.dsc.inc | 394 +++++++++++++++++ > .../PrePi/AArch64/ModuleEntryPoint.S | 136 ++++++ > .../ArmPlatformPkg/PrePi/PeiMPCore.inf | 110 +++++ > .../Override/ArmPlatformPkg/PrePi/PrePi.c | 238 ++++++++++ To ease the review, can you please split this huge commit into several patches, e.g.: 1. Add FdtPlatfromDxe 2. Add RtcNull 3. Add Wdt 4-6. Add libraries + headers 7. Add ArmPlatformPkg 8. Add OdysseyPkg.dsc.inc 9, Add Platform/Marvell/OdysseyPkg (in the latter you may also add some README file, see other Marvell/SolidRun platforms for reference) Thanks, Marcin -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112237): https://edk2.groups.io/g/devel/message/112237 Mute This Topic: https://groups.io/mt/102895289/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-