From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FF3A209455EE for ; Tue, 4 Jul 2017 04:17:33 -0700 (PDT) Received: by mail-io0-x235.google.com with SMTP id h134so70150369iof.2 for ; Tue, 04 Jul 2017 04:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IGsATzYpuG8UlZ7d5tIMPRq6JsfjpYWcnX+qOVGZ+Vs=; b=e/JigjgSGMlH8+BBPRs3FAS5GE6nyY0iDXVxjX8M4J1EI9GgItir2MRqnswP75Asvi HNaacZIknswfXtjDIU384tHpPzVF7oPTD1fw5vZVZwaqbyyAf0awkW+ykMvj6eXp/RSp RlcfFq+TMKtxetqCMfdkJFKa6AUxE5O+WdHcUd+yh/fOFXweTuz6BL6L4viqfj6Ybbr5 RcY1Qs5p5LoNe9PaDCJSazuxPXv2YYEt1idmMA/HOrsrTtMICjeq4mEddxxiba0I5nHB SXcy7y6L9TO7iiiMFsq6dBZPHmsDFzOigqJCSTiD9aAC8xe+66/hqhLrRydoKESoNZf8 8MlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IGsATzYpuG8UlZ7d5tIMPRq6JsfjpYWcnX+qOVGZ+Vs=; b=rTc6RC2rfxwB8mSoGeIj1YYcsoYebHhgtOwG7yg5lJdINUwVS4de9MsYua0ad2Ewuv 0sm120XzSv7UM+YRqa4K5P8pGW43R3XxZz4eLig7ZEKQCVXPcnylv8gPEWFuUfdE2IU+ XUciISn+hNeVPrrKadHeH7dVPA9nuTKs5TVAOlLfiSMctP2FIPImvJSk5L3yjP8xUG6u vQgviZnQq8Xm+tmvbOZQMRf1qHxOJyIkOGNmfkO4jmvEYxED6T/gyd7EO20+Vy2y9UaA eX3llnDy+8sYp54RgyFgP7kE9ThZWLOc45B2Z95uaXSOvSOH5wjwlxukDCxOq3lP2h1F HM5w== X-Gm-Message-State: AKS2vOxi0RcjQpnc8OLug+4kf7znHMS3g9StcF81KZNKh5uxY6NHdBqA rAb3E6Rdv3o1oFUdO3Ecn3IOZCE1Zqpv X-Received: by 10.107.20.72 with SMTP id 69mr38736275iou.176.1499167150637; Tue, 04 Jul 2017 04:19:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.151.16 with HTTP; Tue, 4 Jul 2017 04:19:10 -0700 (PDT) In-Reply-To: References: <20170704110017.32042-1-ard.biesheuvel@linaro.org> From: Marcin Wojtas Date: Tue, 4 Jul 2017 13:19:10 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel Subject: Re: [PATCH] Platforms/Marvell: switch to generic ResetSystemRuntimeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 11:17:33 -0000 Content-Type: text/plain; charset="UTF-8" Leif, where do you have this information from? 7040 differs from 8040 only with the numeber of peripherals. It has same AP806 HW block (CPUs, GIC, DDR controller, etc.). And, what's most important ArmPsciResetSystemLib.inf on the other branch works on my 7040-db board as well. Best regards, Marcin 2017-07-04 13:10 GMT+02:00 Ard Biesheuvel : > On 4 July 2017 at 12:04, Marcin Wojtas wrote: >> Hi, >> >> 2017-07-04 13:00 GMT+02:00 Ard Biesheuvel : >>> Switch to the generic implementation of the ResetSystem() runtime >>> service call, which is preferred over the one in EmbeddedPkg. This >>> involves selecting another DXE runtime driver, and morphing the >>> existing EfiResetSystemLib implementation into a ResetSystemLib one >>> (which is what the generic driver depends on for platform glue) >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Ard Biesheuvel >>> --- >>> Platforms/Marvell/Armada/Armada.dsc.inc | 4 +- >>> Platforms/Marvell/Armada/Armada70x0.fdf | 2 +- >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.c | 110 ++++++++++++++------ >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf | 7 +- >>> 4 files changed, 87 insertions(+), 36 deletions(-) >>> >>> diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc >>> index 475fc6d05379..32eaa2942564 100644 >>> --- a/Platforms/Marvell/Armada/Armada.dsc.inc >>> +++ b/Platforms/Marvell/Armada/Armada.dsc.inc >>> @@ -94,7 +94,7 @@ >>> # Reset and Time libraries >>> EfiTimeBaseLib|OpenPlatformPkg/Library/EfiTimeBaseLib/EfiTimeBaseLib.inf >>> RealTimeClockLib|OpenPlatformPkg/Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf >>> - EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >>> + ResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >> >> Isn't it better to switch to generic PSCI: >> EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf >> and remove MvResetSystemLib whatsoever? >> > > Yes. But Leif tells me that 7040 does not support PSCI?