From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::235; helo=mail-io0-x235.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 314862095B07E for ; Mon, 9 Oct 2017 09:21:53 -0700 (PDT) Received: by mail-io0-x235.google.com with SMTP id m16so13179613iod.1 for ; Mon, 09 Oct 2017 09:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Rg50DZkAeAQ8aU7k1LsEBurh8S+msmgoDiDMjajAr4I=; b=1cQqHtXrppLRd/8cb1xzUasRSssn6bGL5Il9MK1aa2+hr2waNFSlSY5Gw23pxw8IBr 3W0AwrIjdDLD6YEeuzff4/FFJlxhOXWvo121ry6e7jOgyvdEBa2ttKJad1qXsB3d9XSR xexm0ECfS0GofK+W3oZH2XJKR8Qgx4HMX4NuGohuNHLkTJkq98AkHL+P4XX4H8eCnMBs c9BWXmVeVn6ia4TD7DKdRrkjhh1GVkNanCzVVkEQNW+OfOswgXGNL3ZhA/WISFtR/rAk kKoYHE/hxS3hGcfNSLhFA9Do/Izd6c/GdLLMpHDGDTIjOJyOh9NjReR6GswavKFNtCQl ai1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Rg50DZkAeAQ8aU7k1LsEBurh8S+msmgoDiDMjajAr4I=; b=CUVk3Z92DIQqrolSEyG0SJ+O6EjWszcu0OYJOL+o0+kKqyeBU5JC/TtrmzCNU2UACG I29pK9f6uya/wo4+1oWN8TgwNzQlOkPQLo0oK8WYCcuSGcpOSKUIuLjf6tpkDijtbdG9 uuvnm53dSm+R77D4cP4tnVwyr6pgNpQXqoSe4wdl8aS/KujQ7yOeiJGdUjl7aCWaLc2x CTmVGgkZ/5UMpqVw4DLXloJ8L+oKUEzUtnKsx8qluxUrPz79n5+9PkE2i9ZZADhCNO69 D+KIfbznzd+p1HiE5fYxg5/ANr8sMDsEoamek3xa1J2pX6fmTsi+y4CfLbZagnDgbpin xRzQ== X-Gm-Message-State: AMCzsaXug+W7ZuIkrU3p6squ5/1aI4jITbNxSRzSKXOw9BoQ2BausSw8 Ica4bgOtBBgAiQsxuG71Y/vfQLlkxAp7MUZVpw+9Ew== X-Google-Smtp-Source: AOwi7QCgoKe/7QJpLcRJfP8BPnV6EFyDXeFScelbvyeplr3yi3/k/ztB4hAgy/XmQZOeRY2viUR5NzgN+arBbzbjJ1U= X-Received: by 10.107.184.194 with SMTP id i185mr14557161iof.155.1507566319496; Mon, 09 Oct 2017 09:25:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Mon, 9 Oct 2017 09:25:18 -0700 (PDT) In-Reply-To: <20171009162359.cqwmxb45mnvwg33r@bivouac.eciton.net> References: <1507460212-10323-1-git-send-email-mw@semihalf.com> <1507460212-10323-4-git-send-email-mw@semihalf.com> <20171009160002.lwqxkoytc4pvy75y@bivouac.eciton.net> <20171009162359.cqwmxb45mnvwg33r@bivouac.eciton.net> From: Marcin Wojtas Date: Mon, 9 Oct 2017 18:25:18 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 16:21:53 -0000 Content-Type: text/plain; charset="UTF-8" 2017-10-09 18:23 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 06:06:53PM +0200, Marcin Wojtas wrote: >> 2017-10-09 18:00 GMT+02:00 Leif Lindholm : >> > On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: >> >> This patch introduces UTMI description, using the new structures >> >> and template in MvHwDescLib. This change enables more flexible >> >> addition of multiple CP with UTMI PHY's and also significantly >> >> reduces amount of used PCD's for that purpose. Update PortingGuide >> >> documentation accordingly. >> >> >> >> This patch replaces string-based description of Utmi on >> >> Armada 70x0 DB with new, reduced format, which uses macros >> >> in Armada.dsc.inc file for better readability. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Marcin Wojtas >> >> --- >> >> Platform/Marvell/Armada/Armada.dsc.inc | 5 + >> >> Platform/Marvell/Armada/Armada70x0.dsc | 7 +- >> >> Platform/Marvell/Include/Library/MvHwDescLib.h | 47 ++++++ >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 150 ++++++++++---------- >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 1 - >> >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 11 +- >> >> Platform/Marvell/Marvell.dec | 7 +- >> >> Silicon/Marvell/Documentation/PortingGuide.txt | 30 ++-- >> >> 8 files changed, 148 insertions(+), 110 deletions(-) >> >> > >> > This indentation does not appear to follow any of the patterns >> > permitted by the coding style. Please address here and in the two >> > instances below (calls to UtmiPhyConfig and UtmiPhyPowerUp). >> > >> > No need to resubmit the whole series - just the single patch. >> >> Sure, will send right away. > > Thx. Rebased patches are available here: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/parsepcd-upstream-r20171009 > >> >> Example >> >> ------- >> >> >> >> # UtmiPhy >> >> - gMarvellTokenSpaceGuid.PcdUtmiPhyCount|2 >> >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiUnit|L"0xF2580000;0xF2581000" >> >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUsbCfg|L"0xF2440420;0xF2440420" >> >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiCfg|L"0xF2440440;0xF2440444" >> >> - gMarvellTokenSpaceGuid.PcdUtmiPhyUtmiPort|L"0x0;0x1" >> >> + gMarvellTokenSpaceGuid.PcdUtmiControllersEnabled|{ 0x1, 0x1 } >> >> + gMarvellTokenSpaceGuid.PcdUtmiPortType|{ $(UTMI_USB_HOST0), $(UTMI_USB_HOST1) } >> > >> > Actually, looking at this bit made me realise the PortingGuide.txt >> > uses tab characters and uses \n line endings. >> > >> > This is not caused by this set, so does not need to be addressed as >> > part of this series, but if you could follow up with a patch adjusting >> > the formating of documentation, I would be grateful. >> > >> > This is also made painfully clear when running CheckPatch.py. >> > >> >> Well, yes. It's in Sphinx acceptable format > > Apart from a massive structure in Egypt, what is a Sphinx? > >> and it is generated into >> Marvell documentation along with all other projects. If I align it to >> edk2 coding style, I'd have to maintain 2 copies of this file... If >> you insist, I'll change it, but I would be very grateful for accepting >> this one exception, if possible:) Please let know your decision >> (looking at my branch, there won't be much updates of this file). > > Well, I don't see how we can keep a file that makes PatchCheck.py > barf whenever we touch it. If you want to keep this format, please > send a proposal to exclude files of this type from said checks by > PatchCheck.py to edk2-devel. > > Is there a default "Sphinx source" file extension that can be used to > describe this format, rather than changing the rule for anything > called ".txt"? (If not, should we make one?) > Ok, never mind - I'll change it. Thanks, Marcin