From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C881C21EB5294 for ; Thu, 31 Aug 2017 06:32:46 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id d78so21367189ioe.4 for ; Thu, 31 Aug 2017 06:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Qlr6F9lzs5Jo8aPmap+N8PIMX+47ylgE8oMsU2/zrJc=; b=n6IR/BbOYbBjZIZeHhn8GPlBmdAH7EL9xASHJAF6RlVlm6K61vO0jaWN0FHouJ1yqr DcemUP0uGFgdWkrQR5yK0AZJGyS5cf512OA2AFah6tj2ySzvnQkho35s8ystGxeIjmrz ZqX+8D1TLjH5L7r7VYTRJNVhzvyqHrVC6Uu7l+fq82BeKFUzxM1ZmozhdvjZ3rs57z5B YX16UNlt2NsWLgRmkMTTnoqNupXMdi7G39Gq8KQSB8+giSBEtgbmwppHXUzzbGViy5jR kIqLwtAvXQGqMGgKQzyI3+PcJI3qj8iIbj5RS+UhFltBJRXnB3AA73cg8rMovKjag6Ee Szcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Qlr6F9lzs5Jo8aPmap+N8PIMX+47ylgE8oMsU2/zrJc=; b=YswTJbhJZNdJ69Mrw6Hd6tm0vyieGVZ4TwAqRjXZCQ13dfyufW3hdVc/fp7A/ns5dP q3wPATE2kvTcyCB0AvwRhyfDEZcs8KLGONY4WaaTaZLG+xbIqbQPwe1ocqAsz5S8HrE5 BAv20ahkve1oSvECxd7X6pdROH21NkxrfOhPiP0PXWPzQ3cj5i0N+Q0ONmr37ndzSTlO eo9a/Bow+KnMr6R6lFWSaJndpa2BulAHcIOIUoeoo3Dy5fGsDuHIRkuUKEHnBvCX7Bo3 EYv29GddpsaSQDuK2vWFPHFODkOrI290y6jg9/zEI59EfthcvGN1vrMuSCBPNlKYmSdD qY1A== X-Gm-Message-State: AHPjjUh8Fs21y/mBL1hl8pFhUJ4FpPn0H017YGvgX1bF3HO6A3fdjv3p XOE6BSQbbo0ujQtBjdeouma8HPRzztTOHw8= X-Google-Smtp-Source: ADKCNb4c8M9kFkuny48H2asVXOZ63ioPjue6ESofkKEOKSCO6ItB0SriCi5BiopBBtLvQ96Ou82ORu1tqNEQ8HwB0LM= X-Received: by 10.107.12.223 with SMTP id 92mr2336889iom.47.1504186529580; Thu, 31 Aug 2017 06:35:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.190.199 with HTTP; Thu, 31 Aug 2017 06:35:28 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 31 Aug 2017 15:35:28 +0200 Message-ID: To: Ard Biesheuvel Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 13:32:47 -0000 Content-Type: text/plain; charset="UTF-8" Hi Ard, 2017-08-30 15:26 GMT+02:00 Ard Biesheuvel : > On 29 August 2017 at 18:01, Ard Biesheuvel wrote: >> On 29 August 2017 at 16:53, Marcin Wojtas wrote: >>> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel : >>>> On 29 August 2017 at 16:47, Marcin Wojtas wrote: >>>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >>>>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>>>>> Instead of hardcoding the non-cache coherent nature of this device >>>>>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>>>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>>>>> more abstract level. This allows the driver to be shared with >>>>>>> platforms that are cache coherent (by simply switching to another >>>>>>> DmaLib implementation), and removes the hardcoded dependency on >>>>>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>>>>> EDK2. >>>>>>> >>>>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>>>> Signed-off-by: Ard Biesheuvel >>>>>> >>>>>> Ah, and there is the non-bogus fix :) >>>>>> Reviewed-by: Leif Lindholm >>>>> >>>>> Please let me just run this on the HW before merge - I'll do it tomorrow. >>>>> >>>> >>>> Sure. Note that you will need to sync EDK2 after I merged the DmaLib >>>> changes (which I will do today) >>> >>> Ok, please let know once it's available and also it would be great if >>> this patch could be shared via github repo. >>> >> >> The prerequisite patches for DmaLib are in EDK2 now. >> >> https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib > > Note that I just updated this branch to use NonCoherentDmaLib rather > than ArmDmaLib Network continues to work fine on Armada 7040 DB, so Tested-by: Marcin Wojtas