From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178])
 by mx.groups.io with SMTP id smtpd.web08.6565.1632314783471658544
 for <devel@edk2.groups.io>;
 Wed, 22 Sep 2021 05:46:23 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@semihalf-com.20210112.gappssmtp.com header.s=20210112 header.b=ZLZ86cxD;
 spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.222.178, mailfrom: mw@semihalf.com)
Received: by mail-qk1-f178.google.com with SMTP id q81so5452044qke.5
        for <devel@edk2.groups.io>; Wed, 22 Sep 2021 05:46:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=semihalf-com.20210112.gappssmtp.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=NoOt9sX+TkZKDpCO2xq/dpnlOGOVmNx4pAgsEWVfQYM=;
        b=ZLZ86cxDXnvtyZbRv7oJhAemYeOj1UDAL3CQ9oGlymjjl8CDK8mC9xxd2JB240g4I9
         93xWJF6DVbK8SFADlHwHKzYndKD8jSF7FCVNHkK8j8yc8RjSAoc5rqmjGIp9MI+dv+zJ
         xbyPhtAOcaHhRqYLcVFqTue6Q5SCPDot0v6a9g9R6WImMgxFaX/gRQCgfKt8TblR5Nxg
         8Z9NB5YQ28GrXDWwjvRGAZYekmllvhpRKseEq3/vgdk34SGS/JZTLHSfCylPoRyeoff2
         0VPsOrpZHjdZM+IvWhf/LlHHdJ9vZFNWTE2ofEqoM7NtRvJXR2vpCx4fCks7weylZsWd
         IS7w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=NoOt9sX+TkZKDpCO2xq/dpnlOGOVmNx4pAgsEWVfQYM=;
        b=TUzYc9sN+qU+VSyu6gFy0RkpB5/ZBF6WDOXIio+zta6aRiYSfbYWK3c0weanUgTgMO
         WIIrOLQSUgJw/sE30/9Bjy3NZd5KZ27dhTxWDX1bZUvOCB6Z3hXme6l1hbawvdZhL1+A
         upZGbmsMSfjVKn9EcexdIjEgumTVdI2gg7lA27syeBcQT5QWNqoNk5oMmNX3w6ibgVG+
         58kLkNli1nCm5VIWSluurNlPKeGUeVIhEvp1oLMPpEMfuC3toNDgrt/YQpoYx3/FQjjg
         FOoSPeuYYmhk1KorpjUEojpdvnHGZPu/Ryu27BrCseywStUL5jaPVLfcIkBNXIlR9itP
         LtVw==
X-Gm-Message-State: AOAM53100wd0ICo8NRkToX8fp0dok2pVwmjm7OMc4QWhY10aspY/xpDp
	otkIHtTGlOKVGyd3hq3/b32lboG41ja698AN34pzNg==
X-Google-Smtp-Source: ABdhPJyXqeAbVvuscsAXXQ2l6bpGDCbNQhvjzkXYJpqGNHVocMOkyyDjv9/Qcnf4ogacSXqErWN1tepptWf48rSTBPo=
X-Received: by 2002:a25:2d06:: with SMTP id t6mr46867178ybt.544.1632314782527;
 Wed, 22 Sep 2021 05:46:22 -0700 (PDT)
MIME-Version: 1.0
References: <20210921110056.659697-1-mw@semihalf.com> <CAMj1kXGhbtGC0T_MuOqcqTUw2YJ2LBfZq=h=FuZCc+sDTHCNCw@mail.gmail.com>
 <20210922121451.f7iyi76uca77wimp@leviathan> <CAMj1kXF6VO31SzzX5ov1ncuTA7ciU7jNcFN8ggW6Ccc1ZS5YjQ@mail.gmail.com>
In-Reply-To: <CAMj1kXF6VO31SzzX5ov1ncuTA7ciU7jNcFN8ggW6Ccc1ZS5YjQ@mail.gmail.com>
From: "Marcin Wojtas" <mw@semihalf.com>
Date: Wed, 22 Sep 2021 14:46:10 +0200
Message-ID: <CAPv3WKdCwNxq8=yFUhejuncDMQYfcJR8ii2bXsuKBBX5M1=8rg@mail.gmail.com>
Subject: Re: [edk2-platforms PATCH 0/4] Marvell readmes
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Grzegorz Jaszczyk <jaz@semihalf.com>, 
	Grzegorz Bernacki <gjb@semihalf.com>, Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, 
	Alon Rotman <alon.rotman@solid-run.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ard, Leif,

=C5=9Br., 22 wrz 2021 o 14:20 Ard Biesheuvel <ardb@kernel.org> napisa=C5=82=
(a):
>
> On Wed, 22 Sept 2021 at 14:14, Leif Lindholm <leif@nuviainc.com> wrote:
> >
> > On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> > > On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas <mw@semihalf.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > This short patchset adds README files for the platforms
> > > > based on Marvell SoC's, which have already been
> > > > SystemReady ES certified. It also bumps the firmware
> > > > revision after the PCI / IcuLib rework and addition of
> > > > the CN913x CEx7 Evaluation Board support.
> > > >
> > > > The patches are available on a public branch:
> > > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/ma=
rvell-howtos-upstream-r20210921
> > > >
> > >
> > > Thanks
> > >
> > > Pushed as 64394fd2b48f..d1d4dd2c39e7
> >
> > Ugh, wish I'd taken the time to respond yesterday.
> >
> > This is more proliferation of "include all very specific build
> > steps for a very specific target and build environment" documentation.
> >
> > I don't see this as an improvement.
> >
> > Platform docs should document what one needs to know specific to the
> > platform. If a vendor wishes to provide full recipes, they should host
> > that on a wiki somewhere.
> >
>
> Fair point.
>
> Marcin, when you find the time, could you please do a pass over these
> files with Leif's critique in mind?


For all 3 platforms, how about the following update:
- extend the "Summary" section with supported features or interfaces
(or add an extra heading for that).
- "Build" section -> add link to external wiki/.md file
- "ARM System Ready certification." - leave intact

Please let me know if that will work for you.

Best regards1,
Marcin