From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 11EC221959CB2 for ; Tue, 20 Nov 2018 02:30:48 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id x6so985642ioa.9 for ; Tue, 20 Nov 2018 02:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tf7ONWhRN6eA41MGF5bETnHfpeR7IoAJBSYtQszMhVg=; b=zGk80YBKXyfr3Yksi6IYnUaPR4v4XR5dJcKYlkt53enZnksTqtKuxXo/DHKnwul1JF TrhBv8hmx7jonaW4b3MDIIY44NHtyQqIAPSb/m49ztOmrGHd6XtNIZgl4ILKMxOZqzca mI0dOjSYXw3viBB3tqa5pfnXqanraLXW26OT20PXK3cyLHTSE3BTBgUjdp8y1YdvmZEZ PpxUXT5OeYVjaAoJci/xTzmf9gmnAYtB0n4O+CVTgTknpmNsBRwyjOPX75PUm+tj5FkW xBHP8Z9LQ2eppyknWrQ3vvw+E+NLnrt0jWl1BgNdEvWIXthOBITGlI7vf8GS8nPxWg/G qPHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tf7ONWhRN6eA41MGF5bETnHfpeR7IoAJBSYtQszMhVg=; b=T7mtD86rJddRLM2sW/Bt3gcdt3mY52/iCaCqOu6qUT8QfU4O6H55Q5CkkGeNFN9qN+ 6Tb0M96AcCRdKOR3TAt3DYW6yWZegskktfze3RgVDXDDro4Vp+COlv7bUxmCwpF151WA 1+6Ao8Mn9SanYQ0ftAmILTa0U68wg9PnELKSXWUuPyu4okjj3N7XWCj6ACxW11khdT2w Hl9VSBtnkdYfYGJ38Ghqzja9lbgJ0KseU2V1NkUlj7hGsNADZhbOxNvRmVTY79mEhJVo O8buDt0ZtLwvH/xDNXxzCx39O6lOSZeZzyLDkrxpMBrq/DS4ZK6xMCaJotaULLsLYXvA rSvQ== X-Gm-Message-State: AA+aEWaqUVx4D/g+piqxGxQES4TMRZi4OsdQBn5Cl2jHllJAU6kR4gyx jWVj17uLs/y5JIwNiQwHUV2czCcUlTDnZo4FwaFrYA== X-Google-Smtp-Source: AFSGD/UVveHG4mnIXzj3bMiSMfjxpC3ry0lUgCY/GfKZqvU8FsmMLKypqD6CgUFOfk6eEJadiGIUZ9yJ9sjfT27QDp0= X-Received: by 2002:a6b:92d6:: with SMTP id u205mr1114705iod.221.1542709847493; Tue, 20 Nov 2018 02:30:47 -0800 (PST) MIME-Version: 1.0 References: <1542610420-9258-1-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Tue, 20 Nov 2018 11:30:35 +0100 Message-ID: To: Ard Biesheuvel Cc: edk2-devel-01 , Leif Lindholm , hao.a.wu@intel.com, nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin , Tomasz Michalec Subject: Re: [platforms: PATCH v6 0/8] Armada7k8k Xenon driver rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 X-List-Received-Date: Tue, 20 Nov 2018 10:30:49 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks! Best regards, Marcin wt., 20 lis 2018 o 10:58 Ard Biesheuvel napisa= =C5=82(a): > > On Mon, 19 Nov 2018 at 07:54, Marcin Wojtas wrote: > > > > Hi, > > > > The sixth version of the patchset applies minor correction in the > > last patch and also simplifies the BoardDesc library callbacks. > > There is no unnecessary allocation now. > > > > Patches are available in the github: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits= /xenon-upstream-r20181119 > > > > Generic driver patches with fixes and extended SdMmcOverride protocol: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits= /sdmmc-override-upstream-r20181109 > > > > I'm looking forward to the comments and remarks. > > > > Best regards, > > Marcin > > > > Changelog: > > v5->v6: > > * 3,4,5 > > - pass the pointer to the static table directly instead of > > the copy allocation > > > > * 6/8 > > - remove freeing SdMmc board description structure in > > NonDiscoverableDevicesDxe, as from now on the static > > table will be used > > > > * 8/8 > > - change SdMmcOverride protocol comment to '#PRODUCES' > > - s/Controler/Controller/ > > - remove freeing board description structure > > > > v4->v5: > > * 1,2,6/8 > > - add Ard's RB > > > > * 2,3,4,5 > > - change parameters to OUT > > - assign count only after allocation is successful > > > > * 7/8 & 8/8 > > - split driver rework patches into two steps > > > > v3->v4: > > * 1/7: > > - add Ard's RB > > > > * 2/7: > > - use local enum definition for SlotType in order not to include MdeM= odulePkg > > private header > > > > * 7/7: > > - rework capability handling, without using the structure defined in = the > > MdeModulePkg header > > > > v2->v3 > > * 1/7: > > - rename NotifyPhase parameter to PhaseData > > > > * 7/7: > > - rename NotifyPhase parameter to PhaseData > > - update UHS_MODE_SEL only for HS200/HS400 > > in XenonSdMmcHcUhsSignaling > > - use local macros for standard SDHC registers in order not to > > include private MdeModulePkg header > > > > v1 -> v2 > > * 1/7 and 7/7 - adjust to modified SdMmcOverride > > NotifyPhase and Capability routines > > > > > > Marcin Wojtas (2): > > Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride > > Marvell/Drivers: XenonDxe: Remove SdMmcPciHcDxe files > > > > Tomasz Michalec (6): > > Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information > > SolidRun/Armada80x0McBin: Introduce board description library > > Marvell/Armada70x0Db: Introduce board description library > > Marvell/Armada80x0Db: Introduce board description library > > Marvell/Drivers: MvBoardDesc: Extend information for SdMmc > > Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe > > > > For the series > > Reviewed-by: Ard Biesheuvel > > Pushed as ce4f7528ed71..1360ddbc30e2 > > Thanks for > > 32 files changed, 1691 insertions(+), 7384 deletions(-) > > > > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc = | 3 +- > > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc = | 3 + > > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc = | 3 + > > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc = | 3 + > > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf = | 3 +- > > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoa= rdDescLib.inf | 34 + > > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoa= rdDescLib.inf | 34 + > > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80= x0McBinBoardDescLib.inf | 34 + > > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf = | 1 + > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/{SdMmcPciHcDxe.inf =3D> XenonDx= e.inf} | 33 +- > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.h = | 791 -------- > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.h = | 550 ------ > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.h = | 151 ++ > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.h = | 53 + > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h = | 131 +- > > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h = | 21 +- > > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoa= rdDescLib.c | 60 + > > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoa= rdDescLib.c | 60 + > > Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80= x0McBinBoardDescLib.c | 60 + > > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c = | 24 +- > > Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c = | 1 - > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/ComponentName.c = | 211 --- > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c = | 1164 ------------ > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c = | 1190 ------------ > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c = | 1320 -------------- > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.c = | 1928 -------------------- > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.c = | 321 ++++ > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c = | 429 +++++ > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c = | 408 +++-- > > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c = | 9 +- > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.uni = | 23 - > > Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxeExtra.uni = | 19 - > > 32 files changed, 1691 insertions(+), 7384 deletions(-) > > create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDesc= Lib/Armada70x0DbBoardDescLib.inf > > create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDesc= Lib/Armada80x0DbBoardDescLib.inf > > create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBo= ardDescLib/Armada80x0McBinBoardDescLib.inf > > rename Silicon/Marvell/Drivers/SdMmc/XenonDxe/{SdMmcPciHcDxe.inf =3D> = XenonDxe.inf} (65%) > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDx= e.h > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.= h > > create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.= h > > create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOv= erride.h > > create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDesc= Lib/Armada70x0DbBoardDescLib.c > > create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDesc= Lib/Armada80x0DbBoardDescLib.c > > create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBo= ardDescLib/Armada80x0McBinBoardDescLib.c > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/ComponentNam= e.c > > delete mode 100755 Silicon/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDx= e.c > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.= c > > create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.= c > > create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOv= erride.c > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDx= e.uni > > delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDx= eExtra.uni > > > > -- > > 2.7.4 > >