From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B7704210DBE68 for ; Mon, 6 Aug 2018 10:55:49 -0700 (PDT) Received: by mail-io0-x243.google.com with SMTP id g7-v6so1470742ioq.8 for ; Mon, 06 Aug 2018 10:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=q9mgo24dBdvWHMzqU3sGNRO9AWxws1OTwp06dmqUiTc=; b=PzYTBVJ9NPL3/xXunOo+AI9dkQtr4piQjzln+4Jz5eTqC9fixLKTjqSwQobH6YRqHQ GFp+LOMtz2oWromllZCQoMHoGPgjoWC0K9KKtRt8HdSAF0KmUTe8OyJwvc92p+7utB3D QXPK1INnO7V3sc3Q+WFx9vvoR7+/cDs5wDE0K5iUEKvdeiRbn3Hacq/EMf9PoilNPE1n IoZ+3/LAxz595kkUqyjg4hbxC54/JLzGzZxnakdhTVqwb+/7TRHZBASyekdgBnOZpwQs zOfVYdEUj51QW1brjTRfP4fzw74ukvdc/SCWXpgtkw0hZpAnMwCvZ7jvE781KlF1sxQF OJFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q9mgo24dBdvWHMzqU3sGNRO9AWxws1OTwp06dmqUiTc=; b=Bp2jJLafRfMcsybRQoLe5GS0UNm4T8lc1tNy398UdWb4TN8MDZRbBWpKjIytOhtq5R XgoWzvIDEC6wdO39pwQCKheLCAhCPPQVDIOyQ4w9ntY00y4q0yuXY0Ngnn1fdE+skio2 Lj+mI+Aep/O1GWBV6pkQglXLz3x5OFxMha4BMNuGnvs3GP/vdBO3G/DPomTJG54MQFpD Xp5bTTMaXftF/INU01SP6FZtLoL/4jTfhO/BTlVLHWpvCNj8ZrHlmwG37Ew0OYbvUPzt EEA0ZoNiKtZ9q9S3kciNhAR5EuSa5yifannAYZU9e4bs/Wdlb9XetTby9Oe5JWQKAl62 Xahg== X-Gm-Message-State: AOUpUlEg+pG8onXvrmXv5Vbgt/+HjJoB4lli0z0HMuy1ScYMYreiOzaB dTEF3FTKDi7Clpu6xUEQ4rIjDtzJdu00eFWeeTNdnh1A X-Google-Smtp-Source: AA+uWPygD6LpOcGscQ5xUOTi4LR3JQkXQdX5R36Gws/oqnWRP5b7Epr84712Yo55eyPVl+iNd/yG7aUJQOdMvIkpW/0= X-Received: by 2002:a6b:8e8d:: with SMTP id q135-v6mr1834743iod.248.1533578148679; Mon, 06 Aug 2018 10:55:48 -0700 (PDT) MIME-Version: 1.0 References: <1533511706-9344-1-git-send-email-mw@semihalf.com> <1533511706-9344-8-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Mon, 6 Aug 2018 19:55:35 +0200 Message-ID: To: Leif Lindholm Cc: Ard Biesheuvel , edk2-devel-01 , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk Subject: Re: [platforms: PATCH 7/9] Marvell/Armada70x0Db: Enable ACPI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 17:55:50 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable pon., 6 sie 2018 o 19:44 Leif Lindholm napisa=C5= =82(a): > > > > On Mon, 6 Aug 2018, 17:09 Ard Biesheuvel, wro= te: >> >> On 6 August 2018 at 18:08, Marcin Wojtas wrote: >> > HI Ard, >> > >> > pon., 6 sie 2018 o 13:54 Ard Biesheuvel na= pisa=C5=82(a): >> >> >> >> On 6 August 2018 at 01:28, Marcin Wojtas wrote: >> >> > This patch introduces DSDT table and adds necessary >> >> > wiring in order to enable ACPI support on Armada 7040 DB. >> >> > >> >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> >> > Signed-off-by: Marcin Wojtas >> >> > --- >> >> > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc = | 14 ++ >> >> > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc = | 3 + >> >> > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf = | 12 + >> >> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.inf = | 61 ++++++ >> >> > Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf.inc = | 5 + >> >> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl = | 229 ++++++++++++++++++++ >> >> > Silicon/Marvell/Documentation/PortingGuide.txt = | 22 ++ >> >> > 7 files changed, 346 insertions(+) >> >> > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x= 0Db/AcpiTables.inf >> >> > create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x= 0Db/Dsdt.asl >> >> > >> >> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silico= n/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> >> > index f1ccda0..d4c67a2 100644 >> >> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> >> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> >> > @@ -593,6 +593,20 @@ >> >> > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.in= f >> >> > !endif #$(INCLUDE_TFTP_COMMAND) >> >> > >> >> > +[Components.AARCH64] >> >> > + # >> >> > + # Generic ACPI modules >> >> > + # >> >> > + MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf >> >> > + MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf { >> >> > + >> >> > + PlatformHasAcpiLib|EmbeddedPkg/Library/PlatformHasAcpiLib/Pl= atformHasAcpiLib.inf >> >> > + >> >> > + >> >> > + # support ACPI v5.0 or later >> >> > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0= x20 >> >> > + } >> >> > + >> >> > [BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_= DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI= _APPLICATION] >> >> > GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 >> >> > >> >> > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platf= orm/Marvell/Armada70x0Db/Armada70x0Db.dsc >> >> > index d3dffb0..f6faff1 100644 >> >> > --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc >> >> > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc >> >> > @@ -51,6 +51,9 @@ >> >> > [Components.common] >> >> > Silicon/Marvell/Armada7k8k/DeviceTree/Armada70x0Db.inf >> >> > >> >> > +[Components.AARCH64] >> >> > + Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables.in= f >> >> > + >> >> > ##################################################################= ############## >> >> > # >> >> > # Pcd Section - list of all EDK II PCD Entries defined by this Pla= tform >> >> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Ma= rvell/Armada7k8k/Armada7k8k.fdf >> >> > index 909ad3e..c064a43 100644 >> >> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> >> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> >> > @@ -215,6 +215,12 @@ FvNameGuid =3D 5eda4200-2c5f-43cb-9da3= -0baf74b1b30c >> >> > # DTB >> >> > INF EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf >> >> > >> >> > +!if $(ARCH) =3D=3D AARCH64 >> >> > + # ACPI support >> >> > + INF MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.= inf >> >> > + INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf >> >> > +!endif >> >> > + >> >> > !include $(BOARD_DXE_FV_COMPONENTS) >> >> > >> >> > # PEI phase firmware volume >> >> > @@ -408,3 +414,9 @@ READ_LOCK_STATUS =3D TRUE >> >> > FILE FREEFORM =3D $(NAMED_GUID) { >> >> > RAW BIN |.dtb >> >> > } >> >> > + >> >> > +[Rule.Common.USER_DEFINED.ACPITABLE] >> >> > + FILE FREEFORM =3D $(NAMED_GUID) { >> >> > + RAW ASL |.aml >> >> > + RAW ACPI |.acpi >> >> > + } >> >> > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Acp= iTables.inf b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables= .inf >> >> > new file mode 100644 >> >> > index 0000000..8732e10 >> >> > --- /dev/null >> >> > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/AcpiTables= .inf >> >> > @@ -0,0 +1,61 @@ >> >> > +## @file >> >> > +# Component description file for PlatformAcpiTables module. >> >> > +# >> >> > +# ACPI table data and ASL sources required to boot the platform. >> >> > +# >> >> > +# Copyright (c) 2018, Linaro, Ltd. All rights reserved.
>> >> > +# Copyright (C) 2018, Marvell International Ltd. and its affiliat= es.
>> >> > +# >> >> > +# This program and the accompanying materials >> >> > +# are licensed and made available under the terms and conditions = of the BSD License >> >> > +# which accompanies this distribution. The full text of the lice= nse may be found at >> >> > +# http://opensource.org/licenses/bsd-license.php >> >> > +# >> >> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" = BASIS, >> >> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRE= SS OR IMPLIED. >> >> > +# >> >> > +## >> >> > + >> >> > +[Defines] >> >> > + INF_VERSION =3D 0x0001001A >> >> > + BASE_NAME =3D PlatformAcpiTables >> >> > + FILE_GUID =3D 7E374E25-8E01-4FEE-87F2-390C2= 3C606CD >> >> > + MODULE_TYPE =3D USER_DEFINED >> >> > + VERSION_STRING =3D 1.0 >> >> > + >> >> > +[Sources] >> >> > + Dsdt.asl >> >> > + ../Fadt.aslc >> >> > + ../Gtdt.aslc >> >> > + ../Madt.aslc >> >> > + ../Pptt.aslc >> >> > + ../Spcr.aslc >> >> > + >> >> >> >> Could we reshuffle these files so we nog longer rely relative include= s? >> >> Possibly using a Common subdirectory? >> > >> > Would below directory tree be acceptable? >> > >> > Silicon/Marvell/Armada7k8k/AcpiTables/ >> > =E2=94=9C=E2=94=80=E2=94=80 AcpiHeader.h >> > =E2=94=9C=E2=94=80=E2=94=80 Armada70x0Db >> > =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 Dsdt.asl >> > =E2=94=9C=E2=94=80=E2=94=80 Armada70x0Db.inf >> > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0Db >> > =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 Dsdt.asl >> > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0Db.inf >> > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0McBin >> > =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 Dsdt.asl >> > =E2=94=9C=E2=94=80=E2=94=80 Armada80x0McBin.inf >> > =E2=94=9C=E2=94=80=E2=94=80 Fadt.aslc >> > =E2=94=9C=E2=94=80=E2=94=80 Gtdt.aslc >> > =E2=94=9C=E2=94=80=E2=94=80 IcuInterrupts.h >> > =E2=94=9C=E2=94=80=E2=94=80 Madt.aslc >> > =E2=94=9C=E2=94=80=E2=94=80 Pptt.aslc >> > =E2=94=94=E2=94=80=E2=94=80 Spcr.aslc >> > >> > This way we will have following in the .inf >> > >> > Armada80x0McBin/Dsdt.asl >> > Fadt.aslc >> > Gtdt.aslc >> > Madt.aslc >> > Pptt.aslc >> > Spcr.aslc >> > >> >> Works for me. Leif? > > > Sure. > Ok, I will submit this change, once the remaining patches are reviewed. Best regards, Marcin