From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A3D97211B5A5E for ; Mon, 14 Jan 2019 21:48:16 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id m8so192614itk.0 for ; Mon, 14 Jan 2019 21:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=v/1nsiTug9uYQTO+inKaxbzQW8CBjkQ0G/xoxnP8/rc=; b=MxZHx7GyZpToO0s79ULx7oRDDOQq6PRCA9dsT88khcbbkyu6m99KMswdqOqDirLf7T WKtpGrD0YvPffJjQn20cqVIxW4CDsj3pqGqbdSIFDBMB/ROsy99p0IIZ2jpxE99c36ys CHWcMsClimBK7qdWzdo9MIIu7Lp4A9hRHcJUddul+Ax/ZffxcKPN12Sh9rjQzTj4Z0PA n37Knj6XqXObb19FcErtP5ugQaKvS3EkUfCvEbGRqOKReRjtm+sL3ChYOfiD1dJ3fOV3 BAe0YH3/dIRN7sscXTJu2oDKRD1FQpCmcdidLmmQEcilTpKq94VSpjfQubZZIqWEqjew wILw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=v/1nsiTug9uYQTO+inKaxbzQW8CBjkQ0G/xoxnP8/rc=; b=Ovj/M5QGZabfoUBvH2aYZ5+jwzLnmizGlfiT7qDAH0qcMDXuKrSQn6pPl+vbV0G7v1 doQaknSiHec8M2NZVwx5ynOfqaUnKEjMmN/vIlvQyZBLUNP0vcSi/+oQ8Gs3bUyRaDUs aLKvUJo6wwOTokxhDqkI58b6yM/4AlAhn8P4OBWjKp2iWRsviH//tUc/8gEOMLlo1aD+ f/kwWc78QBfVi/ksMGed91s3UjFcgIrbM+gIg6u33AW7a45wKct2MVfWX3f64N+TbT8f Jy+i12W1ek6YeTse+CYD4syCbUOkJ9482NQd2qTguvO1GW/aQOztNUh8Q63sJZ9jyda6 hvQw== X-Gm-Message-State: AJcUukcWbFYxTUH6NGZ+S6T5YXnfHYohmtzLQmatMA9PQpZNhuEDXi2C SjgOthlrtT3lF1Mkg05qqUyCGjEEYTlQBvKVU+aIIQ== X-Google-Smtp-Source: ALg8bN40nE4Znoh9BUvDMBERQNDFZxa4LL0UGGDYLGpT165VbaPGTwshzHBJlTJQbygOt3J3u3l5S5IcrJcs8lhkivs= X-Received: by 2002:a24:eb0b:: with SMTP id h11mr1625007itj.138.1547531295704; Mon, 14 Jan 2019 21:48:15 -0800 (PST) MIME-Version: 1.0 References: <1547084679-29597-1-git-send-email-mw@semihalf.com> <1547084679-29597-5-git-send-email-mw@semihalf.com> <20190114224111.vejwqebch3owpnwm@bivouac.eciton.net> In-Reply-To: <20190114224111.vejwqebch3owpnwm@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 15 Jan 2019 06:48:06 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Subject: Re: [platforms: PATCH v2 04/12] Marvell/Armada70x0Db: Extend board description library with GPIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 05:48:16 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, pon., 14 sty 2019 o 23:41 Leif Lindholm napisa= =C5=82(a): > > On Thu, Jan 10, 2019 at 02:44:31AM +0100, Marcin Wojtas wrote: > > This patch implements ArmadaBoarDescLib library for > > Armada70x0Db comunity board and introduces ArmadaBoardGpioGet > > routine with per-board GPIO expander description. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marcin Wojtas > > --- > > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoa= rdDescLib.inf | 1 + > > Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoa= rdDescLib.c | 25 ++++++++++++++++++++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Arm= ada70x0DbBoardDescLib.inf b/Platform/Marvell/Armada70x0Db/Armada70x0DbBoard= DescLib/Armada70x0DbBoardDescLib.inf > > index b26f55b..c995515 100644 > > --- a/Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0= DbBoardDescLib.inf > > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0= DbBoardDescLib.inf > > @@ -25,6 +25,7 @@ > > Armada70x0DbBoardDescLib.c > > > > [Packages] > > + EmbeddedPkg/EmbeddedPkg.dec > > MdeModulePkg/MdeModulePkg.dec > > MdePkg/MdePkg.dec > > Silicon/Marvell/Marvell.dec > > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Arm= ada70x0DbBoardDescLib.c b/Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDe= scLib/Armada70x0DbBoardDescLib.c > > index 48c68e4..f63d8fd 100644 > > --- a/Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0= DbBoardDescLib.c > > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0= DbBoardDescLib.c > > @@ -21,6 +21,31 @@ > > #include > > #include > > > > +#include > > + > > +// > > +// GPIO Expander > > +// > > +STATIC MV_GPIO_EXPANDER mGpioExpander =3D { > > + 8, /* PCA9555 */ > > Why did you drop the use of the still existing enumeration in favour > of live coding the integer value that it currently produces for the > member PCA9555_ID? > As you noticed, I 'fixed' it in 10/12 - otherwise compilation for this board would be temporarily broken. I will split add MvGpio header with the enum before this one. Best regards, Marcin > / > Leif > > > + 0x21, > > + 0x0, > > +}; > > + > > + > > +EFI_STATUS > > +EFIAPI > > +ArmadaBoardGpioExpanderGet ( > > + IN OUT MV_GPIO_EXPANDER **GpioExpanders, > > + IN OUT UINTN *GpioExpanderCount > > + ) > > +{ > > + *GpioExpanderCount =3D 1; > > + *GpioExpanders =3D &mGpioExpander; > > + > > + return EFI_SUCCESS; > > +} > > + > > // > > // Order of devices in SdMmcDescTemplate has to be in par with ArmadaS= oCDescLib > > // > > -- > > 2.7.4 > >