Re: [edk2-devel] [edk2-platforms: PATCH v2 06/10] Marvell/Library: MppLib: Allow to configure more Xenon PHYs

["Marcin Wojtas" <mw@semihalf.com>]

Hi Leif,

pt., 16 sie 2019 o 19:36 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> On Thu, Aug 15, 2019 at 04:54:10AM +0200, Marcin Wojtas wrote:
> > Hitherto MppLib code assumed that there could be only two
> > Xenon SdMmc controllers' PHYs. Remove this limitation, so that to
> > support CN913x SoCs, which may have up to 4 of such interfaces.
>
> Should this be merged with the preceding patch?
>

Yes it could - I will squash both patches.

Thanks,
Marcin

> /
>     Leif
>
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  Silicon/Marvell/Library/MppLib/MppLib.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Library/MppLib/MppLib.c b/Silicon/Marvell/Library/MppLib/MppLib.c
> > index 40d9077..f20668d 100644
> > --- a/Silicon/Marvell/Library/MppLib/MppLib.c
> > +++ b/Silicon/Marvell/Library/MppLib/MppLib.c
> > @@ -139,11 +139,9 @@ SetSdMmcPhyMpp (
> >    case 0:
> >      Offset = SD_MMC_PHY_AP_MPP_OFFSET;
> >      break;
> > -  case 1:
> > +  default:
> >      Offset = SD_MMC_PHY_CP0_MPP_OFFSET;
> >      break;
> > -  default:
> > -    return;
> >    }
> >
> >    /*
> > --
> > 2.7.4
> >
> >
> > 
> >