From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by mx.groups.io with SMTP id smtpd.web11.2609.1578049490261955155 for ; Fri, 03 Jan 2020 03:04:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=sR/5JaTm; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.222.179, mailfrom: mw@semihalf.com) Received: by mail-qk1-f179.google.com with SMTP id t129so33434088qke.10 for ; Fri, 03 Jan 2020 03:04:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=c1SXsxhcxI92oTDVAj9IkVYLEWnxb8M1iO4xgR6JWi0=; b=sR/5JaTmaMIoPhndYRwVGkTCL5dWOkXMG0HC9Uoq/NOrnad+gXkWu8FnQ7I6kju2/J u+EFJ4E2kvwc57WoRiuWPCxpBhPGlG3ltTXJx+L/LpoN//eWx3InTaLsYwQJbFcE+LR9 eAIy7u09zn3ktp48y4XENwbjcn9/iB/KRzTtl3FGimF6P2Pc+56Sl8uEI62RzUrDaYlg vUL2VbQS5uSi7ZFdFyw6nx+kK7hTSh9NQXF6IUuzTBU5iL1FCokEt6oKLYFwte0dEiy3 DbnqNDMQnEp2XYSXP37QmRUKw2n1jqB3k057is+eSkEgpwqVdoP4MCit5oleKypn21Xa ZFpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c1SXsxhcxI92oTDVAj9IkVYLEWnxb8M1iO4xgR6JWi0=; b=N5jzjzCzqiomU7AOGDAeTuNqNDOgHwptJUvo0+Zod1Yox51Z7FhctYtTwJXJJfCsDH xUDWoPpPgGTTbpH0XlUuigGj7ohJ8We4hIHubOHvAhwnDfS4oHLWGM69xeXBBxoduZj1 WNIR7pMk9Vvf19KmVpMHgENZin0ibqBPsBMFyIIwZ5tqA7q1wkMjZXSTJF72mCtQVOpB Ca3ARF2v7AvZ3EXDp4alVkfqkop6zlvw8tEiBlUCi6+EtyR9wcY52DYYR17nV7mbSufg WxDZW/HhcA1VartRMf12mMrYfZLK7z2EDzy+TVim9vJT4H8oCWa0ZzQb0syEu+aGuMgF OeIA== X-Gm-Message-State: APjAAAWUuIOCX87Vz4CDI096rAotYtaPtoUS6mMWVeDYX6jLInkYUnaj dPYadiciZemMoGCwzwCkHNqOsOI8ODU1TETUva6Q+A== X-Google-Smtp-Source: APXvYqy69A60LCUNv1dfyV3hUwwQIKWrR/l8kwsnbVtlt4qQq2mKyzM5LybGxEOgfiLpNjWlUgpqvDZGVC1UO6iSj/w= X-Received: by 2002:a37:6716:: with SMTP id b22mr68836176qkc.109.1578049489285; Fri, 03 Jan 2020 03:04:49 -0800 (PST) MIME-Version: 1.0 References: <20191220171312.3120-1-mateusz.albecki@intel.com> In-Reply-To: From: "Marcin Wojtas" Date: Fri, 3 Jan 2020 12:04:36 +0100 Message-ID: Subject: Re: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the EdkiiSdMmcSwitchClockFreq notification before sending CMD13 To: "Wu, Hao A" Cc: "Albecki, Mateusz" , "devel@edk2.groups.io" , "Gao, Zhichao" , "Gao, Liming" , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, wt., 24 gru 2019 o 03:52 Wu, Hao A napisa=C5=82(a): > > > -----Original Message----- > > From: Albecki, Mateusz > > Sent: Saturday, December 21, 2019 1:13 AM > > To: devel@edk2.groups.io > > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Limi= ng > > Subject: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the > > EdkiiSdMmcSwitchClockFreq notification before sending CMD13 > > > > The first patch refactors the SdMmcClockSupply function with a goal > > of sending the EdkiiSdMmcSwitchClockFreq notification before we send th= e > > CMD13 to check the switch status in eMMC init flow. This is required to > > avoid sending the CMD13 on link that still has not been fixed by platfo= rm. > > > > To avoid changing the driver behavior we avoid sending notifications > > when the clock is setup for the first time or when we setup the clock > > after the voltage switch procedure(adressed in second patch). > > > > The second patch in the series optimizes the SD card detection routine > > to stop it from going through the process of internal clock setup > > after switching the voltage. According to SD HC specification there > > is no need to setup internal clock all over again. > > > > Tests performed: > > - Booted eMMC in HS400 mode on platform which required post clock freq > > fixes > > > > I wasn't able to test SD card yet due to the lack of setup with working= SD. > > > I performed a quick verification on the eMMC device and SD card on my sid= e. > They work properly after the series. > > So for the series, > Tested-by: Hao A Wu > I verified eMMC HS200 / HS@50MHz and SD cards on 2 Armada platforms, so: Tested-by: Marcin Wojtas Best regards, Marcin > > > > > The patch series is available on github here: > > https://github.com/malbecki/edk2/tree/sdmmc_post_freq_notify > > > Add Ard to the loop to see if there is additional comment. > > Best Regards, > Hao Wu > > > > > > Cc: Hao A Wu > > Cc: Marcin Wojtas > > Cc: Zhichao Gao > > Cc: Liming Gao > > > > Mateusz Albecki (2): > > SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start > > MdeModulePkg/SdMmcPciHcDxe: Add function to start SD clock > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 20 +-- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 25 +--- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 24 ++++ > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 136 > > +++++++++++---------- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 45 ++----- > > 5 files changed, 112 insertions(+), 138 deletions(-) > > > > -- > > 2.14.1.windows.1 >