From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by mx.groups.io with SMTP id smtpd.web08.9159.1626087123380059339 for ; Mon, 12 Jul 2021 03:52:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=hBTHn3cz; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.173, mailfrom: mw@semihalf.com) Received: by mail-qt1-f173.google.com with SMTP id r17so2620709qtp.5 for ; Mon, 12 Jul 2021 03:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YUrl+dxQYDycnKypqddTH26xnlpkU1Xg4z+89bg9mQo=; b=hBTHn3cz+qmyQLj/NXCcvSWR5VMTn1r+bp/Llstse15Ifz1drk/HZUe4r5bruI9AEy m1uSYhJ8+SALPA01kPp2WVzKClY32v226RBGWZR5zEfYv+PJkZzqsHZjNA5PNmzHEvb6 1angWtr0tWTQy2KbhCk7wQMBItnunsofbPdRJFpS9aPfb/rQDC5hASCw+ksp10TxV+TA PYYwlLEXoYQJqo2PG3S3fmw/+iYq2PeykR0mjnADI5T9EwJBWuZn4NGxTvuvvLVelQpY NYV7Oxx/LzR1EmvUlyH8qi3+ZR4+9TAn8D1cfaxYmW8tzMjqRBM2+TxgZtqQENHDXgDU 3IVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YUrl+dxQYDycnKypqddTH26xnlpkU1Xg4z+89bg9mQo=; b=WzL7RbA8qSy17T62DOABZhFSdtdB1ztEaCo5Fw9DPUBosXGjzhqF5QQmxgNSgf6qgX s7+93LBZXb5m4vC4umjO+lGVvorTXFbONIAglY/ZgMr14VtA8Vtdo5QVhesja+KQQ6Ge dAN+TTTsjGfsb/mWcbjv8UjZBv2WzOSyD+nKuRPij8y4S9ancjJGJV19oD7uG8yLCugS NEYffhRdZVI+oFzheTDDrVnzLN1qeGpmO/GROZeoEQhY67YRnGKd820vzPtjlpOkxX66 pPk3b9T7MHf0OrRSbhZZhxE+x1Yno3cqb0uyp8fPxqm3uEw2sYgBDVclkrpw9bw0jjYi n6rw== X-Gm-Message-State: AOAM530XlvgRLKYuhvDWS4K9IsWhK9XINNbSZwWgucck9/A4Xxl4MMOz F9wtuhC54smeHaYSl5TBbqqv4h5LUaRJn/oGm8mrSQ== X-Google-Smtp-Source: ABdhPJzbSsVpaFMRkc6JFiQvW/YtsE4Grxxs4+JGk80pFu73OktSwZyuyRI0LvlG0gb2d2P8Iw4DhrsIb+idB/4kcAQ= X-Received: by 2002:ac8:44c2:: with SMTP id b2mr20831213qto.216.1626087122395; Mon, 12 Jul 2021 03:52:02 -0700 (PDT) MIME-Version: 1.0 References: <20210613181631.2247221-1-mw@semihalf.com> <20210614215540.u2y4oc2s4cvs6kxw@leviathan> In-Reply-To: From: "Marcin Wojtas" Date: Mon, 12 Jul 2021 12:51:50 +0200 Message-ID: Subject: Re: [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs To: Leif Lindholm , Ard Biesheuvel Cc: edk2-devel-groups-io , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud , Jon Nettleton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, wt., 29 cze 2021 o 16:17 Marcin Wojtas napisa=C5=82(a): > > Hi Leif, > > pon., 14 cze 2021 o 23:55 Leif Lindholm napisa=C5=82(= a): > > > > Hi Marcin, > > > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > > Hi, > > > > > > The MDIO ACPI binding has been established and merged to the > > > Linux tree, > > > > Congratulations! :) > > > > Is FreeBSD expected to follow suit? > > There's no driver yet, but once it's finally created I will make sure > it supports ACPI properly. > > > > > > hence it is now possible to update the ACPI > > > description of the platforms that base on the Marvell SoCs. > > > > > > For convenience, the code is exposed in the public github branch: > > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/acpi= -mdio-r20210613 > > > There is also MacchiatoBin firmware binary avaialable for testing: > > > https://drive.google.com/file/d/1eigP_aeM4wYQpEaLAlQzs3IN_w1-kQr0 > > > > > > I'm looking forward to the comments or remarks. > > > > The patches themselves look straightforward enough. > > I *would* prefer some tested-by, for these sources rather than the > > binary, before merging though. > > > > I have some our patches queued, that are blocked by this patchset. In > case no time is found for external testers - if this may help to get > it pushed through, please see below logs from the next-20210628 tag > and unchanged firmware. All network ports of MacchiatoBin and > CN913x-DB work properly, with full 1G/10G PHY support via X/MDIO > interfaces: > > MacchiatoBin > # uname -a > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > 09:14:07 CEST 2021 aarch64 GNU/Linux > # dmesg | grep MRVL0101 > [ 1.829659] mv88x3340 MRVL0101:00-mii:00: Firmware version 0.3.3.0 > [ 1.839622] mv88x3340 MRVL0101:00-mii:08: Firmware version 0.3.3.0 > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] driver > [mv88x3340] (irq=3DPOLL) > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] driver > [mv88x3340] (irq=3DPOLL) > # dmesg | grep MRVL0100 > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] driver > [Marvell 88E1510] (irq=3DPOLL) > # dmesg | grep mvpp2 > [...] > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] driver > [mv88x3340] (irq=3DPOLL) > [ 2.756701] mvpp2 MRVL0110:00 eth1: configuring for phy/10gbase-r link= mode > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] driver > [mv88x3340] (irq=3DPOLL) > [ 2.775834] mvpp2 MRVL0110:01 eth2: configuring for phy/10gbase-r link= mode > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] driver > [Marvell 88E1510] (irq=3DPOLL) > [ 2.928285] mvpp2 MRVL0110:01 eth3: configuring for phy/sgmii link mod= e > [ 2.936351] mvpp2 MRVL0110:01 eth4: configuring for > inband/2500base-x link mode > [ 5.987259] mvpp2 MRVL0110:01 eth3: Link is Up - 1Gbps/Full - flow > control off > # > > CN913x-DB > # uname -a > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 > 09:14:07 CEST 2021 aarch64 GNU/Linux > # dmesg | grep MRVL0100 > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] driver > [Marvell 88E1510] (irq=3DPOLL) > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] driver > [Marvell 88E1510] (irq=3DPOLL) > # dmesg | grep mvpp2 > [...] > [ 2.544917] mvpp2 MRVL0110:00 eth1: configuring for > inband/10gbase-r link mode > [ 2.552480] mvpp2 MRVL0110:00 eth1: Link is Up - 10Gbps/Full - flow > control rx > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] driver > [Marvell 88E1510] (irq=3DPOLL) > [ 2.630060] mvpp2 MRVL0110:00 eth2: configuring for phy/rgmii-id link = mode > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] driver > [Marvell 88E1510] (irq=3DPOLL) > [ 2.750056] mvpp2 MRVL0110:00 eth3: configuring for phy/rgmii-id link = mode > [ 2.810169] mvpp2 MRVL0110:01 eth4: configuring for > inband/10gbase-r link mode > [ 2.817471] mvpp2 MRVL0110:01 eth4: Link is Up - 10Gbps/Full - flow > control rx > [ 5.693231] mvpp2 MRVL0110:00 eth2: Link is Up - 1Gbps/Full - flow > control off > [ 10.840942] mvpp2 MRVL0110:00 eth1: Link is Down > [ 10.864124] mvpp2 MRVL0110:01 eth4: Link is Down > # > Both platforms were have been additionally tested by Greg, do you have any comments/objections to merging this patchset? Thanks, Marcin