Re: [edk2-platforms: PATCH v3 9/9] Marvell: Customize per-board SBMIOS strings

["Marcin Wojtas" <mw@semihalf.com>]

Hi Leif,

pt., 11 paź 2019 o 01:07 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> On Thu, Oct 10, 2019 at 07:42:19AM +0200, Marcin Wojtas wrote:
> > Now that the customization of Type1/2/3 SBMIOS
> > tables strings is possible, adjust them for all
> > supported boards.
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc        |  4 ++++
> >  Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc        |  4 ++++
> >  Platform/Marvell/Cn913xDb/Cn913xDbA.dsc               | 11 +++++++++++
> >  Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc |  5 +++++
> >  4 files changed, 24 insertions(+)
> >
> > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> > index 523e60e..3626967 100644
> > --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> > @@ -45,6 +45,10 @@
> >  #
> >  ################################################################################
> >  [PcdsFixedAtBuild.common]
> > +  #Platform description
> > +  gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 7040 DB\0"
> > +  gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.5\0"
>
> Why have we ended up requiring explicit \0 in literal strings?
> This does not seem to be needed for (for example)
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor
> so why is it needed here?
>

Indeed, works fine without it - will be removed in v4.

Thanks,
Marcin


> > +
> >    #CP110 count
> >    gMarvellTokenSpaceGuid.PcdMaxCpCount|1
> >
> > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > index 4e6e62b..ce0c541 100644
> > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> > @@ -45,6 +45,10 @@
> >  #
> >  ################################################################################
> >  [PcdsFixedAtBuild.common]
> > +  #Platform description
> > +  gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 DB\0"
> > +  gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.4\0"
> > +
> >    #MPP
> >    gMarvellTokenSpaceGuid.PcdMppChipCount|3
> >
> > diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> > index 268c39c..bcc5158 100644
> > --- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> > +++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> > @@ -62,3 +62,14 @@
> >    ArmadaBoardDescLib|Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9130DbABoardDescLib.inf
> >  !endif
> >    NonDiscoverableInitLib|Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.inf
> > +
> > +[PcdsFixedAtBuild.common]
> > +  #Platform description
> > +  !if $(CN9130)
> > +  gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9130 DB-A\0"
> > +  !elseif $(CN9131)
> > +  gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9131 DB-A\0"
> > +  !elseif $(CN9132)
> > +  gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9132 DB-A\0"
> > +  !endif
> > +  gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.1\0"
> > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> > index 2b42d75..f7d5a57 100644
> > --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> > @@ -46,6 +46,11 @@
> >  #
> >  ################################################################################
> >  [PcdsFixedAtBuild.common]
> > +  #Platform description
> > +  gMarvellTokenSpaceGuid.PcdProductManufacturer|"SolidRun\0"
> > +  gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 MacchiatoBin\0"
> > +  gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.3\0"
> > +
> >    #MPP
> >    gMarvellTokenSpaceGuid.PcdMppChipCount|3
> >
> > --
> > 2.7.4
> >