From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by mx.groups.io with SMTP id smtpd.web10.3828.1570749374242982042 for ; Thu, 10 Oct 2019 16:16:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=KGIu63nF; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.222.194, mailfrom: mw@semihalf.com) Received: by mail-qk1-f194.google.com with SMTP id h126so7198361qke.10 for ; Thu, 10 Oct 2019 16:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AF4TGGnZz4h8nngsvfbKgjzAxwEydMytLCrsQf2RR9c=; b=KGIu63nFKYPdF0wiO4n4OUv+VGsGJgdu5uIh06kgucrvebgPy3sP+H6ozLjz3l4BX0 k4B9jNLTTBtvsKLnr1kvqHWpxrgkpKv+vClXmP+I/nirwvEMIJqeiTMk+qCHNFo0FIvs o+mFzNZF4M57ejFmGKBUYJ7dCyZhIA51lBCcFbX/3jFoB0Kxz9Fd4hvbxSiuG3BE3ezR qV1opO5x9ySA6QRyKe8rMfc69U0jkdB2YiFCteIb5bg4ktWHKJxdnoYT2RGEefYl8DXH N9RZvsyxdgl7Akqvs15aTWny0wlr2xOCC8WELt2rlrlGDIP8wp/IUNKcn0T7Fk1n4bUH HgKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AF4TGGnZz4h8nngsvfbKgjzAxwEydMytLCrsQf2RR9c=; b=Zjhvg+t44BUY1GAFfLJzlzfyzeqXE0QklbZee34MBSPLyiVNB/C0nSxM6BApYZwK68 8mmPwYOg98oMBJdFAv0ICccSUvYMfG2lpPofwXvLEpFyqbsCf254622o6tngKWuIMahX uHuYF4b0FfA/RPLJz4yQ7YWLNEtFpNGWnj4g8JDHL+PrW6QxpwqVtWfkJglRDUPgdOOh udtKicKwh52RtQ2f40usVEFdtqNJB/ZObcbfr77k+V7jJPOkSUaqNPwJT7X4EZBj48xJ j63dVw/yoBxaRps7jmDtdd3gOyDW1glkQTf8nMpBU42TcKm+lSqKj0Jz00FkWyHWIQpL fK9Q== X-Gm-Message-State: APjAAAX9r6s9nrzUPIUpxiuOD1UFjzowmICyBu4naNVTTw/QJT9BMIWX gx3zccEClXLpJ08QsiFCJMvOEnW0TfaHgGnH793BPQ== X-Google-Smtp-Source: APXvYqx53WzngFvUBcXd8AthNb9dbbrluJCjzTZBQLAqyaROb+wiC7KLbakxhidG1js/h+tj4Q3PXOHmlx7y9JImDVo= X-Received: by 2002:a37:b402:: with SMTP id d2mr12426113qkf.342.1570749373205; Thu, 10 Oct 2019 16:16:13 -0700 (PDT) MIME-Version: 1.0 References: <1570686139-25182-1-git-send-email-mw@semihalf.com> <1570686139-25182-10-git-send-email-mw@semihalf.com> <20191010230750.GY25504@bivouac.eciton.net> In-Reply-To: <20191010230750.GY25504@bivouac.eciton.net> From: "Marcin Wojtas" Date: Fri, 11 Oct 2019 01:16:04 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH v3 9/9] Marvell: Customize per-board SBMIOS strings To: Leif Lindholm Cc: edk2-devel-groups-io , Ard Biesheuvel , "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, pt., 11 pa=C5=BA 2019 o 01:07 Leif Lindholm napi= sa=C5=82(a): > > On Thu, Oct 10, 2019 at 07:42:19AM +0200, Marcin Wojtas wrote: > > Now that the customization of Type1/2/3 SBMIOS > > tables strings is possible, adjust them for all > > supported boards. > > > > Signed-off-by: Marcin Wojtas > > --- > > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 ++++ > > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 ++++ > > Platform/Marvell/Cn913xDb/Cn913xDbA.dsc | 11 +++++++++++ > > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 5 +++++ > > 4 files changed, 24 insertions(+) > > > > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/= Marvell/Armada70x0Db/Armada70x0Db.dsc > > index 523e60e..3626967 100644 > > --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > > @@ -45,6 +45,10 @@ > > # > > ######################################################################= ########## > > [PcdsFixedAtBuild.common] > > + #Platform description > > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 7040 DB\0" > > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.5\0" > > Why have we ended up requiring explicit \0 in literal strings? > This does not seem to be needed for (for example) > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor > so why is it needed here? > Indeed, works fine without it - will be removed in v4. Thanks, Marcin > > + > > #CP110 count > > gMarvellTokenSpaceGuid.PcdMaxCpCount|1 > > > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/= Marvell/Armada80x0Db/Armada80x0Db.dsc > > index 4e6e62b..ce0c541 100644 > > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > @@ -45,6 +45,10 @@ > > # > > ######################################################################= ########## > > [PcdsFixedAtBuild.common] > > + #Platform description > > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 DB\0" > > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.4\0" > > + > > #MPP > > gMarvellTokenSpaceGuid.PcdMppChipCount|3 > > > > diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell= /Cn913xDb/Cn913xDbA.dsc > > index 268c39c..bcc5158 100644 > > --- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > > +++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > > @@ -62,3 +62,14 @@ > > ArmadaBoardDescLib|Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9= 130DbABoardDescLib.inf > > !endif > > NonDiscoverableInitLib|Platform/Marvell/Cn913xDb/NonDiscoverableInit= Lib/NonDiscoverableInitLib.inf > > + > > +[PcdsFixedAtBuild.common] > > + #Platform description > > + !if $(CN9130) > > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9130 DB-A\0" > > + !elseif $(CN9131) > > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9131 DB-A\0" > > + !elseif $(CN9132) > > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9132 DB-A\0" > > + !endif > > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.1\0" > > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc b/Pl= atform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > > index 2b42d75..f7d5a57 100644 > > --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > > @@ -46,6 +46,11 @@ > > # > > ######################################################################= ########## > > [PcdsFixedAtBuild.common] > > + #Platform description > > + gMarvellTokenSpaceGuid.PcdProductManufacturer|"SolidRun\0" > > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 Macchiato= Bin\0" > > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.3\0" > > + > > #MPP > > gMarvellTokenSpaceGuid.PcdMppChipCount|3 > > > > -- > > 2.7.4 > >