From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0B7C221A07A80 for ; Thu, 8 Nov 2018 03:55:15 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id t190-v6so1135886itb.2 for ; Thu, 08 Nov 2018 03:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vEv89+W7GHo19+0yP9aXAz4uJIt6rl4uwP8Fy1sHTbU=; b=MrSDnS0omKODo4sgSSPcb6JIer3h6d0iML1ZeZwo3vGT9ywOZvABe9R0/AF8NKQImW CwODVqF3206tt2peHvYwGxwAGnHTA74DrbsuWolmQD1IOtLBTct3W0H8D7I93Dhq38gD XU8xhebMpwjnja6kft9YvJHc0S9Z623IHIhFuaGnkjwMHmtQ21IVqWHSRDoFNWZGWGDt TO5mtoszkRmbeW8GpyCeo8o5K5KhHAfFzdQdnbw+xE2l+l79f77LWmeOn6yWZB4cjml0 9hOxdGd0Wo5DF2szK0vc3HFu5B01OQhgMZ6XR/ksgfISBVuajjEydNlO7w6UU7l55ET7 l3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vEv89+W7GHo19+0yP9aXAz4uJIt6rl4uwP8Fy1sHTbU=; b=eHxm8PrV0O7awHhxacQQo4J1TQSvFW5xqB0NjjFn9Uxu109ML2SRvDGOgyCf4O6yeu gXAy09rbwCEJNhU2jR5B4GkDlv5uHFCEMUSSdPgZX2/d+M4YKjcRRk35hVnRTP2w0Iww KHLjBvcCK0phJm0sh4HdvvOOj7Q8qRsBM3gNte9CC+zjfgU00YBSJHMc24THZ2kduoce 2WZliNE6sIoLu8+xE8JsEiVenfyR5z7ixsGDLrY2U7/2XiaRLdxklnZ9BwyMApp4rdaN tZqod4gFLBW4woD7ohX+AiAb5iIb0jx9VR+wAt8txs84iSmmqr0Ehs5mCJTtrJr+Jxzj mYvQ== X-Gm-Message-State: AGRZ1gKvGgzcuTlEXgfFtP2fv39qfH6q8Tpuzv+8hen8qoI9KqOqDdLa +MbC8K5Z+UWUr8qDwJpt9kfK4JYYc8QMFwb/QWRe5Q== X-Google-Smtp-Source: AJdET5eAA1x412QBKQ0Yc3jzMK+haauG9LS3+ROa1yKR1oJsv0HrrTWu2RU24bmchwebtJAuTnA6NzKjZv4+YakQHtI= X-Received: by 2002:a02:41d2:: with SMTP id n79-v6mr3829329jad.112.1541678115266; Thu, 08 Nov 2018 03:55:15 -0800 (PST) MIME-Version: 1.0 References: <1541642266-15643-1-git-send-email-mw@semihalf.com> <1541642266-15643-3-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Thu, 8 Nov 2018 12:55:04 +0100 Message-ID: To: Ard Biesheuvel Cc: edk2-devel-01 , Leif Lindholm , hao.a.wu@intel.com, nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin , Tomasz Michalec Subject: Re: [platforms: PATCH v3 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 11:55:16 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable czw., 8 lis 2018 o 12:47 Ard Biesheuvel napisa= =C5=82(a): > > On 8 November 2018 at 02:57, Marcin Wojtas wrote: > > From: Tomasz Michalec > > > > Added fields specific for Xenon host controller and declaration > > of ArmadaBoardDescSdMmcGet function. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marcin Wojtas > > --- > > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 17 ++++++++++++= ++++- > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Sil= icon/Marvell/Include/Library/ArmadaBoardDescLib.h > > index ee8e06e..4bb7a43 100644 > > --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > @@ -14,6 +14,8 @@ > > #ifndef __ARMADA_BOARD_DESC_LIB_H__ > > #define __ARMADA_BOARD_DESC_LIB_H__ > > > > +#include > > + > > I don't like this at all. We are depending on an internal header of a > certain implementation. Please find a better way to share these > definitions. > Sure, forgot about this one. I will use a local enum for the SlotType, which will be equivalent to EFI_SD_MMC_SLOT_TYPE. > > #include > > > > // > > @@ -57,7 +59,12 @@ typedef struct { > > // > > typedef struct { > > MV_SOC_SDMMC_DESC *SoC; > > - UINTN SdMmcDevCount; > > + UINTN SdMmcDevCount; > > + BOOLEAN Xenon1v8Enabled; > > + BOOLEAN Xenon8BitBusEnabled; > > + BOOLEAN XenonSlowModeEnabled; > > + UINT8 XenonTuningStepDivisor; > > + EFI_SD_MMC_SLOT_TYPE SlotType; > > } MV_BOARD_SDMMC_DESC; > > > > // > > @@ -84,4 +91,12 @@ typedef struct { > > UINTN UtmiDevCount; > > UINTN UtmiPortType; > > } MV_BOARD_UTMI_DESC; > > + > > +EFI_STATUS > > +EFIAPI > > +ArmadaBoardDescSdMmcGet ( > > + IN OUT UINTN *SdMmcDevCount, > > + IN OUT MV_BOARD_SDMMC_DESC **SdMmcDesc > > + ); > > + > > #endif /* __ARMADA_SOC_DESC_LIB_H__ */ > > -- > > 2.7.4 > >