From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::d31; helo=mail-io1-xd31.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2F6E5211982E6 for ; Tue, 11 Dec 2018 00:13:07 -0800 (PST) Received: by mail-io1-xd31.google.com with SMTP id s22so11076556ioc.8 for ; Tue, 11 Dec 2018 00:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fmcq5/hUL28eoOZIuDEXI2HdYjG0DmCzsRcPfA8vehk=; b=lIZGBFf9Om2lVuP8wRFLCpBwPc2y4WVfdU80L5TQAcXezAMUR1taHai7kbi0wnhjtE dhwSddtmYufqFCfK7wFm1rANcWxAAli1MYSfhbuuVifP/pq/ip+slPIapUX7eTOpKT93 Mgrj+z+hgqiuHmJyKFR+WC7yUXuEDh07xsgpfPviFw8lFojc/gitka2DTinEMByVsQCo ZQDGSyBRpPdLk9oc0QdfgsVtyS9SsjtSNFWAnwT+xNSnd8Hd2JzVwhwoLT0s/mHKbNho Oda4eWADPA3gLmO63ILx3iKjPcj4eq2G91qa74tRx3+5n5tf2YeFn+VxmVW0kSbhc/7u 8pYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fmcq5/hUL28eoOZIuDEXI2HdYjG0DmCzsRcPfA8vehk=; b=qMRcvKu/fL5WkOFWEwC8xev5SgrPZ3ZMS9ZxUbG1GK7DZTFdHQcpmwXdOu5zpt6Lmj g7LhljW9P8FsFI+Jd0sMey3ihMK8q+SERCQQ0hk2yoGq/6PM2POVMg7q5zrJgPGxsJtV 50HCxz25IOuaFNqDmOKiG7EUEhGtyInRK7oNuSEuhGk7IhzAaCJ6xgXj2kTBhLQdMQH4 1mLJ7nVFMg22ouH4g4Oe9JEAbPa5kCOAW0ZJQbgWnfyU6WM3Mhir4V9Zz3B6Fq0X6sGe 28f8vK35wTfeUJteHWG4dVnjnAC4ZazPOS0NGkEDoIXfHwtII/kgzV17a7Puv7XbZfbI y8xw== X-Gm-Message-State: AA+aEWZZKd1k4i/sIwzQzfQzDYBLfnYWOnzeN5yfv3SPjifLuajSUK36 JZF9cgGtf7Cn7AKU3IjGPUWdKeadslT0PNQ31VGA4dlR X-Google-Smtp-Source: AFSGD/Wodz2C9/06m6nYGwl+wIG9p7ZvAT7Ie8gjwuEZj7bT1vp+qIRr6jTQwiywo9K/tPumJ0WIfCdcHy/S8KloIv8= X-Received: by 2002:a5d:8049:: with SMTP id b9mr3998977ior.108.1544515986298; Tue, 11 Dec 2018 00:13:06 -0800 (PST) MIME-Version: 1.0 References: <20181115074528.8024-1-shenglei.zhang@intel.com> <20181210185726.grk3rrbbekntreeu@bivouac.eciton.net> In-Reply-To: From: Marcin Wojtas Date: Tue, 11 Dec 2018 09:12:52 +0100 Message-ID: To: df7729@gmail.com, Leif Lindholm Cc: "Carsey, Jaben" , "Ni, Ruiyu" , edk2-devel-01 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] ShellPkg: Remove ShellPkg wrapper header files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 08:13:07 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Leif, David, Thanks for the heads up. I finally will have a slot for the edk2 today - will fix and submit. Best regards, Marcin wt., 11 gru 2018 o 08:16 David F. napisa=C5=82(a): > I ran in to it too, it was easy fix, the headers changed to those in > MDEPKG and the header file name changed. IIRC it was the same name minus > the leading Efi, so EfiShellParameters.h became ShellParameters.h. I don= 't > have a full list but one of the notes on that change points out the new > names. > > On Mon, Dec 10, 2018 at 10:57 AM Leif Lindholm > wrote: > >> Hi Marcin, >> >> This EDK2 patch has been pushed, making all of the Armada platforms >> stop building. Can you have a look please? >> >> Regards, >> >> Leif >> >> On Thu, Nov 15, 2018 at 03:45:28PM +0800, Shenglei Zhang wrote: >> > These wrapper header files are not referenced by all >> > open source, so they are removed. >> > https://bugzilla.tianocore.org/show_bug.cgi?id=3D158 >> > >> > Cc: Jaben Carsey >> > Cc: Ruiyu Ni >> > Cc: Leif Lindholm >> > Cc: Ard Biesheuvel >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Shenglei Zhang >> > --- >> > ShellPkg/Include/Protocol/EfiShell.h | 21 ------------------= - >> > .../Include/Protocol/EfiShellDynamicCommand.h | 21 ------------------= - >> > .../Include/Protocol/EfiShellParameters.h | 20 ------------------ >> > ShellPkg/Include/ShellBase.h | 20 ------------------ >> > 4 files changed, 82 deletions(-) >> > delete mode 100644 ShellPkg/Include/Protocol/EfiShell.h >> > delete mode 100644 ShellPkg/Include/Protocol/EfiShellDynamicCommand.h >> > delete mode 100644 ShellPkg/Include/Protocol/EfiShellParameters.h >> > delete mode 100644 ShellPkg/Include/ShellBase.h >> > >> > diff --git a/ShellPkg/Include/Protocol/EfiShell.h >> b/ShellPkg/Include/Protocol/EfiShell.h >> > deleted file mode 100644 >> > index 8e3c2fe4de..0000000000 >> > --- a/ShellPkg/Include/Protocol/EfiShell.h >> > +++ /dev/null >> > @@ -1,21 +0,0 @@ >> > -/** @file >> > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification >> including errata. >> > - >> > - (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
>> > - Copyright (c) 2006 - 2016, Intel Corporation. All rights >> reserved.
>> > - This program and the accompanying materials >> > - are licensed and made available under the terms and conditions of >> the BSD License >> > - which accompanies this distribution. The full text of the license >> may be found at >> > - http://opensource.org/licenses/bsd-license.php >> > - >> > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASI= S, >> > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS O= R >> IMPLIED. >> > - >> > -**/ >> > - >> > -#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ >> > -#define __EFI_SHELL_PROTOCOL_H__WRAPPER__ >> > - >> > -#include >> > - >> > -#endif >> > diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h >> b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h >> > deleted file mode 100644 >> > index 50f9398ec6..0000000000 >> > --- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h >> > +++ /dev/null >> > @@ -1,21 +0,0 @@ >> > -/** @file >> > - EFI Shell Dynamic Command registration protocol >> > - >> > - (C) Copyright 2012-2014 Hewlett-Packard Development Company, L.P. >> > - Copyright (c) 2016, Intel Corporation. All rights reserved.
>> > - This program and the accompanying materials >> > - are licensed and made available under the terms and conditions of >> the BSD License >> > - which accompanies this distribution. The full text of the license >> may be found at >> > - http://opensource.org/licenses/bsd-license.php >> > - >> > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASI= S, >> > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS O= R >> IMPLIED. >> > - >> > -**/ >> > - >> > -#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ >> > -#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__ >> > - >> > -#include >> > - >> > -#endif >> > diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h >> b/ShellPkg/Include/Protocol/EfiShellParameters.h >> > deleted file mode 100644 >> > index 184b029ffa..0000000000 >> > --- a/ShellPkg/Include/Protocol/EfiShellParameters.h >> > +++ /dev/null >> > @@ -1,20 +0,0 @@ >> > -/** @file >> > - EFI Shell protocol as defined in the UEFI Shell 2.0 specification. >> > - >> > - Copyright (c) 2006 - 2016, Intel Corporation. All rights >> reserved.
>> > - This program and the accompanying materials >> > - are licensed and made available under the terms and conditions of >> the BSD License >> > - which accompanies this distribution. The full text of the license >> may be found at >> > - http://opensource.org/licenses/bsd-license.php >> > - >> > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASI= S, >> > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS O= R >> IMPLIED. >> > - >> > -**/ >> > - >> > -#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ >> > -#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__ >> > - >> > -#include >> > - >> > -#endif >> > diff --git a/ShellPkg/Include/ShellBase.h b/ShellPkg/Include/ShellBase= .h >> > deleted file mode 100644 >> > index 725ce5242f..0000000000 >> > --- a/ShellPkg/Include/ShellBase.h >> > +++ /dev/null >> > @@ -1,20 +0,0 @@ >> > -/** @file >> > - Root include file for Shell Package modules that utilize the >> SHELL_RETURN type >> > - >> > - Copyright (c) 2009 - 2016, Intel Corporation. All rights >> reserved.
>> > - This program and the accompanying materials >> > - are licensed and made available under the terms and conditions of >> the BSD License >> > - which accompanies this distribution. The full text of the license >> may be found at >> > - http://opensource.org/licenses/bsd-license.php >> > - >> > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASI= S, >> > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS O= R >> IMPLIED. >> > - >> > -**/ >> > - >> > -#ifndef _SHELL_BASE_ >> > -#define _SHELL_BASE_ >> > - >> > -#include >> > - >> > -#endif //__SHELL_BASE_ >> > -- >> > 2.18.0.windows.1 >> > >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel >> >