From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mx.groups.io with SMTP id smtpd.web12.8770.1624976284468660213 for ; Tue, 29 Jun 2021 07:18:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=EJZceiI5; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.169, mailfrom: mw@semihalf.com) Received: by mail-qt1-f169.google.com with SMTP id t9so16194220qtw.7 for ; Tue, 29 Jun 2021 07:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xZFseiTDdLhRkdrhqidjt6KR6ovNPzDYLEnU1uhk1js=; b=EJZceiI52K6jUv2Pq/Iw8snlodcx0ApqwW5RoLHUc9uExOMbMqR8ZKT1XZJkFdO8LE nRuhdEFlZI4XB0kuuhv0jEssnV/kNNZvZoDhNyd7x460s+D63Pk0PGssQ5BAcxb0AmTh 7WkWLzvoO8sXraCwW59w2L4z2+TNriiQz/LW5Hjddi9zX+RE0M4WUR1IVCZpHl/mxB0D kg/dGj2Zk7yELr+6h92eeghBXiX6HzY68vVmgFBN4jdELUNV3NSwK8dgp8lcgPI9Jv2y 15mO22KTD0/mu2FCEwfU81S8ajn3Rn15/MvivevcjCVRq3VeyT3ZtHUuiDYq1wiUTm+Q gyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xZFseiTDdLhRkdrhqidjt6KR6ovNPzDYLEnU1uhk1js=; b=dwUYQFBDiODMnQuvBx2xboqq/B79WC1OC1T/VesNtfgG8TPaqDf7QUPAz2778uVVQ2 G8jIHWDkDNWKGQGqxzkSz5JyhISGUtO4s5KpOfaxVWUAjkKf6dEOguu/QOLG9Z/a+sFD SSHml17IpyEkKyLz0GNFMki9Xn4crjK3ZmMS8TEiZjgCcnZBq+zkkP4E7v/gPhJz705Z gKVIwY+otGbhUeQ87Q9N5F//QUJEuQmkIW+hbl4kIiw6+vpIeEt/MXzc/klUJ9fXDeEo ButJ5zaRzGOO+om/lhI8FvBWDauDXgkhlmxN/3iamfzffPP8sjdhrJBPWx5DVVPrTQCT ptSQ== X-Gm-Message-State: AOAM532wbshYNepz3bYPhyG3GXq/NVzJX1Y5LKp8Dkd2pbbyop14Yrk0 VoV01PI2bZqNkrp0FH2j05DPmCHJGhs0EcfZ3+GKeQ== X-Google-Smtp-Source: ABdhPJy3CrmUw6abSytaN8sEUNz52Xc1j1cmCUZwpKYo4f4Ycz8+CsCg7yt16sEsmcKH27XNJ7I/zo9NGcBxsCVq9Qk= X-Received: by 2002:ac8:72c5:: with SMTP id o5mr6129858qtp.216.1624976283624; Tue, 29 Jun 2021 07:18:03 -0700 (PDT) MIME-Version: 1.0 References: <20210613181631.2247221-1-mw@semihalf.com> <20210614215540.u2y4oc2s4cvs6kxw@leviathan> In-Reply-To: <20210614215540.u2y4oc2s4cvs6kxw@leviathan> From: "Marcin Wojtas" Date: Tue, 29 Jun 2021 16:17:52 +0200 Message-ID: Subject: Re: [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs To: Leif Lindholm Cc: edk2-devel-groups-io , Ard Biesheuvel , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud , Jon Nettleton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, pon., 14 cze 2021 o 23:55 Leif Lindholm napisa=C5=82(a)= : > > Hi Marcin, > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > Hi, > > > > The MDIO ACPI binding has been established and merged to the > > Linux tree, > > Congratulations! :) > > Is FreeBSD expected to follow suit? There's no driver yet, but once it's finally created I will make sure it supports ACPI properly. > > > hence it is now possible to update the ACPI > > description of the platforms that base on the Marvell SoCs. > > > > For convenience, the code is exposed in the public github branch: > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/acpi-m= dio-r20210613 > > There is also MacchiatoBin firmware binary avaialable for testing: > > https://drive.google.com/file/d/1eigP_aeM4wYQpEaLAlQzs3IN_w1-kQr0 > > > > I'm looking forward to the comments or remarks. > > The patches themselves look straightforward enough. > I *would* prefer some tested-by, for these sources rather than the > binary, before merging though. > I have some our patches queued, that are blocked by this patchset. In case no time is found for external testers - if this may help to get it pushed through, please see below logs from the next-20210628 tag and unchanged firmware. All network ports of MacchiatoBin and CN913x-DB work properly, with full 1G/10G PHY support via X/MDIO interfaces: MacchiatoBin # uname -a Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 09:14:07 CEST 2021 aarch64 GNU/Linux # dmesg | grep MRVL0101 [ 1.829659] mv88x3340 MRVL0101:00-mii:00: Firmware version 0.3.3.0 [ 1.839622] mv88x3340 MRVL0101:00-mii:08: Firmware version 0.3.3.0 [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] driver [mv88x3340] (irq=3DPOLL) [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] driver [mv88x3340] (irq=3DPOLL) # dmesg | grep MRVL0100 [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] driver [Marvell 88E1510] (irq=3DPOLL) # dmesg | grep mvpp2 [...] [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] driver [mv88x3340] (irq=3DPOLL) [ 2.756701] mvpp2 MRVL0110:00 eth1: configuring for phy/10gbase-r link m= ode [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] driver [mv88x3340] (irq=3DPOLL) [ 2.775834] mvpp2 MRVL0110:01 eth2: configuring for phy/10gbase-r link m= ode [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] driver [Marvell 88E1510] (irq=3DPOLL) [ 2.928285] mvpp2 MRVL0110:01 eth3: configuring for phy/sgmii link mode [ 2.936351] mvpp2 MRVL0110:01 eth4: configuring for inband/2500base-x link mode [ 5.987259] mvpp2 MRVL0110:01 eth3: Link is Up - 1Gbps/Full - flow control off # CN913x-DB # uname -a Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 29 09:14:07 CEST 2021 aarch64 GNU/Linux # dmesg | grep MRVL0100 [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] driver [Marvell 88E1510] (irq=3DPOLL) [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] driver [Marvell 88E1510] (irq=3DPOLL) # dmesg | grep mvpp2 [...] [ 2.544917] mvpp2 MRVL0110:00 eth1: configuring for inband/10gbase-r link mode [ 2.552480] mvpp2 MRVL0110:00 eth1: Link is Up - 10Gbps/Full - flow control rx [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] driver [Marvell 88E1510] (irq=3DPOLL) [ 2.630060] mvpp2 MRVL0110:00 eth2: configuring for phy/rgmii-id link mo= de [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] driver [Marvell 88E1510] (irq=3DPOLL) [ 2.750056] mvpp2 MRVL0110:00 eth3: configuring for phy/rgmii-id link mo= de [ 2.810169] mvpp2 MRVL0110:01 eth4: configuring for inband/10gbase-r link mode [ 2.817471] mvpp2 MRVL0110:01 eth4: Link is Up - 10Gbps/Full - flow control rx [ 5.693231] mvpp2 MRVL0110:00 eth2: Link is Up - 1Gbps/Full - flow control off [ 10.840942] mvpp2 MRVL0110:00 eth1: Link is Down [ 10.864124] mvpp2 MRVL0110:01 eth4: Link is Down # Best regards, Marcin