From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::22c; helo=mail-io0-x22c.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE0D921EA15C9 for ; Fri, 6 Oct 2017 12:27:01 -0700 (PDT) Received: by mail-io0-x22c.google.com with SMTP id 101so4678715ioj.3 for ; Fri, 06 Oct 2017 12:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=frbTQYTwmLj6qzip8bzhMKqlP6B0xeL9gN8FGG2m0QE=; b=XDps+Zfbxx82UbuvYtV1LH67QL4iCuGxA+G2iEalb2DOOQZkmYY2nQ6BeEHXDfvZpJ rQbUqvAEOVzJHAtyxKwJeMZXQlnl50yybtfNq3twSn0+Ece4cMRjzolLE7xni6rMWei/ eSHvd/fN/ZH5/brnXz/73AeBBwaKt/qi9d8dnZmLCqYprz4kB5K8M/kjnP/gq9kI5sjO QvF70utlYM2oslDzhz3ZJTgyVu4gHn0vTINcb70rLzNuWNx5Rx3eEqnLGK3WJhaTpx8E qkREp8RvsKBlk9T3FqrWCBS3DsImvi82aECs33f5vl6e/s4CzAJaSyu9bK58FTlwh3Je BpIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=frbTQYTwmLj6qzip8bzhMKqlP6B0xeL9gN8FGG2m0QE=; b=LfoGiLV/vv++PWK8hQCX6Qj0yd2Ygd+OazM7CU/dvJ9zg4wKq70L8mYtwEYIQahxws xSobCwdnDYDJlts6188zWSfZ6lho70BV3Ev6A+tWyTF1i+H0zFx+G7SrFgqXjHsR+OAi 8F5lgKpzBkdLNu5hkoe2/JRPvqPu6LvKYJATtK+2izVTng9IaHyrLATfJa4uRA3j45+p vWc0K6nM7gM885XUX3+fIJc/ylPZ8VTd5ku6dTAd72e3UcZCMeKBTQntMcrjwAiBqoxP QmXVdvgLWyUZ53XRrlq2SY1ano1uQyx8Kch1z2ANO5d2Op4iYEuwIwbYRNL3NejwBF8d /hmw== X-Gm-Message-State: AMCzsaVRc0KP2XPpf87AK7GGGNtHKmYoek/gmxbIZgewWhLFFSirpVci nBm9kBqqaxWfDcKs7SubmsovoWiWcZCCQszjLhjEWue5 X-Google-Smtp-Source: AOwi7QDsYEjTEqyEEqRjONa45BxRENlH02pAqGXsj6YMTH+ktwrzXG4QkrIgogv9iQs2KO77VRcmzRJPzTntdBULvj0= X-Received: by 10.107.184.194 with SMTP id i185mr3772243iof.155.1507318225397; Fri, 06 Oct 2017 12:30:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Fri, 6 Oct 2017 12:30:24 -0700 (PDT) In-Reply-To: <20171006160204.7cjh43zknjggz5as@bivouac.eciton.net> References: <1507276278-3608-1-git-send-email-mw@semihalf.com> <1507276278-3608-5-git-send-email-mw@semihalf.com> <20171006160204.7cjh43zknjggz5as@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 6 Oct 2017 21:30:24 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 4/5] Marvell/Drivers: Pp2Dxe: Rework PHY handling X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 19:27:02 -0000 Content-Type: text/plain; charset="UTF-8" 2017-10-06 18:02 GMT+02:00 Leif Lindholm : > On Fri, Oct 06, 2017 at 09:51:17AM +0200, Marcin Wojtas wrote: >> Hitherto PHY handling in Pp2Dxe was not flexible. It allowed for using >> only single MDIO controller, which may not be true on Armada 80x0 SoCs. >> For this purpose introduce the MDIO description, using the new structures >> and template in MvHwDescLib. This change enables addition of multiple >> CP110 hardware blocks with MDIO controllers. >> >> This change required different PHY handling and obtaining data over >> desired MDIO bus. Now given Pp2 port is matched with the PHY via >> its index in gMarvellTokenSpaceGuid.PcdPhyDeviceIds. The PHY itself >> is mapped to the MDIO controller, using >> gMarvellTokenSpaceGuid.PcdPhy2MdioController. Also obtaining >> SMI addresses was moved to the PHY initialization routine. >> All above allow for much cleaner and logical PHY description >> in the .dsc file. >> >> Update PortingGuide documentation accordingly and Armada 70x0 DB >> NIC/PHY description. > > Like for previous patches, can we have: > - symbolic names for things that can be given symbolic names. > - Pcds describing boolean arrays have an "Enabled" appended to their > name? > 2x OK. Marcin.