From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2584521122955 for ; Thu, 6 Sep 2018 07:17:56 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id h23-v6so14323939ita.5 for ; Thu, 06 Sep 2018 07:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qY1Mh6rf1vciAUsBK221RNzLYueiPV3WfXWwyxrFbWU=; b=Rl80PfrhhVl6VZvvee00ZeicpOLqo5UvDyZN9zphVN73HWt0h+2f/yVb0kFT9I4J8d JcdxpIMqac3zp+YxIb0daUftJ/teNlZDsuvpiMjH31o350fyRI4w7Y6wp/FDax6lNaR2 FdEA1Ra9Np0oksmlj/xfyoMWano0WH5ruKc4porgYzQOo2vD33/w3ia0L7GzZn1wbgMB Igu+wYp7QVfS4zeRdIPguiyEbyatZbvflF/+N7sUkx6tzs9uQLSIHdDfKQvY3xbEe3I6 cvuvHn6chouSl5Mcxw+iW7XFr5cQc0rcI5PjnbE84dCzBxpSo+NXVfVHTykhfJM6FcY7 u3Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qY1Mh6rf1vciAUsBK221RNzLYueiPV3WfXWwyxrFbWU=; b=hlk2yxxbU0WoxJ4gGcASbVVjB9PcqdrxVRYmc6tTGhlEISS+otT5bHtXAcCnPOcTrr ASVLoQ999iM/uGQyQTqsIq8SON+P2ZLOa3IlNILV2F1n/Txqb0qW8QLoG8xMynQMUz0c uhyFv1VxzmE+SAIWExG7nzDZFWW5bXwqLM4KDYptUL5ELgPbvbkggHP2q6mV8r2jU/cN MdBSTXNCW1nAqIdglG+LHAEt7NVYj/jx1SmgaTqE2EpVd7nC4jVH/KffTw1odL2nh1Rf xY/urEcV0yrJrEbg2q6wRtrHqxj4R0ktaFVaSSE/W8WmLas7agCjyGnyRyXJ1vSnEH4g 7SgA== X-Gm-Message-State: APzg51DbJ/+sjo0+t27qrG5DGqhqfWVPOm+06cGo8myOQLgT/2w16xWb G/vrNwf1RjS5jTHdMpzQJq4crdrJEpHy42c5s/P+VQ== X-Google-Smtp-Source: ANB0VdZr/leCiHiwkDV7zldvx1KF7MGX9vSLSlHrcjitIHz3+Z4mxY4oRuOpPt8euCtuYdH0s8XbjPxWlvZWHGX7Qlc= X-Received: by 2002:a24:2f0e:: with SMTP id j14-v6mr2650463itj.120.1536243475425; Thu, 06 Sep 2018 07:17:55 -0700 (PDT) MIME-Version: 1.0 References: <1535950453-27147-1-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Thu, 6 Sep 2018 16:17:42 +0200 Message-ID: To: Ard Biesheuvel Cc: edk2-devel-01 , "Tian, Feng" , "Kinney, Michael D" , "Gao, Liming" , Leif Lindholm , nadavh@marvell.com, "jsd@semihalf.com" Subject: Re: [PATCH 0/7] SdMmc fixes and SdMmcOverride extension X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 14:17:56 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ard, czw., 6 wrz 2018 o 16:12 Ard Biesheuvel napisa= =C5=82(a): > > On 3 September 2018 at 06:54, Marcin Wojtas wrote: > > Hi, > > > > This patchset extends SdMmcOverride protocol with new callbacks: > > * UhsSignaling - allow writing custom values to HostControl2 register > > * SwitchClockFreqPost - perform additional opperations after clock swit= ch > > * BaseClockFreq - allow overriding base clock frequency > > Also a couple of fixes for MMC, card detection and reset are submitted. > > More details can be found in the commit messages. > > > > Patches are available in the github: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits= /sdmmc-override-upstream-r20180902 > > > > Please note that extending SdMmcOverride protocol was impacting > > so far the only user of it (Synquacer controller). In paralel > > edk2-platforms patchset, a patch can be found: > > ("Silicon/SynQuacer/PlatformDxe: Modify initialization of SdMmcOverride= ") > > which immunizes for above and future extensions of the protocol: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits= /xenon-upstream-r20180902 > > > > I'm looking forward to the comments and remarks. > > > > Could we split this into a series of fixes/compliance tweaks, and a > set of changes to the SD/MMC override protocol hooks that need to be > added to accommodate Xenon? > > I suppose the former can be merged without much hassle, but the latter > may provoke some fierce discussion, I'm afraid. > Ok. will split into two separate series. Anyway, I hope the override protocol won't be that problematic - no functional change for non-users, and the callbacks resemble the hooks that are provided by drivers/mmc in Linux. Marcin > > > > Marcin Wojtas (3): > > MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation > > MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence > > MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlo= t > > > > Tomasz Michalec (4): > > MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protoco= l > > MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride > > MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency > > MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bit= s > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 + > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 67 +++++- > > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 83 ++++++- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 246 +++++++++++++= ------- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 55 ++++- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 37 ++- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 102 ++++++-- > > 7 files changed, 467 insertions(+), 129 deletions(-) > > > > -- > > 2.7.4 > >