From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::742; helo=mail-qk1-x742.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3396B211C384F for ; Wed, 30 Jan 2019 23:01:21 -0800 (PST) Received: by mail-qk1-x742.google.com with SMTP id q1so1270044qkf.13 for ; Wed, 30 Jan 2019 23:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2NmgNyoPeF1ZsSbbSXXqQ7nW0M1CXw7CsOqeFRW/Hws=; b=J3+u1ZFh1jyOZdsFaCskp+pu9ENKQ67sBBh+cLAlkqcOWXShMM3WLYpalW3Y05ctgG kEv27NdT83xoaV4l8Oh3+pExNXY6YjRILLsKO+Q2gXkEZ45h9d7bWmy4jPF/X5nFlgCn priZsSQFbrEGYiqvk6uJC8zRiVpBvPRcO/aNedZO3PfS1PmGdYVH3MtTGuncJBVu1wKp 899vqcFSx4e1TCa6HUhxDDCu1pVPw0WCn3bdHASZaGUZbR7oXQf1mLGEDhzPZqcDWfN6 +EYX3CgQ0wX+qnK0/wM0dtcKG6v5kqqWmUMz7bBlKv+CeNPrTQWZ7Ek/d6M2U+qXf80x WbHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2NmgNyoPeF1ZsSbbSXXqQ7nW0M1CXw7CsOqeFRW/Hws=; b=d2iZVRkdygsese2kkifQbGwSe1B105/J3x4Lch94urcMG6KekbWm48U0WqbvuInu62 jIQNm0Otme+Ab9CUa226F5q1PTe6FnOjaV9EwKNnwKzBnxDFRbMbhUrSTBnzp545wrbj xK/5nWsAavqPJgS0mz0+hDvRc++N8bQEM6Z+HeEt6ptCWFedp+TpfZqRN1oMtf9ZRcSG mb45kOK0rgGHICfECSKHQFFsrRrK9eGGC+OW1gyUaFPQ2tYF88jNQyC0B7vthI8ksDlX R4M+ysSF9s+unpfZi3p01ptyCGfG5SdHXs3V8mfgu9d+Chl4eSINYf1YAMRX7H/m020i kkQw== X-Gm-Message-State: AJcUukeFVZovuPCmyV9GKCDm3sHTGKbf0DvJziBk6BX0GqHxIJYj/COA VVKTCRmr1JhWgdbj/SHZL7tygjkO8z66h2LKJ87ckw== X-Google-Smtp-Source: ALg8bN6DGRmZkhg+yhSaQOOF5E5lJa6wee8kT1i6mjXYAQ1bL1TmhzYAh0opvxffTNoobACmoZK6heQTpvQ8J0rfvCg= X-Received: by 2002:a37:cc4c:: with SMTP id r73mr29956161qki.120.1548918079853; Wed, 30 Jan 2019 23:01:19 -0800 (PST) MIME-Version: 1.0 References: <1548668715-15042-1-git-send-email-mw@semihalf.com> <20190130164737.glko5nprvhfcy7ap@bivouac.eciton.net> In-Reply-To: <20190130164737.glko5nprvhfcy7ap@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 31 Jan 2019 08:01:08 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [platforms: PATCH v3 0/5] Armada7k8k memory handling update X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 07:01:21 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.h / ArmPkg/Library/ArmLib/ArmLib.c would be a proper place for it? Best regards, Marcin =C5=9Br., 30 sty 2019 o 17:47 Leif Lindholm napisa=C5=82(a): > Thanks for the rework. > > (We should probably move that broken-out function to ArmPkg at some point= .) > > For the series: > Reviewed-by: Leif Lindholm > > Pushed as b0bb325f20..0a7d8e7d93. > > On Mon, Jan 28, 2019 at 10:45:10AM +0100, Marcin Wojtas wrote: > > Hi, > > > > The third version of the patchset moves the new common > > header for Marvell SMC ID's to the IndustryStandard directory. > > What is more important, now 3 regions (described by new PCDs) > > are reserved separately. For that purpose a preparation > > patch was added, which extract existing reservation code > > into a new subroutine. More details can be found in > > the changelog below and the commit messages. > > > > Patches are available in the github: > > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/d= ram-upstream-r20190128 > > > > I'm looking forward to the comments and remarks. > > > > Best regards, > > Marcin > > > > Changelog: > > v2 -> v3 > > * 1/5 > > - New patch - extract memory reservation to a separate routine > > > > * 2/2 > > - Add new PCDs and reserve 3 regions (ARM-TF, PEI stack, OP-TEE) > > separately > > - Update commit message accordingly > > > > * 3/5 > > - Move MvSmc.h to Include/IndustryStandard > > > > * 4,5/5 > > - Add Leif's RB > > > > v1 -> v2: > > * 1/4 > > - Improve commit log - mention single area size and new PEI stack bas= e > > > > * 2/4 (new patch) > > - Add common header for Marvell SMC ID's > > > > * 3/4 > > - Add function description comment > > - Define and use ARMADA7K8K_AP806_INDEX > > - Change function argument to EFI_PHYSICAL_ADDRESS > > > > * 4/4 > > - Move new SMC ID to MvSmc.h > > - Include ArmadaSoCDescLib.h directly (instead indirectly via > BoardDesc.h) > > - Remove ARMADA7K8K_AP806_INDEX macro > > > > Grzegorz Jaszczyk (2): > > Marvell/Library: ArmadaSoCDescLib: Add North Bridge description > > Marvell/Armada7k8k: Read DRAM settings from ARM-TF > > > > Marcin Wojtas (3): > > Marvell/Armada7k8k: Refactor reserving memory regions > > Marvell/Armada7k8k: Shift PEI stack base and extend memory reservatio= n > > Marvell/Library: Introduce common header for the SMC ID's > > > > Silicon/Marvell/Marvell.dec > | 8 +- > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > | 16 ++- > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf > | 3 + > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kMemoryInitPeiLib/Armada7k8kM= emoryInitPeiLib.inf > | 8 +- > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.h > | 25 ----- > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDesc= Lib.h > | 6 ++ > > Silicon/Marvell/Include/IndustryStandard/MvSmc.h > | 24 +++++ > > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > | 28 +++++ > > Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > | 8 +- > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.c > | 60 ++++------- > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kMemoryInitPeiLib/Armada7k8kM= emoryInitPeiLib.c > | 107 +++++++++++++------- > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDesc= Lib.c > | 34 +++++++ > > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c > | 14 +-- > > 13 files changed, 220 insertions(+), 121 deletions(-) > > create mode 100644 Silicon/Marvell/Include/IndustryStandard/MvSmc.h > > > > -- > > 2.7.4 > > >