From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::234; helo=mail-it0-x234.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D8FE2035520B for ; Thu, 9 Nov 2017 07:44:05 -0800 (PST) Received: by mail-it0-x234.google.com with SMTP id f187so11810720itb.1 for ; Thu, 09 Nov 2017 07:48:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WNt5gu6KsNEeHl9F+huPO3yhLskgQDdmCFi9oONHdQE=; b=afSkng/NZ/XQKMTTESRX8dya1MfsKkfmXC4khzy2IHL+gmnQfD+5aEHuiD7i5u2bU4 uZnW72LgWQI7CYXGQULbaYYIs4wJtmnB6EtFbmMFkXi2p5PB4dIIYBgjqD0UmF0VwRHR APc5IpS549gRIwH4KEwgEvH1LOSh3LTCXngAchWvKV23B1NykhyNCRzQJMWpCI2/ZkUR cpM+hAscEw1mXOAE7b2+xjhiPgtVC8zFAZbP0TNSdOefNHaZaegz3lUdO2FJdwIOpWa3 /kQAdDJnvBmK2HHRGskpoJpnWDvf+bec3RFlKHxBWDNpgxxdOunyZq8U0Xa31U3TMIfL 1f8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WNt5gu6KsNEeHl9F+huPO3yhLskgQDdmCFi9oONHdQE=; b=ncfTmBeuv3JPfTUXROs24JyJszkB5SrXZ3UWJbKfWCLt58o9/aHQe3rROqqKs5O077 e3lc0yKT7WyTHZcVfbIFWmHyd/r6I1HF8NQkNL1vR/I64hR0ePPz+5qWYZvImza8j4A1 PQDi5dQXTPGx5/m92joLbozGpLxL/VcBjlg6jD6B9ST+mSntY8gnqh2kZ5jshwQoBpnC CS+LVHnmJQIoa8DSM2kSZwsLLqbwyNLYYooCNIXDoQ4dfcTVhMQRYIn6SEEY/HsWuOXo sV5lmOTqghlwPAmYkAC2vihMJRuNqfwO+IO29nLJLwWBK77SUW6Cv8Bhq9nJiTM8RDq6 /wKA== X-Gm-Message-State: AJaThX7fWrW3YDVgQ3PlKa4rZAz6JdOtrjkxIbM7C1Dg4QAG4o9yiMaP KjKfMlF+KtbhC/TnfFsAz3h+2UMO/56htwL4LtQaTRgv X-Google-Smtp-Source: AGs4zMbmUmCexSdBGARZOIld6xiBFAnFdodyd4zggRO88kEwN7STxftjIF28487zyZR67q/whq8Dey7ykJ0HSNTmYQU= X-Received: by 10.36.110.71 with SMTP id w68mr380750itc.113.1510242486736; Thu, 09 Nov 2017 07:48:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.167.208 with HTTP; Thu, 9 Nov 2017 07:48:05 -0800 (PST) In-Reply-To: <20171109154031.ewlgdw3rbioyvmcx@bivouac.eciton.net> References: <1509879339-10516-1-git-send-email-mw@semihalf.com> <1509879339-10516-4-git-send-email-mw@semihalf.com> <20171109150259.tafexhjd7qzocrc3@bivouac.eciton.net> <20171109154031.ewlgdw3rbioyvmcx@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 9 Nov 2017 16:48:05 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 3/4] Platform/Marvell: Introduce MvFvbDxe variable support driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 15:44:06 -0000 Content-Type: text/plain; charset="UTF-8" 2017-11-09 16:40 GMT+01:00 Leif Lindholm : > On Thu, Nov 09, 2017 at 04:16:54PM +0100, Marcin Wojtas wrote: >> Hi Leif, >> >> > > + { >> > > + MvFvbGetAttributes, // GetAttributes >> > > + MvFvbSetAttributes, // SetAttributes >> > > + MvFvbGetPhysicalAddress, // GetPhysicalAddress >> > > + MvFvbGetBlockSize, // GetBlockSize >> > > + MvFvbRead, // Read >> > > + MvFvbWrite, // Write >> > > + MvFvbEraseBlocks, // EraseBlocks >> > > + NULL, // ParentHandle >> > > + }, // FvbProtoccol; >> > >> > -c >> > >> >> Thanks for thorough review. Everything seems clear, but what does "-c" >> above mean? > > You stole the misspelt "// FvbProtocol" from > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c. > > This had the benefit of showing me what this file was based on, but > should probably be fixed :) > Right, I could have mentioned it explicitly in the commit message (only the copyrights are left). Significant part of the issues you pointed had been inherited from the original driver - my eyes and the checkpatch missed them. Marcin