* [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in
@ 2016-12-01 8:41 Feng Tian
2016-12-01 14:40 ` Marcin Wojtas
2016-12-02 1:44 ` Zeng, Star
0 siblings, 2 replies; 3+ messages in thread
From: Feng Tian @ 2016-12-01 8:41 UTC (permalink / raw)
To: edk2-devel; +Cc: Jan Dabros, Marcin Wojtas, Star Zeng
The commit e27cca has a typo on DEBUG level macro. And this debug
message should be DEBUG_INFO rather than DEBUG_ERROR.
Cc: Jan Dabros <jsd@semihalf.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
index 4c1b5c8..23faec5 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
@@ -638,7 +638,7 @@ SdMmcPciHcDriverBindingStart (
if (EFI_ERROR (Status) && (Status != EFI_MEDIA_CHANGED)) {
continue;
} else if (!MediaPresent) {
- DEBUG ((EFI_ERROR, "SdMmcHcCardDetect: No device attached in Slot[%d]!!!\n", Slot));
+ DEBUG ((DEBUG_INFO, "SdMmcHcCardDetect: No device attached in Slot[%d]!!!\n", Slot));
continue;
}
--
2.7.1.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in
2016-12-01 8:41 [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in Feng Tian
@ 2016-12-01 14:40 ` Marcin Wojtas
2016-12-02 1:44 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Marcin Wojtas @ 2016-12-01 14:40 UTC (permalink / raw)
To: Feng Tian; +Cc: edk2-devel-01, Jan Dabros, Star Zeng
Hi Feng,
You are right. Sorry for the mistake.
Best regards,
Marcin
2016-12-01 9:41 GMT+01:00 Feng Tian <feng.tian@intel.com>:
> The commit e27cca has a typo on DEBUG level macro. And this debug
> message should be DEBUG_INFO rather than DEBUG_ERROR.
>
> Cc: Jan Dabros <jsd@semihalf.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Feng Tian <feng.tian@intel.com>
> ---
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> index 4c1b5c8..23faec5 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> @@ -638,7 +638,7 @@ SdMmcPciHcDriverBindingStart (
> if (EFI_ERROR (Status) && (Status != EFI_MEDIA_CHANGED)) {
> continue;
> } else if (!MediaPresent) {
> - DEBUG ((EFI_ERROR, "SdMmcHcCardDetect: No device attached in Slot[%d]!!!\n", Slot));
> + DEBUG ((DEBUG_INFO, "SdMmcHcCardDetect: No device attached in Slot[%d]!!!\n", Slot));
> continue;
> }
>
> --
> 2.7.1.windows.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in
2016-12-01 8:41 [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in Feng Tian
2016-12-01 14:40 ` Marcin Wojtas
@ 2016-12-02 1:44 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Zeng, Star @ 2016-12-02 1:44 UTC (permalink / raw)
To: Tian, Feng, edk2-devel@lists.01.org; +Cc: Jan Dabros, Marcin Wojtas, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Tian, Feng
Sent: Thursday, December 1, 2016 4:42 PM
To: edk2-devel@lists.01.org
Cc: Jan Dabros <jsd@semihalf.com>; Marcin Wojtas <mw@semihalf.com>; Zeng, Star <star.zeng@intel.com>
Subject: [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in
The commit e27cca has a typo on DEBUG level macro. And this debug message should be DEBUG_INFO rather than DEBUG_ERROR.
Cc: Jan Dabros <jsd@semihalf.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian <feng.tian@intel.com>
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
index 4c1b5c8..23faec5 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
@@ -638,7 +638,7 @@ SdMmcPciHcDriverBindingStart (
if (EFI_ERROR (Status) && (Status != EFI_MEDIA_CHANGED)) {
continue;
} else if (!MediaPresent) {
- DEBUG ((EFI_ERROR, "SdMmcHcCardDetect: No device attached in Slot[%d]!!!\n", Slot));
+ DEBUG ((DEBUG_INFO, "SdMmcHcCardDetect: No device attached in
+ Slot[%d]!!!\n", Slot));
continue;
}
--
2.7.1.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-02 1:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-01 8:41 [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in Feng Tian
2016-12-01 14:40 ` Marcin Wojtas
2016-12-02 1:44 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox