Re: [platforms: PATCH v2 0/6] Armada 7k/8k SPI improvements pt 2.

[Marcin Wojtas <mw@semihalf.com>]

Hi Leif,

2017-11-05 7:13 GMT+01:00 Leif Lindholm <leif.lindholm@linaro.org>:
> On Fri, Nov 03, 2017 at 06:57:09PM +0100, Marcin Wojtas wrote:
>> Hi,
>>
>> I submit corrected version of the Armada SPI improvements
>> after the first round of review. There were no significant changes
>> comparing to v1, please check the changelog below for the details.
>>
>> Patches are available in the github:
>> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171103
>> NorFlashInfoLib:
>> https://github.com/MarvellEmbeddedProcessors/edk2/commits/norlib-upstream-r20171103
>>
>> I'm looking forward to the comments or remarks.
>
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> I'll push it (and send an email about it) when I'm not just about to
> jump on a plane. Kick me if you haven't seen anything by end of
> Monday.
>
> /

Thanks. However the patches are depending on the NorFlashInfoLib - it
has to be merged first, otherwise we will break compilation. Do you
think there is a chance of that happening?

Best regards,
Marcin

>     Leif
>
>> Best regards,
>> Marcin
>>
>> Changelog:
>> v1 -> v2
>> 1/6
>>   - Replace NOR_FLASH_ID_DEFAULT_LEN with PcdGetSize (PcdSpiFlashId)
>>
>> 2/6
>>   - Adjust to renamed functions and macros according to NorFlashInfoLib v2
>>   - Restore handling of CMD_ERASE_32K
>>   - Check NOR_FLASH_4B_ADDR only once and use SPI_DEVICE structure instead
>>
>> 3/6
>>   - Improve commit log
>>
>> 4/6
>>   - Use global variable explicitly (mSlave)
>>
>> 5/6
>>   - Use NOR_FLASH_ID_SPANSION from EmbeddedPkg/Include/Library/NorFlashInfoLib.h
>>
>> 6/6
>>   - Add RB
>>
>> Marcin Wojtas (6):
>>   Marvell/Drivers: MvSpiFlash: Improve ReadId
>>   Marvell/Drivers: MvSpiFlash: Enable dynamic SPI Flash detection
>>   Marvell/Drivers: MvSpiFlash: Remove duplicated macros
>>   Marvell/Applications: SpiTool: Do not override existing slave device
>>   Marvell/Drivers: MvSpiFlash: Fix bank selection for Spansion
>>   Marvell/Drivers: MvSpiDxe: Keep data in SPI_DEVICE structure
>>
>>  Platform/Marvell/Applications/FirmwareUpdate/FUpdate.c   |  25 +----
>>  Platform/Marvell/Applications/FirmwareUpdate/FUpdate.inf |   4 +-
>>  Platform/Marvell/Applications/SpiTool/SpiFlashCmd.c      |  57 ++++------
>>  Platform/Marvell/Applications/SpiTool/SpiFlashCmd.inf    |   2 +-
>>  Platform/Marvell/Armada/Armada.dsc.inc                   |   1 +
>>  Platform/Marvell/Armada/Armada70x0.dsc                   |   5 -
>>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c        | 116 ++++++++++----------
>>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h        |   3 +
>>  Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf      |   9 +-
>>  Platform/Marvell/Drivers/Spi/MvSpiDxe.c                  |  63 ++++++-----
>>  Platform/Marvell/Drivers/Spi/MvSpiDxe.h                  |   1 +
>>  Platform/Marvell/Drivers/Spi/MvSpiDxe.inf                |   2 +
>>  Platform/Marvell/Include/Protocol/Spi.h                  |   7 ++
>>  Platform/Marvell/Include/Protocol/SpiFlash.h             |  14 +--
>>  Platform/Marvell/Marvell.dec                             |   6 -
>>  Silicon/Marvell/Documentation/PortingGuide.txt           |  18 ---
>>  16 files changed, 142 insertions(+), 191 deletions(-)
>>
>> --
>> 2.7.4
>>