From: Marcin Wojtas <mw@semihalf.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib
Date: Tue, 29 Aug 2017 17:53:03 +0200 [thread overview]
Message-ID: <CAPv3WKe+GV4SErbZS7Jy7Y_k9tgsfxqAsi5WPHuHex3+wgHQNQ@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu8ZXHkT0bc-+-v9ZWqx3p8ByGbYrVV81rJ-LuvC=1KLgA@mail.gmail.com>
2017-08-29 17:48 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
> On 29 August 2017 at 16:47, Marcin Wojtas <mw@semihalf.com> wrote:
>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote:
>>>> Instead of hardcoding the non-cache coherent nature of this device
>>>> by invoking UncachedMemoryAllocationLib directly for allocating
>>>> shared buffers, switch to DmaLib, which encapsulates this at a
>>>> more abstract level. This allows the driver to be shared with
>>>> platforms that are cache coherent (by simply switching to another
>>>> DmaLib implementation), and removes the hardcoded dependency on
>>>> UncachedMemoryAllocationLib, which will be removed from upstream
>>>> EDK2.
>>>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>
>>> Ah, and there is the non-bogus fix :)
>>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
>> Please let me just run this on the HW before merge - I'll do it tomorrow.
>>
>
> Sure. Note that you will need to sync EDK2 after I merged the DmaLib
> changes (which I will do today)
Ok, please let know once it's available and also it would be great if
this patch could be shared via github repo.
Thanks,
Marcin
next prev parent reply other threads:[~2017-08-29 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 12:25 [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib Ard Biesheuvel
2017-08-29 15:46 ` Leif Lindholm
2017-08-29 15:47 ` Marcin Wojtas
2017-08-29 15:48 ` Ard Biesheuvel
2017-08-29 15:53 ` Marcin Wojtas [this message]
2017-08-29 17:01 ` Ard Biesheuvel
2017-08-30 13:26 ` Ard Biesheuvel
2017-08-31 13:35 ` Marcin Wojtas
2017-08-31 13:40 ` Ard Biesheuvel
2017-08-31 13:51 ` Leif Lindholm
2017-08-31 13:58 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPv3WKe+GV4SErbZS7Jy7Y_k9tgsfxqAsi5WPHuHex3+wgHQNQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox