From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6382221E2DA68 for ; Tue, 29 Aug 2017 08:50:24 -0700 (PDT) Received: by mail-io0-x22b.google.com with SMTP id k22so22011030iod.2 for ; Tue, 29 Aug 2017 08:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wKAS0cLr++GgFbEaB+8H+KOTSxQoKuOr5lvkCyqfdi4=; b=h5J05KLb0XzZdHS8VkPy8WG6opf8zLUqmnBqSw2xQofIv+ChrU8LXiTO2yKrgmgSPe JHedXq6OdJY1+rkgXlCiyZongyJZjcwH001OMt8I1+OqHkwLlP8Iwc4/OF1mycOYNoiw 104auV4X2+hFCjkDgeikFvdrWgWz4MXWd3DDt3u3Zyhpe8odrZQZ12MR2CdspNZVHmIF wt7UMU5BfaeCIgIambIQGwCI6hEGg54Gu1yVmbHte5EBYGACAobHFPmWw/8EZxdJRKTO g6Tl06u3kg6d+DDHP/3uDRYmbLMjdSI2yyoB1WQtQDNelngNSwIjlwimVpx5I+RW7+kh qibw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wKAS0cLr++GgFbEaB+8H+KOTSxQoKuOr5lvkCyqfdi4=; b=OE1n4Aw9HKOzdJl5YWJQWUXGb6b5hYkBXbbC5mtJ8VPAKLOGN018qRtG7SUAoOI0Id l4QVcu6xK36kdtBHMaZoE/u3/SFwGfe/c1nqRb5x2qxmAaovbJ3Qt4eBERTFbqOPNgHk ffyv+iU/mRiqbuXsMITIxio0TXGUaJrCJsPzvigp6ypBZfAwDfbha9eCMSIV2IOKvVCG XfTcm27DYxraQmY7cV6htwNSCNHwXipH9Uaf27zkHaodFMQNyh52OR7sZRdjL1kmrxnj p0ZrPx903gArumuM8cunxFFu6lgTp0t09xK5VCUBI/vsJ+YfyTxHXeSwH37P3i2kyrLd 5NRw== X-Gm-Message-State: AHYfb5j/3AvWpZ1rSPu55v4W6NqzspA5eo3tTEMkEcfd+SWJ/6CFOrHz LzZIu1B/DT8XofRhm8K5Ec7foukmtCZs X-Received: by 10.107.192.133 with SMTP id q127mr4281429iof.165.1504021984443; Tue, 29 Aug 2017 08:53:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.190.199 with HTTP; Tue, 29 Aug 2017 08:53:03 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 29 Aug 2017 17:53:03 +0200 Message-ID: To: Ard Biesheuvel Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 15:50:24 -0000 Content-Type: text/plain; charset="UTF-8" 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel : > On 29 August 2017 at 16:47, Marcin Wojtas wrote: >> 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>> Instead of hardcoding the non-cache coherent nature of this device >>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>> more abstract level. This allows the driver to be shared with >>>> platforms that are cache coherent (by simply switching to another >>>> DmaLib implementation), and removes the hardcoded dependency on >>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>> EDK2. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Ard Biesheuvel >>> >>> Ah, and there is the non-bogus fix :) >>> Reviewed-by: Leif Lindholm >> >> Please let me just run this on the HW before merge - I'll do it tomorrow. >> > > Sure. Note that you will need to sync EDK2 after I merged the DmaLib > changes (which I will do today) Ok, please let know once it's available and also it would be great if this patch could be shared via github repo. Thanks, Marcin