From: "Marcin Wojtas" <mw@semihalf.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>, dandan.bi@intel.com
Cc: Leif Lindholm <leif@nuviainc.com>
Subject: Re: [edk2-devel] [edk2-platforms] [patch V4 20/37] Platform/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Tue, 30 Mar 2021 15:58:05 +0200 [thread overview]
Message-ID: <CAPv3WKe1Qq6eznkh1nsERdzcGqVq-5LwLWt72tF8LibjW03bYg@mail.gmail.com> (raw)
In-Reply-To: <20210328131125.26788-21-dandan.bi@intel.com>
niedz., 28 mar 2021 o 15:12 Dandan Bi <dandan.bi@intel.com> napisał(a):
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Marcin Wojtas <mw@semihalf.com>
Thanks,
Marcin
> ---
> V4:
> New updated to consume the MdeLibs.dsc.inc for RegisterFilterLibNull in all dsc files.
> Rather than consuming MdeLibs.dsc.in Armada7k8k.dsc.inc.
>
> V3:
> Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common
> [LibraryClasses] section since we can specify different [LibraryClasses]
> section for libary instances in MdeLibs.dsc.inc.
>
> V2:
> Update Platform dsc to consume the MdeLibs.dsc.inc rather than
> consuming RegisterFilterLibNull instance directly.
> ---
> Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 ++
> Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 2 ++
> Platform/Marvell/Cn913xDb/Cn913xDbA.dsc | 1 +
> 3 files changed, 5 insertions(+)
>
> diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> index 0c2c7489f1..5df7498f71 100644
> --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> @@ -27,10 +27,12 @@ [Defines]
> DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> DEFINE NETWORK_ISCSI_ENABLE = FALSE
>
> !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>
> +!include MdePkg/MdeLibs.dsc.inc
> +
> [Components.common]
> Silicon/Marvell/Armada7k8k/DeviceTree/Armada70x0Db.inf
>
> [Components.AARCH64]
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf
> diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> index 40aeb62cfa..2698bd6573 100644
> --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> @@ -27,10 +27,12 @@ [Defines]
> DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> DEFINE NETWORK_ISCSI_ENABLE = FALSE
>
> !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>
> +!include MdePkg/MdeLibs.dsc.inc
> +
> [Components.common]
> Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0Db.inf
>
> [Components.AARCH64]
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf
> diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> index a754c3ea39..67355f3988 100644
> --- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> +++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> @@ -37,10 +37,11 @@ [Defines]
> DEFINE NETWORK_TLS_ENABLE = FALSE
> DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> DEFINE NETWORK_ISCSI_ENABLE = FALSE
>
> !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +!include MdePkg/MdeLibs.dsc.inc
> !include Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc
> !if $(CN9131) || $(CN9132)
> !include Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc
> !endif
> !if $(CN9132)
> --
> 2.18.0.windows.1
>
>
>
>
>
>
next prev parent reply other threads:[~2021-03-30 13:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 13:10 [edk2-platforms] [patch V4 00/37] Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 01/37] Drivers/ASIX: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 02/37] Drivers/DisplayLink: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 03/37] Drivers/OptionRomPkg: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 04/37] Features/Debugging: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 05/37] Features/Network: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 06/37] Features/OutOfBandManagement: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 07/37] Features/PowerManagement: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 08/37] Features/SystemInformation: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 09/37] Features/UserInterface: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 10/37] Platform/AMD: " Dandan Bi
2021-03-28 13:10 ` [edk2-platforms] [patch V4 11/37] Platform/ARM: " Dandan Bi
2021-03-31 2:59 ` [edk2-devel] " Sami Mujawar
2021-03-28 13:11 ` [edk2-platforms] [patch V4 12/37] Platform/BeagleBoard: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 13/37] Platform/Comcast: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 14/37] Platform/Hisilicon: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 15/37] Platform/BoardModulePkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 16/37] Platform/MinPlatformPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 17/37] Platform/QuarkPlatformPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 18/37] Platform/Vlv2TbltDevicePkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 19/37] Platform/LeMaker: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 20/37] Platform/Marvell: " Dandan Bi
2021-03-30 13:58 ` Marcin Wojtas [this message]
2021-03-28 13:11 ` [edk2-platforms] [patch V4 21/37] Platform/NXP: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 22/37] Platform/Qemu: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 23/37] Platform/RaspberryPi: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 24/37] Platform/RISC-V: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 25/37] Platform/SiFive: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 26/37] Platform/Socionext: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 27/37] Platform/SoftIron: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 28/37] Platform/SolidRun: " Dandan Bi
2021-03-30 13:57 ` Marcin Wojtas
2021-03-28 13:11 ` [edk2-platforms] [patch V4 29/37] Silicon/CoffeelakeSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 30/37] Silicon/IntelSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 31/37] Silicon/KabylakeSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 32/37] Silicon/QuarkSocPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 33/37] Silicon/TigerlakeSiliconPkg: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 34/37] Silicon/Openmoko: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 35/37] Silicon/RISC_V: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 36/37] Silicon/Synopsys/DesignWare: " Dandan Bi
2021-03-28 13:11 ` [edk2-platforms] [patch V4 37/37] Silicon/TexasInstruments: " Dandan Bi
2021-03-30 2:01 ` [edk2-devel] [edk2-platforms] [patch V4 00/37] " Michael D Kinney
2021-03-30 13:53 ` Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPv3WKe1Qq6eznkh1nsERdzcGqVq-5LwLWt72tF8LibjW03bYg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox