From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by mx.groups.io with SMTP id smtpd.web08.4972.1617112698318827346 for ; Tue, 30 Mar 2021 06:58:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=sqYqHPjC; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.222.172, mailfrom: mw@semihalf.com) Received: by mail-qk1-f172.google.com with SMTP id y5so15884433qkl.9 for ; Tue, 30 Mar 2021 06:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=T1jxQWLP/jBSPYzCRL8yFdoVQeQ6Ac+llYCNIEL8enA=; b=sqYqHPjCx8OhaFTPT4mcB34PLIfiSRiT2NO2i9xPmj1bVh62qVf+8pJCVXQ/6C2bpf Ggm37QGbN07hja+fkg1YeTKdt/ASeDw9SuyHEvmBFuSv41TDmmtf3Dtb02RiGazC1k70 HIaP3M4DL5mbqCJx/oTFRWzTDGw2gDacl3Bs215BsjOgmJYdXovpbMJiePBdGR+oOWhA DgbJbumO2FKG++vWZGkPvcQix6vJd3hnco/oznFesQyDl16j4/X9iZuj1zpDPhxrZ0qn AvX0wWyK3lw9JeQofTkYh5UzZp8P6RDrDvo0jp/tc1aJks3FkiyXpla89Aoamn3b4kDF tfUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=T1jxQWLP/jBSPYzCRL8yFdoVQeQ6Ac+llYCNIEL8enA=; b=fffiPYMx8OEjonQ3b3YtwQEVNxpIHD6m4bWimzybLTBcGpSvlY7ShKZxwgFdxzeUEh B8vxunY8D6hx1aw+YvpTKckAFo+rrn+Fxs82i6OYrLDl72f8i3Slpe6cDdBioQSrsrtE Eg0sFer4tA5tZmuv9h/wUI/fF5Eqw1GtXuwKtL/gR/oq6/bQ3KK67NMVM4sjito4SL++ ok+FWTHqIPkR8k1UGSZLqtAmxpNAKq6MnqKD4fEEMpW5TUgbIP4YGNg+KePm2k7jG5kZ rqb19Ly6zbQSBbDczXDAzv3L+mlZFd04/C+I4ZA2FF0IyRgqWtgxMgNvsXfYzj4wsUqw jRWg== X-Gm-Message-State: AOAM530wsiNYzrTGvBnRIwkCRznVajTESqX+ixzwc2Bi+Vej4GPnJnaE bkdafUYzQOnStIZ0LPlpTmWhjFJH3hgsShfGDsqrE84sJkZegsPp X-Google-Smtp-Source: ABdhPJy3ey3zLI+rckHO9EgUp/QCy2Bq6iB8p0wdYt6CgpbjhxCqgcy2d1j3Ot0KZvJiGKFq8gPMF4SoJRqxaZEc0Lo= X-Received: by 2002:a37:6243:: with SMTP id w64mr29380586qkb.295.1617112697387; Tue, 30 Mar 2021 06:58:17 -0700 (PDT) MIME-Version: 1.0 References: <20210328131125.26788-1-dandan.bi@intel.com> <20210328131125.26788-21-dandan.bi@intel.com> In-Reply-To: <20210328131125.26788-21-dandan.bi@intel.com> From: "Marcin Wojtas" Date: Tue, 30 Mar 2021 15:58:05 +0200 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms] [patch V4 20/37] Platform/Marvell: Consume MdeLibs.dsc.inc for RegisterFilterLib To: edk2-devel-groups-io , dandan.bi@intel.com Cc: Leif Lindholm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable niedz., 28 mar 2021 o 15:12 Dandan Bi napisa=C5=82(a)= : > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3246 > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Marcin Wojtas > Cc: Leif Lindholm > Signed-off-by: Dandan Bi Reviewed-by: Marcin Wojtas Thanks, Marcin > --- > V4: > New updated to consume the MdeLibs.dsc.inc for RegisterFilterLibNull in = all dsc files. > Rather than consuming MdeLibs.dsc.in Armada7k8k.dsc.inc. > > V3: > Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common > [LibraryClasses] section since we can specify different [LibraryClasses] > section for libary instances in MdeLibs.dsc.inc. > > V2: > Update Platform dsc to consume the MdeLibs.dsc.inc rather than > consuming RegisterFilterLibNull instance directly. > --- > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 ++ > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 2 ++ > Platform/Marvell/Cn913xDb/Cn913xDbA.dsc | 1 + > 3 files changed, 5 insertions(+) > > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/M= arvell/Armada70x0Db/Armada70x0Db.dsc > index 0c2c7489f1..5df7498f71 100644 > --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > @@ -27,10 +27,12 @@ [Defines] > DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE > DEFINE NETWORK_ISCSI_ENABLE =3D FALSE > > !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > +!include MdePkg/MdeLibs.dsc.inc > + > [Components.common] > Silicon/Marvell/Armada7k8k/DeviceTree/Armada70x0Db.inf > > [Components.AARCH64] > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/M= arvell/Armada80x0Db/Armada80x0Db.dsc > index 40aeb62cfa..2698bd6573 100644 > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > @@ -27,10 +27,12 @@ [Defines] > DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE > DEFINE NETWORK_ISCSI_ENABLE =3D FALSE > > !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > +!include MdePkg/MdeLibs.dsc.inc > + > [Components.common] > Silicon/Marvell/Armada7k8k/DeviceTree/Armada80x0Db.inf > > [Components.AARCH64] > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf > diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell/= Cn913xDb/Cn913xDbA.dsc > index a754c3ea39..67355f3988 100644 > --- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > +++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > @@ -37,10 +37,11 @@ [Defines] > DEFINE NETWORK_TLS_ENABLE =3D FALSE > DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE > DEFINE NETWORK_ISCSI_ENABLE =3D FALSE > > !include Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +!include MdePkg/MdeLibs.dsc.inc > !include Platform/Marvell/Cn913xDb/Cn9130DbA.dsc.inc > !if $(CN9131) || $(CN9132) > !include Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc > !endif > !if $(CN9132) > -- > 2.18.0.windows.1 > > > >=20 > >