From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by mx.groups.io with SMTP id smtpd.web09.1719.1628633558349817776 for ; Tue, 10 Aug 2021 15:12:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=eSRMpxhu; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.222.178, mailfrom: mw@semihalf.com) Received: by mail-qk1-f178.google.com with SMTP id w197so158567qkb.1 for ; Tue, 10 Aug 2021 15:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=B+XAWed2EVa3sNqiUtLKkPT6Gwe37PuiyUfNc3igPrs=; b=eSRMpxhuTN1Av63hZ9hJ4wLGPa88tAZIx9C4mansQkNpkW0CKXHXVPIkot+lv4OhM7 s4Ow7KXytC4IYhr9a5NqIDw0qVPRx84a+WvCyKuyaPce9NWtS2qgr+ruQ3DJEDhBtMrM Gg5CmObduWRGhuX6/x+ZO0YrxsGuN1SmgRlk9UohiWOd8qlCsX4BqP5jJ7AOmter3BIA s0+NlAi0/6Pe1WgwvXaAabgsj1G2rsZz4agLHod0vk6xA7/n7QuGfyYow1oao2BXJvHx lqyU32+zubHiJbPT07ov5pbYJcBwzxhJzLWG+sOjUfYO7cXmFteUX6aMryY/8X7HX0Md Ybyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=B+XAWed2EVa3sNqiUtLKkPT6Gwe37PuiyUfNc3igPrs=; b=aPhExwFoEsdXQ+taJZu0n5Oa+WD23AVtp2KEH6RrFzAcuItEiVQl7dKx1YtuXzBKlN ICgBxKfXyWMBh4eU09VAmbMgXkslZZyE4u7y6PUk/14C+3GdPMnbkMbYcnGajOdsb1FQ dUIJSWihi0K35nRpo6EffsqD8PzL1aBGBoOoKEEuqpTw+xT42gaSQ9I7HgUhWErSHfCS Qiiqy6OB4r7LJng9uKqiSzs25cB4GkZlGNrPa3TG6Ltrsg13vUyrH62UffX+Uyz/csSG DEe8N9LhnAUdgHF3XUYgGprKLPMPVw/8HvoMPybesMPoM77aLd4wmYLccw1vZVooRyBw B3RQ== X-Gm-Message-State: AOAM531d5IbF3uEKdgrUpOunGiCOv3NhkXU0GFnMSdYoUXYwNLl/XEAz sv3t/SM1SXUPJqiDTq3h7m8ZW3lpDpMaXrq7kEx9AA== X-Google-Smtp-Source: ABdhPJyaelRSRCf/zmu6Ov3DhWjxwNdhFd8yIgWsCLJbPRBc+ZbDLTDeSAnwMlS+teOh68hm8YHwunRV4YSVnjr3yNg= X-Received: by 2002:a05:620a:1311:: with SMTP id o17mr17434618qkj.295.1628633557370; Tue, 10 Aug 2021 15:12:37 -0700 (PDT) MIME-Version: 1.0 References: <20210719093015.1490932-1-mw@semihalf.com> <20210719093015.1490932-3-mw@semihalf.com> In-Reply-To: From: "Marcin Wojtas" Date: Wed, 11 Aug 2021 00:12:24 +0200 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: Add missing _STA methods in ACPI tables To: Ard Biesheuvel Cc: edk2-devel-groups-io , Samer El-Haj-Mahmoud , Leif Lindholm , Ard Biesheuvel , Grzegorz Jaszczyk , Grzegorz Bernacki , "upstream@semihalf.com" , "Jon (jon@solid-run.com)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, wt., 10 sie 2021 o 16:41 Ard Biesheuvel napisa=C5=82(a): > > On Tue, 10 Aug 2021 at 16:36, Samer El-Haj-Mahmoud > wrote: > > > > Apologies for the tardiness in replying to this. Please see my comments= below. > > > > > -----Original Message----- > > > From: Marcin Wojtas > > > Sent: Friday, July 30, 2021 5:57 AM > > > To: Ard Biesheuvel > > > Cc: Samer El-Haj-Mahmoud ; edk2- > > > devel-groups-io ; Leif Lindholm > > > ; Ard Biesheuvel ; > > > Grzegorz Jaszczyk ; Grzegorz Bernacki > > > ; upstream@semihalf.com; Jon (jon@solid-run.com) > > > > > > Subject: Re: [edk2-platforms PATCH 2/7] Marvell: Armada7k8k/OcteonTx: > > > Add missing _STA methods in ACPI tables > > > > > > Hi Ard, > > > > > > czw., 29 lip 2021 o 11:58 Ard Biesheuvel napisa=C5= =82(a): > > > > > > > > On Thu, 29 Jul 2021 at 11:46, Marcin Wojtas wrote= : > > > > > > > > > > Hi Ard, > > > > > > > > > > pon., 19 lip 2021 o 17:06 Marcin Wojtas napisa= =C5=82(a): > > > > > > > > > > > > Hi Ard, > > > > > > > > > > > > pon., 19 lip 2021 o 11:54 Ard Biesheuvel napi= sa=C5=82(a): > > > > > > > > > > > > > > On Mon, 19 Jul 2021 at 11:31, Marcin Wojtas > > > wrote: > > > > > > > > > > > > > > > > BBR 1.0 spec says that _STA is required for each device in = DSDT or > > > SSDT. > > > > > > > > Fix that for all platforms with the Marvell SoC's. > > > > > > > > > > > > > > > > > > > > > > Can we fix the BBR instead? If ACPI itself does not require _= STA, BBR > > > > > > > should not require it either. > > > > > > > > > > > > > > > > > > > > > > > > > > I consulted with ARM on the matter. SBBR has requirements of th= ings > > > > > > that are otherwise optional in UEFI/ACPI/SMBIOS. Also some OS's= may > > > > > > require that and I can see those methods in most of the other A= CPI > > > > > > source files in the edk2-platfoms tree. I think the BBR require= ments > > > > > > discussions can follow, but it would be great if this change ca= n be > > > > > > applied, so that no to block other development. > > > > > > > > > > > > > > > > Do you have any feedback to the patchset and the _STA methods > > > concerns? > > > > > > > > > > > > > Yes. I would like to understand why _STA methods are now mandated b= y > > > BBR. > > > > > > > > > > Understood. Providing an answer may not be immediate and may possibly > > > require further discussion on the SystemArchAC level. > > > How about we withdraw this single patch for now and process the > > > remaining ones? We would come back to the _STA subject, as soon as > > > there's more information available. > > > > > > Best regards, > > > Marcin > > > > > > > _STA has been required in SBBR since ver 1.0 (published 2016, with the = 0.9 draft since 2014) > > https://developer.arm.com/documentation/den0044/b/?lang=3Den > > > > I do not have the history on why SBBR 1.0+ requires _STA, but it most l= ikely has to do wit the Windows strong use case for it: https://docs.micros= oft.com/en-us/windows-hardware/drivers/bringup/device-management-namespace-= objects#device-status-changes . Windows is a key OS targeted by SBBR. > > > > OK, I stand corrected again :-) > > Marcin, > > I won't object further to these additions -please respin the patch on > top of current edk2-platform and I will apply it right away. I resubmitted: https://edk2.groups.io/g/devel/topic/edk2_platforms_patch_v2= /84804301?p=3D,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,84804301 In a spare moment I'd appreciate taking a look at '[edk2-platforms PATCH v2 0/4] SolidRun CEx7 Evaluation Board support' patchset :) Thanks, Marcin