From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=cwRVt9Zi; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.222.195, mailfrom: mw@semihalf.com) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by groups.io with SMTP; Wed, 26 Jun 2019 23:25:40 -0700 Received: by mail-qk1-f195.google.com with SMTP id c11so770967qkk.8 for ; Wed, 26 Jun 2019 23:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cyl8KTMfbR3WmffTet5ipCq7g0AZvP+QOhKcvTlUZmg=; b=cwRVt9Zi8i4mWKMTh4l2SiID2Mf8fNlKvpHbQXMc8/VhCEcu0mZ0jSmChsUCiqs3CE qVZVsFULgzTfFLjWJn+Jfs+W5+cIPlkiXhgKdOb838icCYIOIcC0OP+yCACU/HmIMTKb hduFRBjSDYaS9uU18TmRcNAvvGwBgN6Oq2/S0PHyUJZiKcSLd7tfSWQKGpintvxvzGmo pjxv3OcqqSDkRefxbiuUBaIRPg53R+xIhWghIgjPOaEoTfV+0jbL4QrMM0kDS+kYIvGJ sIdtzZ1DQ1WI1wIrTTKYIJaqEie6R4+9bcQ/uJB4CaEbBLM4h7jUTNjgLITaSbxNZaLb fgaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cyl8KTMfbR3WmffTet5ipCq7g0AZvP+QOhKcvTlUZmg=; b=Nc96AE3heNdatbA2wSjsD6VgXHKXJ5/ArNUWjK4tdC7M+EM10F4oWVrHJ0eRLIcnaF vJpsnOMmySHmRPVV/PIbMeo3Gkr/PhhysUeJ65awwka1GVWABIcLj+wHua+r/ZczCYI5 yttaiX0NRvf3mKzmG2sXQnUKBXQpv/sj3LqTJmgRFZCUy+YxQhBFI7GzrK9263ywGis8 EafJOmsTDIC5MKbInf9ZcGuANdBWc2EvvK616xAX2TO5fNw2Wb3n8bjWaZjhfTEIwF1m SuHlm3v7EGAt9gpoRIig5yju4I6yiyiZiOzuB5ymmMeNjqSaC69XmldKTGSPVI/zjKI0 8G+w== X-Gm-Message-State: APjAAAW/XfqyDFLNoRSEZx7KjO7QhqBA0zm8t/B6O04GHYFc2OONLsjQ zS1SAi80+dgq/1tN0HqWhT0q6mlj6Xrqe1i3RmrGVA== X-Google-Smtp-Source: APXvYqztpcS9lT0lPQcL8at+7aUSL5sozINi9XMCMxdBWt9fhGZS3XWBb2oWyM/GrFGNQIrG+09sfGoUxU8S41QRw4U= X-Received: by 2002:a37:56c5:: with SMTP id k188mr1757353qkb.109.1561616738935; Wed, 26 Jun 2019 23:25:38 -0700 (PDT) MIME-Version: 1.0 References: <20190626131003.3088-1-mateusz.albecki@intel.com> In-Reply-To: <20190626131003.3088-1-mateusz.albecki@intel.com> From: "Marcin Wojtas" Date: Thu, 27 Jun 2019 08:25:26 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol To: "Albecki, Mateusz" Cc: edk2-devel-groups-io , Hao A Wu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Mateusz, Can you please push those patches somewhere (github?) so that I can easily do a quick check for regression? Thanks, Marcin =C5=9Br., 26 cze 2019 o 15:10 Albecki, Mateusz napisa=C5=82(a): > > To allow platform greater control over the bus settings for SD card and = eMMC card we have added a new notify phase to SdMmcOverrideProtocol called = GetOperatingParam. > This phase is signaled before SD card/eMMC initialization and allows pla= tform to tweak the values in new structure called EDKII_SD_MMC_OPERATING_PA= RAMETERS which allows to configure bus width, clock frequency and driver st= rength. > Other bus parameters can be configured by overriding host controller cap= abilities. > > Changes in v2: > - Fixed stylistic issues and documentation issues pointed out in v1 revi= ew > - Changed bus width to be UINT8 > - Reordered the SD_MMC_BUS_MODE to fix problem with driver never choosin= g the DDR50 speed mode > - Fixed the bug with driver not switching the controller into correct dr= iver strength for SD card slots > - Fixed bug with the driver not considering driver strength support for = SD card slots > - Fixed bug with driver choosing SdMmcMmcHsSdr if card doesn't support f= requencies above 26MHz > - Fixed bug with driver choosing driver strength for legacy speed modes > > Changes in v3: > - Changed BusWidth field of EDKII_SD_MMC_OPERATING_PARAMETERS to UINT16 > > Changes in v4 > - Fixed typos and ordering in SD_MMC_BUS_MODE(this time for real) > - Fixed non boolean types usage in if statements > - Fixed code that checks if there was an error in switch response for SD= card. The code has been updated to check if switch failed due to function = being busy > > Tests: > - OS boot from eMMC without SdMmcOverride protocol installed > - OS boot from eMMC with SdMmcOverride installed and clock frequency low= ered to 100MHz in HS200 > - OS boot from eMMC with driver strength changed to Type1 > - OS boot from eMMC in HS400 without override protocol installed > - SD card enumeration in UEFI shell on default speed and high speed(non = UHS-I) with SdMmcOverride installed and UHS-I disabled in capability > - SD card enumeration in UEFI shell on default speed and high speed(non = UHS-I) with no Override protocol(legacy card used) > > > Cc: Hao A Wu > > > Albecki, Mateusz (1): > MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol > > Mateusz Albecki (1): > MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 512 ++++++++++++++= +------ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 410 ++++++++++++++= --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 52 ++- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 18 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 34 ++ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 19 + > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 60 ++- > 7 files changed, 867 insertions(+), 238 deletions(-) > > -- > 2.14.1.windows.1 > > -------------------------------------------------------------------- > > Intel Technology Poland sp. z o.o. > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII W= ydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52= -316 | Kapital zakladowy 200.000 PLN. > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adres= ata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej= wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jak= iekolwiek > przegladanie lub rozpowszechnianie jest zabronione. > This e-mail and any attachments may contain confidential material for th= e sole use of the intended recipient(s). If you are not the intended recipi= ent, please contact the sender and delete all copies; any review or distrib= ution by > others is strictly prohibited. > > >=20 >