From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E52F82170 for ; Thu, 23 Feb 2017 09:34:27 -0800 (PST) Received: by mail-it0-x22d.google.com with SMTP id 203so7860708ith.0 for ; Thu, 23 Feb 2017 09:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RIudiy6U5J5pJTxnQqpu8PHzCR3P6vVnnGaYq5iqXpg=; b=eUIMvxQUbplb288r4LGrbl1pN51AQCDCugdWd6kUx4Tntnx7nbc6aQXs2Stafajolf izRO38yxVn5Q0qrVw8nmm3TGMs6VxKbTVDb1fOH/x+SMsFiEZqQ6C690VNuScEHv6ct9 Za0ntZMiJpylbImj5bYaD4eAK1+/R/KgWEd92gy0YNPI1aIYgwCf4FR+lLYOUtIfBV+c hFJix9GWuoP+NSl+CLsSNpXR5f5cie6ckwf09dVbUK7zXMjGPE8372rLnHuxc0zUcaNe y0o5j3klGUslwhAhKMi9UCsONuaiK0jk3SA3d76P1X4zm2Gtxs093vgWelrC0eWRGNGn mn4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RIudiy6U5J5pJTxnQqpu8PHzCR3P6vVnnGaYq5iqXpg=; b=Mx1IxLWkx2RAD0Ygi1Gg58e6D3AKqDQ3UONmQWU8N6YDfhf+0uuwxu29czKj7LhcEY uSRuQJ7mj8Mp1eHYql0Oji/tu/PR6BRAv9CBztXJzEJucaZC+Jy4mtwtBslju4sSnjc3 5P8nxg7lxRRSWUus78zNVoAsvRQq5GtZYEIPNGfKolo+WKDfbdVRElEmNFW5uxSbmM3Q hbDUVxcLAWPTA6Yo6zSP11x0otCPw2RPjFRflHWHSd22TgFqqLnSBv2h8eXz87Pph7t1 sVU3xPltU1ooaLpwGODA3tvTBw5FvPIc8X1ykoarvHC+b6KextCl52ClnhdYraIw0m4A Wt5Q== X-Gm-Message-State: AMke39kFDyj1DCWUOa5HOsqcFkAv2Q2zTbTdRG/k00B5ja4LzurJPxCKeTVGhkQv/Voy4yT116hCVvy5v9RKbw== X-Received: by 10.36.105.193 with SMTP id e184mr3767298itc.13.1487871265452; Thu, 23 Feb 2017 09:34:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.169.96 with HTTP; Thu, 23 Feb 2017 09:34:24 -0800 (PST) In-Reply-To: References: From: Marcin Wojtas Date: Thu, 23 Feb 2017 18:34:24 +0100 Message-ID: To: Ard Biesheuvel Cc: edk2-devel-01 , "Tian, Feng" , "Kinney, Michael D" , Leif Lindholm , semihalf-dabros-jan , "Gao, Liming" , "Zhu, Yonghong" Subject: Re: DxeCore assert during initialization X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 17:34:27 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ard, 2017-02-23 18:17 GMT+01:00 Ard Biesheuvel : > On 23 February 2017 at 17:16, Marcin Wojtas wrote: >> Hi, >> >> I use Marvell Armada70x0 from mainline OpenPlatformPkg. After updating >> baseline to newest tianocore master branch it turned out that the >> platform fail to boot due to following assert: >> >> /home/mw/git/edk2/Build/Armada70x0/DEBUG_GCC48/AARCH64/ArmPlatformPkg/Pr= ePi/PeiMPCore/DEBUG/ArmPlatformPrePiMPCore.dll >> 0x1800 >> add-symbol-file >> /home/mw/git/edk2/Build/Armada70x0/DEBUG_GCC48/AARCH64/MdeModulePkg/Core= /Dxe/DxeMain/DEBUG/DxeCore.dll >> 0x3F534800 >> Loading DxeCore at 0x003F534000 EntryPoint=3D0x003F534800 >> >> ASSERT_EFI_ERROR (Status =3D Invalid Parameter) >> ASSERT [DxeCore] >> /home/mw/git/edk2/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerf= ormanceLib.c(523): >> !EFI_ERROR (Status) >> >> I bisected edk2 master branch and confirmed that the problem appeared >> with commit dc4c770763d0 ("BaseTools: add error check for Macro usage >> in the INF file"). >> >> There are no errors, nor warnings during BaseTool and platform builds. >> Is it a known problem? Any idea about possible root cause? >> > > Already fixed in > 1d8cebf91040 BaseTools: Fix the regression issue caused by commit dc4c77 Thank you for very fast response. The fix indeed helps. Just for the notice top of the master fails to build due to commit cfb0aba7934b ("MdeModulePkg: Add performance property configuration table"). /home/mw/git/edk2/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerform= anceLib.c: In function =E2=80=98DxeCorePerformanceLibConstructor=E2=80=99: /home/mw/git/edk2/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerform= anceLib.c:538:3: error: passing argument 2 of =E2=80=98EfiGetSystemConfigurationTable=E2=80= =99 from incompatible pointer type [-Werror] Status =3D EfiGetSystemConfigurationTable (&gPerformanceProtocolGuid, &PerformanceProperty); ^ In file included from /home/mw/git/edk2/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerform= anceLibInternal.h:35:0, from /home/mw/git/edk2/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerform= anceLib.c:26: /home/mw/git/edk2/MdePkg/Include/Library/UefiLib.h:135:1: note: expected =E2=80=98void **=E2=80=99 but argument is of type =E2=80=98struct PERFORMANCE_PROPERTY **=E2=80=99 EfiGetSystemConfigurationTable ( ^ cc1: all warnings being treated as errors make: *** [/home/mw/git/edk2/Build/Armada70x0/DEBUG_GCC48/AARCH64/MdeModule= Pkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib/OUTPUT/DxeCorePerfo= rmanceLib.obj] Error 1 I'll stick to one revision and won't move from now on:) Best regards, Marcin