Re: [edk2-platforms: PATCH v2 0/4] Armada 7k8k network improvements

["Marcin Wojtas" <mw@semihalf.com>]

śr., 8 maj 2019 o 19:52 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> On Mon, May 06, 2019 at 04:37:03AM +0200, Marcin Wojtas wrote:
> > Hi,
> >
> > The second version of the patchset addresses all comments from
> > v1 review. Details can be found in a changelog below.
> >
> > The purpose of this patchset is to fix possible hangs when attempting
> > to PXE boot on unconnected interfaces (1/4). Patches 2-3/4
> > extend MvPhyDxe with support for another Marvell PHY model (88E1112).
> > The last patch is a small fix, removing redundancy of soft resetting
> > of the network PHYs during initialization.
> >
> > The patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/net-upstream-r20190506
> >
> > I'm looking forward to your comments or remarks.
>
> For series
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> I added Ard's Acked-by to 3-4/4 which he expressed acceptance of
> before.
>
> Pushed as 747e75cc3e..d83f1ca097.
>
> I will add that while compile testing this set with clang, I came a
> cross a compilation error:
> /work/git/edk2-platforms/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c:1083:6: error: variable 'NumBytes' is uninitialized when used here [-Werror,-Wuninitialized]
>     *NumBytes = FlashInstance->FvbSize;
> It is also reproducible with GCC, but only when building NOOPT.
>
> This change was introduced by
> cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode").
> Could you provide a fix for that please?
>

Patch sent, thanks!
Marcin

> Best Regards,
>
> Leif
>
> > Best regards,
> > Marcin
> >
> > Changelog:
> > v1 -> v2:
> > * 1/4
> >   - change SB in commit message
> >   - add STATIC
> >   - add full error handling for Snp.GetStatus in Pp2AipGetInformation
> >   - use normal 'if' instead of ternary in Pp2AipGetInformation
> >   - fix typos in comments
> >   - use AllocatePool and CopyGuid in Pp2AipGetSupportedTypes
> >
> > * 2/4
> >   - Add space in gBS->Stall call
> >   - s/Improve/Refactor/ in commit message
> >
> > Marcin Wojtas (3):
> >   Marvell/Drivers: MvPhyDxe: Refactor 88E1510 initialization
> >   Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
> >   Marvell/Drivers: MvPhyDxe: Reset PHY only once
> >
> > Tomasz Michalec (1):
> >   Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol
> >
> >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf   |   1 +
> >  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h |  17 +-
> >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h     |   3 +
> >  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 111 +++++++++----
> >  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c     | 166 ++++++++++++++++++++
> >  Silicon/Marvell/Documentation/PortingGuide.txt  |   7 +-
> >  6 files changed, 274 insertions(+), 31 deletions(-)
> >
> > --
> > 2.7.4
> >