From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39DE12112998E for ; Wed, 12 Sep 2018 00:28:47 -0700 (PDT) Received: by mail-it0-x241.google.com with SMTP id h1-v6so1725788itj.4 for ; Wed, 12 Sep 2018 00:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YgChbWks5FJ3SLsH4XR56R/fNqOqadKxxtQN0x4oQHY=; b=S+oPq2gnGJRgUsnleC3/LqSAFsVKq7HB3xHis3bCX97b7RHteYtxgYVCvaBx35ZI7o z9jS1f9A8Od6DA+kdm8lnrCm9Tq18b1I5V+M3Wt8B3XJo3PJ8+B4xek4bEwUEoReO897 aUhu7b+kLHhX73V6UejwUNBszPkEAulncA4ykF9YMIWtL9FWBkPqK5ZZD0zHQAGV3V9H cYfBOkXDQzkRda2rY4tx/8ChFqQKrl0B2I4ytaenNTBhUdPF/8GmHj+Q/cYsUPHGewNX cVjRCb+8RiDlLiCW2g+7A2mkFvVVixpfWAwx7zak9Ih+5R1JU16Ukdr88H5rlc0l+VG/ iD0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YgChbWks5FJ3SLsH4XR56R/fNqOqadKxxtQN0x4oQHY=; b=LzsKcOPZY7AoDW2/cNZSyYn0hY7YjcxkpwOOm95cpB4lXLKfLA3FqWElvgQTVvyKhy cL1nJ9OXayPeg34qOBc6eVpFnwuaFEruv4UBcB60uZJ1VNIcofJtQu3jrDXhfQoZ6O1B xWSZ5PL/O/vixVsXDLcRbbL75qqbcQ6Jpb0VSezXjfsrNKXStIkpu2ynnlR6UOVCGNaI CoZpAxGvJ3CYKUfUjlSVoCIdYaxwhJEzTiO7LI7G/LnZU7H/KOKbD2XffxaHqNkQuONL RvhYwqYdLFJC2TqH2R7Yj+fvyoQw152WCjbv1L48M0iEA+7l0qWflfkAJseyUrXeffW4 mc+Q== X-Gm-Message-State: APzg51BChpWM7Ixvch2L4qCTO5cChtCVns6tqfikhyStHEnEsJ0IWRcc iiJL3reNo/epBtxgsQA8AZLVs5mJfUszb7V3+Hg1J43af70= X-Google-Smtp-Source: ANB0Vdb1uBRVJSjQKv3HXmBVveYrfK9QWQhBYnVqwyzel8sJNoUeKT6zIfEgPHL8Kf5rLWFZ3fenmoXSTJyTmFNVkcE= X-Received: by 2002:a24:e084:: with SMTP id c126-v6mr722420ith.136.1536737325995; Wed, 12 Sep 2018 00:28:45 -0700 (PDT) MIME-Version: 1.0 References: <1536311416-2751-1-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Wed, 12 Sep 2018 09:28:34 +0200 Message-ID: To: edk2-devel-01 Cc: hao.a.wu@intel.com, Ard Biesheuvel , "Tian, Feng" , "Kinney, Michael D" , "Gao, Liming" , Leif Lindholm , nadavh@marvell.com, "jsd@semihalf.com" , Tomasz Michalec X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH v2 0/4] SdMmc fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 07:28:47 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, So far there was one minor remark from Ard (about macro definition) - I would appreciate any comments before I can submit v3. Thanks, Marcin pt., 7 wrz 2018 o 13:04 Ard Biesheuvel napisa=C5=82(a): > +Hao > > On 7 September 2018 at 11:10, Marcin Wojtas wrote: > > Hi, > > > > Answering the review request, I extracted SdMmcPciHcDxe driver fixes > > from SdMmcOverride protocol modification. Comparing to v1, > > patches are rebased onto the newest master branch and also a macro > > is used instead of the raw value in SdMmcHcReset. > > > > Patches are available in the github: > > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/s= dmmc-fixes-r20180907 > > > > I'm looking forward to the comments and remarks. > > > > Best regards, > > Marcin > > > > Changelog: > > v1 -> v2 > > * rebase on top of the newest master > > * resolve conflicts after taking fixes out from new features > > * 3/4 - use macro instead of raw value in SdMmcHcReset > > > > Marcin Wojtas (3): > > MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation > > MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence > > MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlo= t > > > > Tomasz Michalec (1): > > MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bit= s > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 10 +++++ > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 39 > +++++--------------- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 18 ++++++--- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 +-- > > 4 files changed, 34 insertions(+), 39 deletions(-) > > > > -- > > 2.7.4 > > >