From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3DC832217CE46 for ; Fri, 8 Dec 2017 04:06:54 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id t1so4381165ite.5 for ; Fri, 08 Dec 2017 04:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Rcxp0MnUzp6LqaG4lGIKunRVFcjKV8WCUrz25x5ETiE=; b=wXrxppilsUy6AD/jwJ5dAWyogk9Ms7f4MbDS9Tb5UvljXMvmKPE8hTUUQb6xOpdmQa 0tcD/O4UJH+Z2d22tVu3/ZyP+D7DAYomN974WB7nocL9pkmqBso/myR2ssVNw73NnE0m LwW2jmH6Fmj/jMUX3cUn57R3DSPQywJn4/+5EP3IRUYjHaIotr1TzJfAg0fIBUul6uRN sJxMgNZv91ESZEFWcFXm9DnFsTlrRFs2ek0jtq0R1MN3LcDmXof+9fBb8Qre5mccphda wXmaSbVVDyt9jGYFmOUam9cBtyIw1+0dd/q5kHxnsARDsGxocaGV5resggD7XMheiMXf TgWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Rcxp0MnUzp6LqaG4lGIKunRVFcjKV8WCUrz25x5ETiE=; b=cCin0XRxcAGNZkzYvOmrJPJ9z80QJu9gii0Bl8WylFbIB/gUxk1n64YGiUzHM6f4Qx o9t+/r7/oEp4iZrb7S24v2sH3sqFUFrRtTUpHpJepZFQ/SifEfBDMxeZUm7H98X6QKVm rCdoyEsXNmf75pa8R8R9AEOT+U/ulojdGRArLLDAl3snQZTbH2nAAsFqkFTP/q5lYRGU GmzsKydO1uH4lx6QwUZtNReZLl8KAp1kTxdlSAgNIp3ghB8amJ0lLdXgsuK9eqaINzTH xxnZzMUSZG+jWqWBhHNaEnJyUjof5CL6900Ms/NDA7biCWCriid8vsi1rg58U35sR5s2 O9NQ== X-Gm-Message-State: AJaThX6Mg+HbeXA7vCXRf63K/p1LUTnPN9P3u0cR9jbss+SyS1NRq91s HL9QozJCSPPj9aMt8KxB49EvDh4kqurKZPC91IgdVA== X-Google-Smtp-Source: AGs4zMYHnoPyluAhB+ghzpUmfP6YxFMfF1TSm2CUzRyF74LWCMpb/beu4YxToMwyVWcjJqWrIlsj+VaUXi/MFPuT8nI= X-Received: by 10.107.20.21 with SMTP id 21mr42913849iou.116.1512735088519; Fri, 08 Dec 2017 04:11:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Fri, 8 Dec 2017 04:11:27 -0800 (PST) In-Reply-To: References: <1512674434-32326-1-git-send-email-mw@semihalf.com> <1512674434-32326-6-git-send-email-mw@semihalf.com> From: Marcin Wojtas Date: Fri, 8 Dec 2017 13:11:27 +0100 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Konrad Adamczyk Subject: Re: [platforms: PATCH v2 5/5] Marvell/Drivers: Drop 'PciEmulation' naming X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 12:06:55 -0000 Content-Type: text/plain; charset="UTF-8" 2017-12-08 9:40 GMT+01:00 Ard Biesheuvel : > On 7 December 2017 at 23:08, Marcin Wojtas wrote: >> Hi Ard, >> >> 2017-12-07 20:49 GMT+01:00 Ard Biesheuvel : >>> Hi Marcin, >>> >>> On 7 December 2017 at 19:20, Marcin Wojtas wrote: >>>> 'PciEmulation' is not a proper naming for a driver, which >>>> uses NonDiscoverableDeviceRegistrationLib for handling >>>> the devices attached via internal bus of the SoC. >>>> Rename it to MvNonDiscoverableDxe and move under >>>> Silicon/Marvell/Drivers directory. >>>> >>> >>> Thank you! >>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Marcin Wojtas >>>> --- >>>> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 4 +-- >>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 +-- >>>> Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} | 26 ++++++++++---------- >>>> Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} | 8 +++--- >>>> 4 files changed, 21 insertions(+), 21 deletions(-) >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} (84%) >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} (91%) >>>> >>> >>> Could we please have >>> >>> Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf >>> >>> instead? >>> >> >> My intention was to keep a generic naming at the first level inside >> the Silicon/Drivers/Marvell: >> I2c Net SdMmc Spi >> >> I can change it in a way you want, but to my taste >> MvNonDiscoverableDxe doesn't fully fit the company above. Do you see >> any possible compromise? :) >> > > Well, if you want 'generic' at the level below > Silicon/Drivers/Marvell, you will still need > MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf below that. > > So > > Drivers/NonDiscoverable/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf > > perhaps? This is ok to me. Thanks, Marcin