From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F88B21106F2B for ; Mon, 11 Jun 2018 05:04:17 -0700 (PDT) Received: by mail-io0-x243.google.com with SMTP id k3-v6so9522189iog.3 for ; Mon, 11 Jun 2018 05:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2fwgK+VDFeBZ0bsIdjx2pJUdJWWE0bVI++CtIYBzTXM=; b=gy9tLAHGct5W79opBXBCxU6cLG0E07jI1xsQ2rjRKUFm4ipIPrk25rnOrPzws23EeX mvwW8ITMJkPvTQZ2N8hd1KAA4+3T8txkEKmjV+txVQNnk0QwKWSYDr1R9wEoXOJpgthr 2qY0GOHGbiCd/a75WT4udGipu9b47o6edKPVB3jNIhRhLguSbrErfCgRn+nzwgT9fJK3 xAMDDCrVHGZROm45m9/1+NDxilOenDBeL/pmoOeKkxYoL+01vs54dY9PzmBXkXd0CFzq ly/zlrz70mdTUFmbNPRemVpfVvfo0uYoCu1XR3oUUkbdLruMcfhdfAUvylf2F7i4tXOT lsbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2fwgK+VDFeBZ0bsIdjx2pJUdJWWE0bVI++CtIYBzTXM=; b=JCmmtt4QTfcRG+IecSx8Tit6Xe8ux8H20gGcm7r5tA4xsFCeYYoYAtt+ncN1Hr0XnP wlS4yl4h92/iMP+QQZXifVfGTr9fTiIctfXMagCT4RkAJZGvCZJQNLgDSUJ2Mea9RdYo vFA+/cVGDl1KvhX3t+b1MFqF74efXkm4wigXtdzBdBtBseOFNFzY97+eoVrCklCui6hz q0m8AHpGUS5P1wDtegV2cDnHhMMOj4u4VyU9aLSBg7qsr91zAJ8QgQvVIFYYOByskl6u OTk4Bxm/b/3pbFoQs4hP/FNmeBWZo1SOhQXHgO3YlC+YI2tARs5V+f0dWHb0zsS0QNbu NifQ== X-Gm-Message-State: APt69E3ZAi+4d3pqEC7iM8+XQDKIeEAUxR7rBUIm1Nv4Dbio/QAibwyi vn9331aap4Yk2WeiR0rbITtjRaAkhVQLwGaEA9q298/u X-Google-Smtp-Source: ADUXVKJtNkwssDAixQXdjGyoykfoBDP6KRj6RLPVVINslXRcFVIvVVcDw+/VctZy4n8PmfJMG3eJYn8SSPNMe8RzXeo= X-Received: by 2002:a6b:8e96:: with SMTP id q144-v6mr6003200iod.248.1528718656670; Mon, 11 Jun 2018 05:04:16 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:c6cc:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 05:04:16 -0700 (PDT) In-Reply-To: References: <1528472063-1660-1-git-send-email-mw@semihalf.com> From: Marcin Wojtas Date: Mon, 11 Jun 2018 14:04:16 +0200 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Hua Jing , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms PATCH 00/25] Armada herdware description rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 12:04:17 -0000 Content-Type: text/plain; charset="UTF-8" Hi Ard, 2018-06-11 14:01 GMT+02:00 Ard Biesheuvel : > On 11 June 2018 at 13:49, Marcin Wojtas wrote: >> Hi Ard, >> >> 2018-06-11 13:00 GMT+02:00 Ard Biesheuvel : >>> Marcin, >>> >>> I am a bit reluctant to review another huge set of Armada patches >>> while we are still waiting for MacchiatoBin support to land. The only >>> hardware i have access to is MacchiatoBin, and it has been well over a >>> year now that MacchiatoBin support has been between 'under >>> construction' and 'about to land any day now'. >>> >>> The patches in this series actually carry traces of McBin support, >>> which suggests to me that they were taken from an internal tree that >>> does support MacchiatoBin, but it has been removed. What is that >>> about? >> >> MacchiatoBin addition is on top of those patches in the branch I >> prepared solely for upstream. Anyway, I understand your point and >> let's skip this big patchset for now. I will submit support for other >> boards, once it's accepted, let's return to this one. >> > > > Patch 5/25: > > """ > From: jinghua > > This patch enables compilation of MvBoardDescDxe driver for > Armada70x0-DB, Armada80x0-DB and Armada80x0McBin. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: jinghua > Reviewed-by: Kostya Porotchkin > """ > > So this patch clearly contained MacchiatoBin support at some point, > but you removed it before upstreaming the patch. That really makes me > sad. Yes, I inverted the order of the patches when cleaning the branch. I wanted to add the whole new boards support in a minimal possible way, but that clearly wasn't best idea. Nvm, I'll submit new board now. > > BTW can you please drop the @marvell.com Reviewed-by tags, and add > your own Signed-off-by to patches that you did not author yourself? Sure will do. Thanks, Marcin