From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B56002217CE3E for ; Fri, 8 Dec 2017 06:09:21 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id r6so4983931itr.3 for ; Fri, 08 Dec 2017 06:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=COQ9gywRZMGE44H6gV7JD0kB1VkOdEcO6nmHPVdPAzM=; b=dC2b/mmlhxTD4lUuMb1L7DZgSFGjrKgxZOuY1q0163BSWXf7CPMGMRU7Mr35LTDux4 OkEUqBKiD+Dp+Wg+OThSSC1XdKPO194Xd3O2Sz9K00Lmnn1p0irXeGXVVaLUNrt72E/J PUCuMWlDpf9NmSq0vgZBXEYtEs6oa57DFypLXXTNHGi5+45C711eim1Q7zw8s+Vtp7sa woqxDf0R1yLmne20786QaS7WpFD2t5a2AUJktGA3uNrYhPo9cje09YHK6tN+a6GUJEp2 G5Bvya5xRgAC/Rbyl7kfuh31ragwhkD6J75rFqTvK/1CA5SPruMkS//wM5XLqorBvwAB J6oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=COQ9gywRZMGE44H6gV7JD0kB1VkOdEcO6nmHPVdPAzM=; b=Cmwrf/m/QFCLLEcJWOHVUVCQ1DaO2z5yLON3jaTvvuM5nqJNoZFiqRduBZdGliIfya DvPX/tvHVqEk9WCO5WjFf1Yvbf8LZyU2Aa/uWfzRUHXE9ch25lN5/2zzcDnTmv9YnxJA LI7c7x3BcSr15C5Y4qdusVdo+/MV91Ufnp6GyPhP9Q8SDPkD5QLYVbcUmptQ/i2cV88E coxiBw4p/hWzY/zFJFzcesSuPqnJRu5rqORQ0vQ2sxruNeMAQHzeIeUAGa/23/2X96zN cYgGSL7fiwOESPfzAlGe5eAxWlQkqurKoPIvNFT9UmZE/Tc92aDetrNKlizFz38IhlKQ jpdg== X-Gm-Message-State: AKGB3mLDiItOSUsDQbnqqBlxTgk1OyEgtTw+j253J4LAnMnSDdJQgfDq jkFVgDUtrs1lgGI444qBGss+GM7TNyoRW662GnXbmA== X-Google-Smtp-Source: AGs4zMZqc5AX7NhQMo23VmN9mkrdqGyzNUaUljCtOkShZbu5OB2AjzwkUGY8PcyzhWrKlU/0W3Px27E2uLNpkWwHX2I= X-Received: by 10.36.77.143 with SMTP id l137mr6189841itb.50.1512742435081; Fri, 08 Dec 2017 06:13:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Fri, 8 Dec 2017 06:13:54 -0800 (PST) In-Reply-To: <20171208140810.454i7j467k24ig5o@bivouac.eciton.net> References: <1512674434-32326-1-git-send-email-mw@semihalf.com> <1512674434-32326-6-git-send-email-mw@semihalf.com> <20171208140810.454i7j467k24ig5o@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 8 Dec 2017 15:13:54 +0100 Message-ID: To: Leif Lindholm Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Konrad Adamczyk Subject: Re: [platforms: PATCH v2 5/5] Marvell/Drivers: Drop 'PciEmulation' naming X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 14:09:21 -0000 Content-Type: text/plain; charset="UTF-8" Hi Leif, 2017-12-08 15:08 GMT+01:00 Leif Lindholm : > On Fri, Dec 08, 2017 at 01:11:27PM +0100, Marcin Wojtas wrote: >> 2017-12-08 9:40 GMT+01:00 Ard Biesheuvel : >> > On 7 December 2017 at 23:08, Marcin Wojtas wrote: >> >> Hi Ard, >> >> >> >> 2017-12-07 20:49 GMT+01:00 Ard Biesheuvel : >> >>> Hi Marcin, >> >>> >> >>> On 7 December 2017 at 19:20, Marcin Wojtas wrote: >> >>>> 'PciEmulation' is not a proper naming for a driver, which >> >>>> uses NonDiscoverableDeviceRegistrationLib for handling >> >>>> the devices attached via internal bus of the SoC. >> >>>> Rename it to MvNonDiscoverableDxe and move under >> >>>> Silicon/Marvell/Drivers directory. >> >>>> >> >>> >> >>> Thank you! >> >>> >> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >> >>>> Signed-off-by: Marcin Wojtas >> >>>> --- >> >>>> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 4 +-- >> >>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 4 +-- >> >>>> Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} | 26 ++++++++++---------- >> >>>> Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} | 8 +++--- >> >>>> 4 files changed, 21 insertions(+), 21 deletions(-) >> >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} (84%) >> >>>> rename Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} (91%) >> >>>> >> >>> >> >>> Could we please have >> >>> >> >>> Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf >> >>> >> >>> instead? >> >>> >> >> >> >> My intention was to keep a generic naming at the first level inside >> >> the Silicon/Drivers/Marvell: >> >> I2c Net SdMmc Spi >> >> >> >> I can change it in a way you want, but to my taste >> >> MvNonDiscoverableDxe doesn't fully fit the company above. Do you see >> >> any possible compromise? :) >> >> >> > >> > Well, if you want 'generic' at the level below >> > Silicon/Drivers/Marvell, you will still need >> > MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf below that. >> > >> > So >> > >> > Drivers/NonDiscoverable/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf >> > >> > perhaps? >> >> This is ok to me. > > As we're bikeshedding... > > What would be the benefit of the above? > > I could get Drivers/NonDiscoverable/780xxNonDiscoverableDxe, but > surely if you're preparing for Armada 37xx (which I would be very > happy to see), having something called MvNonDiscoverableDxe is not > going to be very identifying. Well, I think we will most likely reuse this driver as is - on A37xx there is generic AHCI/XHCI and even same Xenon driver. So, are you fine with what I initially added in this patch (Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c, etc.), or you wish to use Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.c, etc? Best regards, Marcin > > I don't mind a few extra levels of directories in order to clear up > usage, but we do need to actually make use of it then. >